Skip to contentSkip to conversation

nanosleep testcase problem

LTP Mitani 3 participants 3 messages Jan 4, 2010 – Jan 6, 2010

lore
Share & tools
lore

Mitani

author
#0 lore raw

Hi,

I want to wish you happy new year.

------

By the way, I found a new problem with the "nanosleep02" testcase.

"main()" function executes fork(), and child process calls "do_child()" function.
"do_child()" function must be ended by "exit()". But in "nanosleep02" testcase, there is a case in which "exit()" isn't executed. Therefore, the child process lives after "do_child()" function, and it executes "wait()" function which must be executed in parent process only.

Here is the patch fixes these problem:

============

nanosleep02.c.new renamed from nanosleep02.c +3 -0
@@ -277,6 +277,9 @@
 		tst_resm(TPASS, "call succeeded");
 		exit(0);
 	}
+	
+	/* Everything is fine, exit normally */
+	exit(0);
 }
 
 /*

============

Regards--

-Tomonori Mitani

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#1 lore raw
Quoted 9 lines · Mitani

Hi,

I want to wish you happy new year.

------

By the way, I found a new problem with the "nanosleep02" testcase.

Quoted 7 lines

"main()" function executes fork(), and child process calls "do_child()" function.
"do_child()" function must be ended by "exit()". But in "nanosleep02" testcase, there is a case in which "exit()" isn't executed. Therefore, the child process lives after "do_child()" function, and it executes "wait()" function which must be executed in parent process only.

On Microblaze this test failed too. The patch fix it.

Michal

Quoted 36 lines

Here is the patch fixes these problem:

============

nanosleep02.c.new renamed from nanosleep02.c +3 -0
@@ -277,6 +277,9 @@
 		tst_resm(TPASS, "call succeeded");
 		exit(0);
 	}
+	
+	/* Everything is fine, exit normally */
+	exit(0);
 }
 
 /*

============

Regards--

-Tomonori Mitani

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Signature · 14 lines
Michal Simek, Ing. (M.Eng)
PetaLogix - Linux Solutions for a Reconfigurable World
w: www.petalogix.com p: +61-7-30090663,+42-0-721842854 f: +61-7-30090663

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
#2 lore raw
Quoted 37 lines · Michal Simek
Quoted 9 lines · Mitani

Hi,

I want to wish you happy new year.

------

By the way, I found a new problem with the "nanosleep02" testcase.

Quoted 7 lines

"main()" function executes fork(), and child process calls "do_child()" function.
"do_child()" function must be ended by "exit()". But in "nanosleep02" testcase, there is a case in which "exit()" isn't executed. Therefore, the child process lives after "do_child()" function, and it executes "wait()" function which must be executed in parent process only.

On Microblaze this test failed too. The patch fix it.

Michal

Quoted 15 lines

Here is the patch fixes these problem:

============

nanosleep02.c.new 2010-01-04 10:15:08.000000000 +0900 renamed from nanosleep02.c     2009-12-23 02:35:13.000000000 +0900 +3 -0
@@ -277,6 +277,9 @@
               tst_resm(TPASS, "call succeeded");
               exit(0);
       }
+
+     /* Everything is fine, exit normally */
+     exit(0);
  }
 
Quoted 1 line

nanosleep02.c.new 2010-01-04 10:15:08.000000000 +0900 line 285

Quoted 1 line
nanosleep02.c.new 2010-01-04 10:15:08.000000000 +0900 renamed from nanosleep02.c     2009-12-23 02:35:13.000000000 +0900 +0 -0
  /*

Committed a change on CVS which forces the child to exit at the
end of do_child, like it should with tst_exit().
Thanks!
-Garrett

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list