Skip to contentSkip to conversation

ARM: dts: add pin state information for DP HPD support to Exynos5250

PATCH Applied Jingoo Han 3 participants 3 messages May 11, 2013 – Jun 10, 2013

Subsystems (2)
lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 1/1 ARM: dts: add pin state information for DP HPD support to Exynos5250

Add pin state information for DP HPD support that requires pin configuration support using pinctrl interface.

---
Tested on Exynos5250

 arch/arm/boot/dts/exynos5250-pinctrl.dtsi |    7 +++++++
 arch/arm/boot/dts/exynos5250-smdk5250.dts |    3 +++
 2 files changed, 10 insertions(+), 0 deletions(-)
arch/arm/boot/dts/exynos5250-pinctrl.dtsi +7 -0
index d1650fb..e9cdee3 100644
@@ -553,6 +553,13 @@
 			samsung,pin-pud = <0>;
 			samaung,pin-drv = <0>;
 		};
+
+		dp_hpd: dp_hpd {
+			samsung,pins = "gpx0-7";
+			samsung,pin-function = <3>;
+			samsung,pin-pud = <0>;
+			samaung,pin-drv = <0>;
+		};
 	};
 
 	pinctrl at 13400000 {
arch/arm/boot/dts/exynos5250-smdk5250.dts +3 -0
index 3e0c792..d53ea34 100644
@@ -224,6 +224,9 @@
 		samsung,color-depth = <1>;
 		samsung,link-rate = <0x0a>;
 		samsung,lane-count = <4>;
+
+		pinctrl-names = "default";
+		pinctrl-0 = <&dp_hpd>;
 	};
 
 	display-timings {
Signature · 1 line
1.7.2.5
Reviewed-by on v1 1/1
#1 lore raw

Jingoo,

Quoted 34 lines · Jingoo Han

Add pin state information for DP HPD support that requires pin configuration support using pinctrl interface.

---
Tested on Exynos5250

 arch/arm/boot/dts/exynos5250-pinctrl.dtsi |    7 +++++++
 arch/arm/boot/dts/exynos5250-smdk5250.dts |    3 +++
 2 files changed, 10 insertions(+), 0 deletions(-)
arch/arm/boot/dts/exynos5250-pinctrl.dtsi +7 -0
index d1650fb..e9cdee3 100644
@@ -553,6 +553,13 @@
                        samsung,pin-pud = <0>;
                        samaung,pin-drv = <0>;
                };
+
+               dp_hpd: dp_hpd {
+                       samsung,pins = "gpx0-7";
+                       samsung,pin-function = <3>;
+                       samsung,pin-pud = <0>;
+                       samaung,pin-drv = <0>;
+               };
        };
 
        pinctrl at 13400000 {
arch/arm/boot/dts/exynos5250-smdk5250.dts +0 -0
index 3e0c792..d53ea34 100644

arch/arm/boot/dts/exynos5250-smdk5250.dts line 229

Quoted 6 lines
arch/arm/boot/dts/exynos5250-smdk5250.dts +3 -0
@@ -224,6 +224,9 @@
                samsung,color-depth = <1>;
                samsung,link-rate = <0x0a>;
                samsung,lane-count = <4>;
+
+               pinctrl-names = "default";
+               pinctrl-0 = <&dp_hpd>;

I was going to suggest moving this to exynos5250.dtsi but then realized that I saw a board recently that used a non-standard HPD pin recently! ...so keeping it in the board file (like you've done) is good.

...so looks good to me.

Applied
#2 lore raw
Quoted 50 lines · Doug Anderson

Jingoo,

Quoted 34 lines · Jingoo Han

Add pin state information for DP HPD support that requires pin configuration support using pinctrl interface.

---
Tested on Exynos5250

 arch/arm/boot/dts/exynos5250-pinctrl.dtsi |    7 +++++++
 arch/arm/boot/dts/exynos5250-smdk5250.dts |    3 +++
 2 files changed, 10 insertions(+), 0 deletions(-)
arch/arm/boot/dts/exynos5250-pinctrl.dtsi +7 -0
index d1650fb..e9cdee3 100644
@@ -553,6 +553,13 @@
                        samsung,pin-pud = <0>;
                        samaung,pin-drv = <0>;
                };
+
+               dp_hpd: dp_hpd {
+                       samsung,pins = "gpx0-7";
+                       samsung,pin-function = <3>;
+                       samsung,pin-pud = <0>;
+                       samaung,pin-drv = <0>;
+               };
        };
 
        pinctrl at 13400000 {
arch/arm/boot/dts/exynos5250-smdk5250.dts +0 -0
index 3e0c792..d53ea34 100644

arch/arm/boot/dts/exynos5250-smdk5250.dts line 229

Quoted 6 lines
arch/arm/boot/dts/exynos5250-smdk5250.dts +3 -0
@@ -224,6 +224,9 @@
                samsung,color-depth = <1>;
                samsung,link-rate = <0x0a>;
                samsung,lane-count = <4>;
+
+               pinctrl-names = "default";
+               pinctrl-0 = <&dp_hpd>;

I was going to suggest moving this to exynos5250.dtsi but then realized that I saw a board recently that used a non-standard HPD pin recently! ...so keeping it in the board file (like you've done) is good.

Quoted 3 lines

...so looks good to me.

Yeah, I agreed with Doug's comment :-)

Applied, thanks.

- Kukjin