Skip to contentSkip to conversation

ata: pata_arasan: Staticize local symbols

PATCH Applied Jingoo Han 3 participants 3 messages Aug 9, 2013

Subsystems (2)
libata libata pata arasan compact flash controller
lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 1/2 ata: pata_arasan: Staticize local symbols

These local symbols are used only in this file.
Fix the following sparse warnings:

drivers/ata/pata_arasan_cf.c:657:6: warning: symbol 'arasan_cf_error_handler' was not declared. Should it be static? drivers/ata/pata_arasan_cf.c:686:14: warning: symbol 'arasan_cf_qc_issue' was not declared. Should it be static?

Signed-off-by Jingoo Han <[email protected]>
---
 drivers/ata/pata_arasan_cf.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/ata/pata_arasan_cf.c +2 -2
index 848ed32..853f610 100644
@@ -654,7 +654,7 @@ static void arasan_cf_freeze(struct ata_port *ap)
 	ata_sff_freeze(ap);
 }
 
-void arasan_cf_error_handler(struct ata_port *ap)
+static void arasan_cf_error_handler(struct ata_port *ap)
 {
 	struct arasan_cf_dev *acdev = ap->host->private_data;
 

@@ -683,7 +683,7 @@ static void arasan_cf_dma_start(struct arasan_cf_dev *acdev)
 	ata_sff_queue_work(&acdev->work);
 }
 
-unsigned int arasan_cf_qc_issue(struct ata_queued_cmd *qc)
+static unsigned int arasan_cf_qc_issue(struct ata_queued_cmd *qc)
 {
 	struct ata_port *ap = qc->ap;
 	struct arasan_cf_dev *acdev = ap->host->private_data;
Signature · 1 line
1.7.10.4
Acked-by on v1 1/2
#1 lore raw
Quoted 10 lines · Jingoo Han

These local symbols are used only in this file.
Fix the following sparse warnings:

drivers/ata/pata_arasan_cf.c:657:6: warning: symbol 'arasan_cf_error_handler' was not declared. Should it be static? drivers/ata/pata_arasan_cf.c:686:14: warning: symbol 'arasan_cf_qc_issue' was not declared. Should it be static?

Signed-off-by Jingoo Han <[email protected]>
---
 drivers/ata/pata_arasan_cf.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by Viresh Kumar <[email protected]>
Applied
#2 lore raw
In reply to Jingoo Han
Quoted 7 lines · Jingoo Han

These local symbols are used only in this file.
Fix the following sparse warnings:

drivers/ata/pata_arasan_cf.c:657:6: warning: symbol 'arasan_cf_error_handler' was not declared. Should it be static? drivers/ata/pata_arasan_cf.c:686:14: warning: symbol 'arasan_cf_qc_issue' was not declared. Should it be static?

Signed-off-by Jingoo Han <[email protected]>

Applied to libata/for-3.12.

Thanks.

Signature · 1 line
tejun