f2fs: fix memory leak after kobject init failed in fill_super
Subsystems (2)
PATCH 1/1 f2fs: fix memory leak after kobject init failed in fill_super
If we failed to init&add kobject when fill_super, stats info and proc object of f2fs will not be released. We should free them before we finish fill_super.
Signed-off-by Chao Yu <[email protected]>
--- fs/f2fs/super.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
fs/f2fs/super.c +8 -2
@@ -974,12 +974,12 @@ static int f2fs_fill_super(struct super_block *sb, void *data, int silent)/* After POR, we can run background GC thread.*/ err =start_gc_thread (sbi);if (err) - goto fail; + goto free_gc; } err =f2fs_build_stats (sbi);if (err) - goto fail; + goto free_gc;if (f2fs_proc_root) sbi->s_proc =proc_mkdir (sb->s_id, f2fs_proc_root);
@@ -1005,6 +1005,12 @@ static int f2fs_fill_super(struct super_block *sb, void *data, int silent)return 0 ; fail: +if (sbi->s_proc) { +remove_proc_entry ("segment_info" , sbi->s_proc); +remove_proc_entry (sb->s_id, f2fs_proc_root); + } +f2fs_destroy_stats (sbi); +free_gc:stop_gc_thread (sbi); free_root_inode:dput (sb->s_root);
Signature · 1 line
1.7.9.5