f2fs: fix dirty page accounting when redirty
Subsystems (2)
PATCH 1/1 f2fs: fix dirty page accounting when redirty
We should de-account dirty counters for page when redirty in ->writepage().
Wu Fengguang described in 'commit 971767caf632190f77a40b4011c19948232eed75':
"writeback: fix dirtied pages accounting on redirty
De-account the accumulative dirty counters on page redirty.
Page redirties (very common in ext4) will introduce mismatch between counters (a) and (b)
a) NR_DIRTIED, BDI_DIRTIED, tsk->nr_dirtied
b) NR_WRITTEN, BDI_WRITTEN
This will introduce systematic errors in balanced_rate and result in dirty page position errors (ie. the dirty pages are no longer balanced around the global/bdi setpoints)."
--- fs/f2fs/checkpoint.c | 1 + fs/f2fs/data.c | 1 + fs/f2fs/node.c | 1 + 3 files changed, 3 insertions(+)
fs/f2fs/checkpoint.c +1 -0
@@ -178,6 +178,7 @@ no_write: redirty_out:dec_page_count (sbi,F2FS_DIRTY_META ); wbc->pages_skipped++; +account_page_redirty (page);set_page_dirty (page);return AOP_WRITEPAGE_ACTIVATE ; }
fs/f2fs/data.c +1 -0
@@ -839,6 +839,7 @@ out: redirty_out: wbc->pages_skipped++; +account_page_redirty (page);set_page_dirty (page);return AOP_WRITEPAGE_ACTIVATE ; }
fs/f2fs/node.c +1 -0
@@ -1193,6 +1193,7 @@ static int f2fs_write_node_page(struct page *page, redirty_out:dec_page_count (sbi,F2FS_DIRTY_NODES ); wbc->pages_skipped++; +account_page_redirty (page);set_page_dirty (page);return AOP_WRITEPAGE_ACTIVATE ; }
Signature · 9 lines
1.7.9.5 ------------------------------------------------------------------------------ Flow-based real-time traffic analytics software. Cisco certified tool. Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer Customize your own dashboards, set traffic alerts and generate reports. Network behavioral analysis & security monitoring. All-in-one tool. http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk
Quoted 28 lines · Chao Yu
We should de-account dirty counters for page when redirty in ->writepage().
Wu Fengguang described in 'commit
971767caf632190f77a40b4011c19948232eed75':
"writeback: fix dirtied pages accounting on redirty
De-account the accumulative dirty counters on page redirty.Page redirties (very common in ext4) will introduce mismatch between counters (a) and (b)
a)
NR_DIRTIED,BDI_DIRTIED,tsk->nr_dirtied
b)NR_WRITTEN,BDI_WRITTENThis will introduce systematic errors in
balanced_rateand result in dirty page position errors (ie. the dirty pages are no longer balanced around the global/bdi setpoints)."Signed-off-by Chao Yu <[email protected]>--- fs/f2fs/checkpoint.c | 1 + fs/f2fs/data.c | 1 + fs/f2fs/node.c | 1 + 3 files changed, 3 insertions(+)fs/f2fs/checkpoint.c +0
-0
fs/f2fs/checkpoint.c no_write: · line 183
Quoted 6 lines
fs/f2fs/checkpoint.c +1
-0@@ -178,6 +178,7 @@ no_write: redirty_out:dec_page_count (sbi,F2FS_DIRTY_META ); wbc->pages_skipped++; +account_page_redirty (page);set_page_dirty (page);return AOP_WRITEPAGE_ACTIVATE ;
redirty_page_for_writepage()?
Cheers,
Dave.
Signature · 2 lines
Dave Chinner [email protected]
Hi,
Quoted 32 lines
-----Original Message-----
From: Dave Chinner [mailto:[email protected]]
Sent: Saturday, March 01, 2014 8:27 AM
To: Chao Yu
Cc: ???; [email protected]; [email protected]; [email protected]
Subject: Re: [f2fs-dev] [PATCH] f2fs: fix dirty page accounting when redirtyQuoted 23 lines · Chao Yu
We should de-account dirty counters for page when redirty in ->writepage().
Wu Fengguang described in 'commit
971767caf632190f77a40b4011c19948232eed75':
"writeback: fix dirtied pages accounting on redirty
De-account the accumulative dirty counters on page redirty.Page redirties (very common in ext4) will introduce mismatch between counters (a) and (b)
a)
NR_DIRTIED,BDI_DIRTIED,tsk->nr_dirtied
b)NR_WRITTEN,BDI_WRITTENThis will introduce systematic errors in
balanced_rateand result in dirty page position errors (ie. the dirty pages are no longer balanced around the global/bdi setpoints)."Signed-off-by Chao Yu <[email protected]>--- fs/f2fs/checkpoint.c | 1 + fs/f2fs/data.c | 1 + fs/f2fs/node.c | 1 + 3 files changed, 3 insertions(+)
Quoted 13 lines
fs/f2fs/checkpoint.c no_write: · line 183
Quoted 11 lines
fs/f2fs/checkpoint.c +1
-0@@ -178,6 +178,7 @@ no_write: redirty_out:dec_page_count (sbi,F2FS_DIRTY_META ); wbc->pages_skipped++; +account_page_redirty (page);set_page_dirty (page);return AOP_WRITEPAGE_ACTIVATE ;
redirty_page_for_writepage()?
set_page_dirty() in a_ops of f2fs not only call __set_page_dirty_nobuffers(), but also set some private data of page and print trace info.
So it seems we could not easily replace with redirty_page_for_writepage().
Thanks.
Quoted 7 lines
Cheers,
Dave.
--
Dave Chinner
[email protected]
------------------------------------------------------------------------------
Flow-based real-time traffic analytics software. Cisco certified tool. Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer Customize your own dashboards, set traffic alerts and generate reports. Network behavioral analysis & security monitoring. All-in-one tool.
http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk