Skip to contentSkip to conversation

fat: additions to support fat_fallocate

PATCH Superseded Namjae Jeon 2 participants 3 messages Sep 25, 2014 – Sep 29, 2014 VFS

v5 of 8 Superseded Latest is v8 →

lore
Share & tools
lore
#0 lore raw

v5 cover fat: additions to support fat_fallocate

This patch set provides support for doing fallocate operation on FAT filesystem.

v5:
- change all routines to make ->i_disksize aligned by cluster size.
- merge fat_bmap2() and fat_get_block_bmap().

v4:
- ->i_disksize is aligned by block size in fill_inode.
- use i_disksize when computing the number of cluster for fallocate.
- make fat_get_block_bmap to avoid race issue.
- use __fat_write_inode() with inode_needs_sync() in evict.

v3:
- fix i_disksize and mmu_private comments(uninit/initialized)
- remove unneeded condition in fat_bmap.
- use mmu_private instead of fclus in fat_fallocate.
- make function mark buffer new for block in fallocated region.
- use flags for bmap.
- use mmu_private instead of i_size in direct_IO.
- use flags and remove i_mutex in bmap.
- update vfat documentation.

v2:
- remove a stary unlock(from Dan Carpenter)
- check ->mmu_private and ->i_disksize to truncate uninitialized data.

Namjae Jeon (5):
fat: add i_disksize to represent uninitialized size
fat: add fat_fallocate operation
fat: skip cluster allocation on fallocated region
fat: permit to return phy block number by fibmap in fallocated region Documentation/filesystems/vfat.txt: update the limitation for fat fallocate

Signature · 1 line
1.7.11-rc0
#1 lore raw
Quoted 6 lines · On Thu, 25 Sep 2014 14:30:57 +0900 Namjae Jeon <[email protected]> wrote:

Namjae Jeon (5):
fat: add i_disksize to represent uninitialized size
fat: add fat_fallocate operation
fat: skip cluster allocation on fallocated region
fat: permit to return phy block number by fibmap in fallocated region Documentation/filesystems/vfat.txt: update the limitation for fat fallocate

What happened to fat-zero-out-seek-range-on-_fat_get_block-v4.patch?

It would be nice to get this patchset wrapped up some time - it's been over a year...

#2 lore raw
Quoted 8 lines
Quoted 7 lines

Namjae Jeon (5):
fat: add i_disksize to represent uninitialized size
fat: add fat_fallocate operation
fat: skip cluster allocation on fallocated region
fat: permit to return phy block number by fibmap in fallocated region Documentation/filesystems/vfat.txt: update the limitation for fat fallocate

Quoted 4 lines

What happened to fat-zero-out-seek-range-on-_fat_get_block-v4.patch?

It would be nice to get this patchset wrapped up some time - it's been over a year...

Hi Andrew,

Sorry that I didn't note definitely and it was late for rework.. Actually I didn't have any idea to fix remained issue and was involved in some other works.

I have reworked all routines with i_disksize redefinition (cluster size aligned) and also with changing the i_disksize definition fat-zero-out-seek-range-on- _fat_get_block-v4.patch is no more needed as is. Also, the functionality served more purpose with the naming skip cluster allocation on fallocated region.

Thanks!