Skip to contentSkip to conversation

ntb_transport: Pick an unused queue

PATCH In review Aaron Sierra 3 participants 3 messages Feb 13, 2017 – Feb 17, 2017 NTB driver core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ntb_transport: Pick an unused queue

From: Thomas VanSelus <[email protected]>

Fix typo causing ntb_transport_create_queue to select the first queue every time, instead of using the next free queue.

---
 drivers/ntb/ntb_transport.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ntb/ntb_transport.c +1 -1
index f81aa4b..95b5540 100644
@@ -1802,7 +1802,7 @@ ntb_transport_create_queue(void *data, struct device *client_dev,
 
 	node = dev_to_node(&ndev->dev);
 
-	free_queue = ffs(nt->qp_bitmap);
+	free_queue = ffs(nt->qp_bitmap_free);
 	if (!free_queue)
 		goto err;
 
Signature · 1 line
2.7.4
Acked-by on v1 1/1
#1 lore raw

From: Aaron Sierra

Quoted 7 lines

From: Thomas VanSelus <[email protected]>

Fix typo causing ntb_transport_create_queue to select the first queue every time, instead of using the next free queue.

Quoted 17 lines
---
 drivers/ntb/ntb_transport.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ntb/ntb_transport.c +1 -1
index f81aa4b..95b5540 100644
@@ -1802,7 +1802,7 @@ ntb_transport_create_queue(void *data, struct device *client_dev,
 
 	node = dev_to_node(&ndev->dev);
 
-	free_queue = ffs(nt->qp_bitmap);
+	free_queue = ffs(nt->qp_bitmap_free);
 	if (!free_queue)
 		goto err;
 
maintainer
#2 lore raw
Quoted 10 lines · Allen Hubbe

From: Aaron Sierra

Quoted 7 lines

From: Thomas VanSelus <[email protected]>

Fix typo causing ntb_transport_create_queue to select the first queue every time, instead of using the next free queue.

Good catch! This has been in there from the beginning.

Add a

Fixes fce8a7bb5 ("PCI-Express Non-Transparent Bridge Support")

and applied to my ntb branch.

Thanks,
Jon

Quoted 19 lines
Quoted 18 lines
---
 drivers/ntb/ntb_transport.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ntb/ntb_transport.c +1 -1
index f81aa4b..95b5540 100644
@@ -1802,7 +1802,7 @@ ntb_transport_create_queue(void *data, struct device *client_dev,
 
 	node = dev_to_node(&ndev->dev);
 
-	free_queue = ffs(nt->qp_bitmap);
+	free_queue = ffs(nt->qp_bitmap_free);
 	if (!free_queue)
 		goto err;