Skip to contentSkip to conversation

report correct CPU/cache topology

PATCH David Wang 1 participant 1 message May 2, 2018

lore
Share & tools
lore

David Wang

author
#0 lore raw
Quoted 28 lines

-----Original Mail-----
Sender: Thomas Gleixner [mailto:[email protected]]
Time: 2018年4月26日 19:56
Receiver: David Wang <[email protected]>
CC: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; brucechang@via- alliance.com; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v3] report correct CPU/cache topology

Quoted 7 lines · David Wang

Centaur CPUs enumerate the cache topology in the same way as Intel CPUs, but the function is unused so far.
The Centaur init code also misses to initialize x86_info::max_cores, so the CPU topology can't be described correctly.

Initialize x86_info::max_cores and invoke init_intel_cachinfo() to make CPU and cache topology information avaliable and correct

Now that looks pretty good.

Quoted 2 lines
Quoted 7 lines
Quoted 4 lines

Changes from v2 to v3:
*1 define new detect_num_cpu_cores() in common.c to replace the original intel_num_cpu_cores;
*2 move cpu_detect_cache_sizes inside init_intel_cacheinfo.

But I asked for that being a separate patch with a separate changelog. And the intel_cache_info() change wants to be in a separate patch as well.

Then

Quoted 9 lines

the third patch is the one which makes use of these changes for centaur.

Please read review comments carefully and rather ask when you have doubts about the meaning.

Thanks,

tglx

Sorry!
I will split the changes to three separate patches. Thank you.
---
David