Skip to contentSkip to conversation

x86/mce: add CMCI support for Centaur CPUs

PATCH David Wang 1 participant 1 message May 2, 2018

lore
Share & tools
lore

David Wang

author
#0 lore raw
Quoted 41 lines

-----Original Mail-----
Sender: Borislav Petkov [mailto:[email protected]]
Time: 2018年4月30日 17:48
Receiver: David Wang <[email protected]>
CC: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; linux- [email protected]; [email protected]; brucechang@via- alliance.com; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH v3 2/2] x86/mce: add CMCI support for Centaur CPUs

Quoted 1 line · David Wang

Newer Centaur support CMCI mechnism, which is compatible with INTEL

CMCI.

arch/x86/kernel/cpu/mcheck/mce.c static void __mcheck_cpu_init_vendor(struct

Quoted 12 lines
---
 arch/x86/kernel/cpu/mcheck/mce.c | 2 ++
 1 file changed, 2 insertions(+)
arch/x86/kernel/cpu/mcheck/mce.c +0 -0
index 38ccab8..f9a7295 100644
@@ -1757,6 +1757,8 @@ static void __mcheck_cpu_init_vendor(struct

cpuinfo_x86 *c)

arch/x86/kernel/cpu/mcheck/mce.c static void __mcheck_cpu_init_vendor(struct · line 1761

Quoted 5 lines
arch/x86/kernel/cpu/mcheck/mce.c +2 -0
 		}
 	case X86_VENDOR_CENTAUR:
 		mce_centaur_feature_init(c);
+		mce_intel_feature_init(c);
+		mce_adjust_timer = cmci_intel_adjust_timer;

This won't work in configs with CONFIG_X86_MCE_INTEL disabled.

You need to define CONFIG_X86_MCE_CENTAUR or so which depends on CONFIG_CPU_SUP_CENTAUR and CONFIG_X86_MCE_INTEL and which then makes sure the intel CMCI et al stuff is enabled.

Quoted 5 lines

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

OK. I got it.
I will send another patch.
Thank you.

---
David