Skip to contentSkip to conversation

ASoC: soc-compress: lock pcm_mutex to resolve lockdep error

PATCH New 이경택 1 participant 1 message Mar 26, 2020 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): CGME20200326084556epcas2p43870d47530ef1381e52e2ca85d196298@epcas2p4.samsung.com

이경택

author
#1 lore raw

cover ASoC: soc-compress: lock pcm_mutex to resolve lockdep error

Hi,

I'd like to send a patch to fix a problem using soc-compress with DPCM. soc_compr_open_fe() and soc_compr_free_fe() call snd_soc_runtime_activate() and snd_soc_runtime_deactivate() but don't lock card->pcm_mutex. It can cause lockdep error, because snd_soc_runtime_activate/deactivate() checks whether pcm_mutex is held using lockdep_assert_held(). I'd like to send a patch which adds mutex_lock/unlock()
before and after of the snd_soc_runtime_activate/deactivate() call. If there is anything should be changed in my patch or email, please let me know it.
I'll really appreciate it.

Gyeongtaek Lee (1):
ASoC: soc-compress: lock pcm_mutex to resolve lockdep error

 sound/soc/soc-compress.c | 4 ++++
 1 file changed, 4 insertions(+)

base-commit: 76ccd234269bd05debdbc12c96eafe62dd9a6180

Signature · 1 line
2.21.0