Skip to contentSkip to conversation

net: phy: micrel: Staticize ksz8873mll_read_status()

PATCH Applied Jingoo Han 2 participants 2 messages Aug 6, 2013 – Aug 7, 2013

Subsystems (3)
Networking Network drivers Ethernet PHY
lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 1/3 net: phy: micrel: Staticize ksz8873mll_read_status()

ksz8873mll_read_status() is used only in this file. Fix the following sparse warning:

drivers/net/phy/micrel.c:147:5: warning: symbol 'ksz8873mll_read_status' was not declared. Should it be static?

Signed-off-by Jingoo Han <[email protected]>
---
 drivers/net/phy/micrel.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/phy/micrel.c +1 -1
index 2510435..9ca4945 100644
@@ -144,7 +144,7 @@ static int ks8051_config_init(struct phy_device *phydev)
 #define KSZ8873MLL_GLOBAL_CONTROL_4	0x06
 #define KSZ8873MLL_GLOBAL_CONTROL_4_DUPLEX	(1 << 6)
 #define KSZ8873MLL_GLOBAL_CONTROL_4_SPEED	(1 << 4)
-int ksz8873mll_read_status(struct phy_device *phydev)
+static int ksz8873mll_read_status(struct phy_device *phydev)
 {
 	int regval;
Signature · 1 line
1.7.10.4
maintainer Applied
#1 lore raw

From: Jingoo Han <[email protected]>
Date: Tue, 06 Aug 2013 17:29:35 +0900

Quoted 6 lines

ksz8873mll_read_status() is used only in this file. Fix the following sparse warning:

drivers/net/phy/micrel.c:147:5: warning: symbol 'ksz8873mll_read_status' was not declared. Should it be static?

Signed-off-by Jingoo Han <[email protected]>

Applied.