block: sx8: use module_pci_driver()
PATCH 1/2 block: sx8: use module_pci_driver()
Use module_pci_driver() macro which makes the code smaller and simpler.
Signed-off-by Jingoo Han <[email protected]>
--- drivers/block/sx8.c | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-)
drivers/block/sx8.c +1 -14
@@ -1747,17 +1747,4 @@ static void carm_remove_one (struct pci_dev *pdev)pci_set_drvdata (pdev,NULL ); } -static int __init carm_init (void ) -{ -return pci_register_driver (&carm_driver); -} - -static void __exit carm_exit(void) -{ -pci_unregister_driver (&carm_driver); -} - -module_init (carm_init); -module_exit (carm_exit); - - +module_pci_driver (carm_driver);
Signature · 1 line
1.7.10.4
PATCH 2/2 block: sx8: remove unnecessary pci_set_drvdata()
The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by Jingoo Han <[email protected]>
--- drivers/block/sx8.c | 1 - 1 file changed, 1 deletion(-)
drivers/block/sx8.c +0 -1
@@ -1744,7 +1744,6 @@ static void carm_remove_one (struct pci_dev *pdev)kfree (host);pci_release_regions (pdev);pci_disable_device (pdev); -pci_set_drvdata (pdev,NULL ); }module_pci_driver (carm_driver);
Signature · 1 line
1.7.10.4