x86/mce: new Centaur CPUs support MCE broadcasting
Quoted 78 lines
-----邮件原件-----
发件人: Borislav Petkov [mailto:[email protected]]
发送时间: 2018年4月16日 21:28
收件人: David Wang <[email protected]>
抄送: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; linux- [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected] 主题: Re: [PATCH v2 1/2] x86/mce: new Centaur CPUs support MCE broadcastingQuoted 1 line · David Wang
This patch is used to tell the kernel that newer Centaur CPU support
Avoid writing "This patch" in the commit message of a patch. It is tautologically useless.
Quoted 13 lines
MCE broadcasting.
Signed-off-by David Wang <[email protected]>--- arch/x86/kernel/cpu/mcheck/mce.c | 11 +++++++++++ 1 file changed, 11 insertions(+)arch/x86/kernel/cpu/mcheck/mce.c +0
-0arch/x86/kernel/cpu/mcheck/mce.c static int __mcheck_cpu_apply_quirks(struct · line 1688
Quoted 1 line
arch/x86/kernel/cpu/mcheck/mce.c +0
-0@@ -1688,6 +1688,17 @@ static int __mcheck_cpu_apply_quirks(struct cpuinfo_x86 *c)This code doesn't belong in the "
apply_quirks" function but in__mcheck_cpu_init_vendor(). Just add aX86_VENDOR_CENTAURcase there.I know, I know, there's a similar Intel piece which does the same thing but all that quirks code should go to the vendor-specific init functions and the quirks function be deleted. One day when I get bored...
arch/x86/kernel/cpu/mcheck/mce.c static int __mcheck_cpu_apply_quirks(struct · line 1699
Quoted 11 lines
arch/x86/kernel/cpu/mcheck/mce.c +8
-0if (c->x86 ==6 && c->x86_model ==45 ) quirk_no_way_out = quirk_sandybridge_ifu; } + +if (c->x86_vendor ==X86_VENDOR_CENTAUR ) { +/* +* All newer Centaur CPUs support MCE broadcasting. Enable +* synchronization with a one second timeout. +*/ + if ((c->x86 > 6 || (c->x86 == 6 && c->x86_model == 0xf && +c->x86_mask >=0xe)) &&
arch/x86/kernel/cpu/mcheck/mce.c: In function ‘__mcheck_cpu_apply_quirks’:arch/x86/kernel/cpu/mcheck/mce.c:1688:64: error: ‘struct cpuinfo_x86’ has no member named ‘x86_mask’; did you mean ‘x86_model’?
if ((c->x86> 6 || (c->x86== 6 &&c->x86_model==0xf&&c->x86_maskQuoted 1 line
=0xe)) &&
^~~~~~~~ x86_modeland no, it needs to be
x86_stepping.Also,
ERROR: spaces required around that '>=' (ctx:WxV)
#40: FILE:arch/x86/kernel/cpu/mcheck/mce.c:1697:
+ if ((c->x86> 6 || (c->x86== 6 &&c->x86_model==0xf
+ &&c->x86_mask>=0xe)) &&^Please integrate
scripts/checkpatch.plinto your patch creation workflow. Some of the warnings/errors *actually* make sense.
Quoted 7 lines
Thx.
--
Regards/Gruss,
Boris.Good mailing practices for 400: avoid top-posting and trim the reply.
I will send patch v3 to solve all questions you listed. Thx.
---
David