net: irda: remove unnecessary platform_set_drvdata()
Subsystems (2)
PATCH v2 2/4 net: irda: remove unnecessary platform_set_drvdata()
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by Jingoo Han <[email protected]>
--- drivers/net/irda/bfin_sir.c | 1 - drivers/net/irda/sh_irda.c | 1 - drivers/net/irda/sh_sir.c | 1 - 3 files changed, 3 deletions(-)
drivers/net/irda/bfin_sir.c +0 -1
@@ -794,7 +794,6 @@ static int bfin_sir_remove(struct platform_device *pdev)kfree (self->rx_buff.head);free_netdev (dev);kfree (sir_port); -platform_set_drvdata (pdev,NULL );return 0 ; }
drivers/net/irda/sh_irda.c +0 -1
@@ -838,7 +838,6 @@ static int sh_irda_remove(struct platform_device *pdev)sh_irda_remove_iobuf (self);iounmap (self->membase);free_netdev (ndev); -platform_set_drvdata (pdev,NULL );return 0 ; }
drivers/net/irda/sh_sir.c +0 -1
@@ -796,7 +796,6 @@ static int sh_sir_remove(struct platform_device *pdev)sh_sir_remove_iobuf (self);iounmap (self->membase);free_netdev (ndev); -platform_set_drvdata (pdev,NULL );return 0 ; }
Signature · 1 line
1.7.10.4
From: Jingoo Han <[email protected]>
Date: Tue, 28 May 2013 14:03:49 +0900
Quoted 7 lines
The driver core clears the driver data to NULL after
device_releaseor on probe failure, since commit0998d0631001288a5974afc0b2a5f568bcdecb4d(device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.Signed-off-by Jingoo Han <[email protected]>
Applied.