Skip to contentSkip to conversation

remoteproc: ste_modem: Staticize local symbols

PATCH In review Jingoo Han 2 participants 2 messages Aug 12, 2013 – Feb 24, 2014 Remote processor (remoteproc)

lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 1/1 remoteproc: ste_modem: Staticize local symbols

These local symbols are used only in this file.
Fix the following sparse warnings:

drivers/remoteproc/ste_modem_rproc.c:167:27: warning: symbol 'sproc_fw_ops' was not declared. Should it be static? drivers/remoteproc/ste_modem_rproc.c:196:25: warning: symbol 'sproc_dev_cb' was not declared. Should it be static?

Signed-off-by Jingoo Han <[email protected]>
---
 drivers/remoteproc/ste_modem_rproc.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/remoteproc/ste_modem_rproc.c +2 -2
index 1ec39a4..c4ac910 100644
@@ -164,7 +164,7 @@ sproc_find_loaded_rsc_table(struct rproc *rproc, const struct firmware *fw)
 }
 
 /* STE modem firmware handler operations */
-const struct rproc_fw_ops sproc_fw_ops = {
+static const struct rproc_fw_ops sproc_fw_ops = {
 	.load = sproc_load_segments,
 	.find_rsc_table = sproc_find_rsc_table,
 	.find_loaded_rsc_table = sproc_find_loaded_rsc_table,

@@ -193,7 +193,7 @@ static void sproc_kick_callback(struct ste_modem_device *mdev, int vqid)
 		sproc_dbg(sproc, "no message was found in vqid %d\n", vqid);
 }
 
-struct ste_modem_dev_cb sproc_dev_cb = {
+static struct ste_modem_dev_cb sproc_dev_cb = {
 	.kick = sproc_kick_callback,
 };
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 7 lines · Jingoo Han

These local symbols are used only in this file.
Fix the following sparse warnings:

drivers/remoteproc/ste_modem_rproc.c:167:27: warning: symbol 'sproc_fw_ops' was not declared. Should it be static? drivers/remoteproc/ste_modem_rproc.c:196:25: warning: symbol 'sproc_dev_cb' was not declared. Should it be static?

Signed-off-by Jingoo Han <[email protected]>

Applied and pushed to remoteproc-next, thanks!