Skip to contentSkip to conversation

- tty hangings - patches, dmesg & sysctl+T info

BUG Shawn Starr 1 participant 1 message Apr 12, 2003

lore
Share & tools
lore
#0 lore raw

It's been three days since I applied the patch. No tty hangings have been happening. From what I've tested the patch you've given works great.

Please consider applying to next BK snapshot.

Shawn.

-----Original Message-----
From: Shawn Starr [mailto:[email protected]]
Sent: Wednesday, April 09, 2003 1:02 AM
To: 'Roland Dreier'; 'Andrew Morton'
Cc: '[email protected]'; '[email protected]'; '[email protected]'
Subject: RE: [BUG][2.5.66bk9+] - tty hangings - patches, dmesg & sysctl+T info

Applying akpm's patch now, expect a result in 1-2 days since that's how long it takes to begin to destabilize :-)

Shawn.

-----Original Message-----
From: Roland Dreier [mailto:[email protected]]
Sent: Wednesday, April 09, 2003 12:52 AM
To: Andrew Morton
Cc: [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [BUG][2.5.66bk9+] - tty hangings - patches, dmesg & sysctl+T info
Importance: High

Andrew> No, I agree. I don't think pending delayed work should Andrew> contribute to the count at all.

Andrew> If someone wants to synchronise with the workqueue system Andrew> they should cancel any delayed work which they own (via Andrew> cancel_scheduled_work) and then wait on any Andrew> currently-queued works via flush_scheduled_work().

Andrew> So flush_scheduled_work() only needs to care about Andrew> currently-queued works, not the ones which are pending a Andrew> timer event.

Andrew> And flush_scheduled_work() needs to be taught to not lock Andrew> up if someone keeps re-adding work.

Ah, I see... your patch that added insert_sequence and remove_sequence was intended to apply on top of the patch that adds cancel_delayed_work().

Please ignore the reply to your patch that I just sent, I misunderstood what you were trying to do.

Shawn, I think if you add Andrew's most recent patch on top of what you were running with, your problem should probably be fixed.

Sorry for the extra noise.

- Roland