Skip to contentSkip to conversation

fix "8-3-buildonly"

PATCH In review Mitani 2 participants 2 messages Aug 11, 2010 – Aug 12, 2010

lore
Share & tools
lore

Mitani

author
#0 lore raw

PATCH 1/1 fix "8-3-buildonly"

Hi,

I tried to build open_posix_testsuite testcases with latest git:
ltp-dev-7c67a09a10268b5f9f503e0254f1f0f9f5ac2b69.tar.gz

Several testcases failed to build.
One of them is as follows:
------------
[...]
conformance/definitions/sched_h/8-3-buildonly compile FAILED ../../../conformance/definitions/sched_h/8-3-buildonly.c:24:2: error: #error SCHED_SPORADIC not defined
[...]
------------

"8-3-buildonly.c" outputs "SCHED_SPORADIC not defined" message by condition:

------------(8-3-buildonly.c)
[...]
#include <sched.h>
#include <unistd.h>

#if (defined(_POSIX_SPORADIC_SERVER) && _POSIX_SPORADIC_SERVER != -1) \
    || (defined(_POSIX_THREAD_SPORADIC_SERVER) && \
        POSIX_THREAD_SPORADIC_SERVER != -1)

#ifndef SCHED_SPORADIC
#error SCHED_SPORADIC not defined
#endif

#endif
------------

I noticed that "POSIX_THREAD_SPORADIC_SERVER" parameter has not "_" in its top.

============
---
a/testcases/open_posix_testsuite/conformance/definitions/sched_h/8-3-buildon
ly.c 2010-08-05 22:28:15.000000000 +0900
+++
b/testcases/open_posix_testsuite/conformance/definitions/sched_h/8-3-buildon
ly.c 2010-08-11 10:22:24.000000000 +0900
@@ -18,7 +18,7 @@

 #if (defined(_POSIX_SPORADIC_SERVER) && _POSIX_SPORADIC_SERVER != -1) \
     || (defined(_POSIX_THREAD_SPORADIC_SERVER) && \

- POSIX_THREAD_SPORADIC_SERVER != -1)
+ _POSIX_THREAD_SPORADIC_SERVER != -1)

#ifndef SCHED_SPORADIC
#error SCHED_SPORADIC not defined
============

After applying above patch, "8-3-buildonly.c" succeeded to build.

Regards--

-Tomonori Mitani

testcases/open_posix_testsuite/conformance/definitions/sched_h/8-3-buildonly.c +1 -1
@@ -18,7 +18,7 @@
 
 #if (defined(_POSIX_SPORADIC_SERVER) && _POSIX_SPORADIC_SERVER != -1) \
     || (defined(_POSIX_THREAD_SPORADIC_SERVER) && \
-	POSIX_THREAD_SPORADIC_SERVER != -1)
+	_POSIX_THREAD_SPORADIC_SERVER != -1)
 
 #ifndef SCHED_SPORADIC
 #error SCHED_SPORADIC not defined

------------------------------------------------------------------------------
This SF.net email is sponsored by

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#1 lore raw

2010/8/10 Mitani <[email protected]>:

Quoted 59 lines

Hi,

I tried to build open_posix_testsuite testcases with latest git:
  ltp-dev-7c67a09a10268b5f9f503e0254f1f0f9f5ac2b69.tar.gz

Several testcases failed to build.
One of them is as follows:
------------
[...]
conformance/definitions/sched_h/8-3-buildonly compile FAILED ../../../conformance/definitions/sched_h/8-3-buildonly.c:24:2: error: #error SCHED_SPORADIC not defined
[...]
------------

"8-3-buildonly.c" outputs "SCHED_SPORADIC not defined" message by condition:

------------(8-3-buildonly.c)
[...]
#include <sched.h>
#include <unistd.h>

#if (defined(_POSIX_SPORADIC_SERVER) && _POSIX_SPORADIC_SERVER != -1) \
   || (defined(_POSIX_THREAD_SPORADIC_SERVER) && \
       POSIX_THREAD_SPORADIC_SERVER != -1)

#ifndef SCHED_SPORADIC
#error SCHED_SPORADIC not defined
#endif

#endif
------------

I noticed that "POSIX_THREAD_SPORADIC_SERVER" parameter has not "_" in its top.

============
---
a/testcases/open_posix_testsuite/conformance/definitions/sched_h/8-3-buildon ly.c    2010-08-05 22:28:15.000000000 +0900
+++
b/testcases/open_posix_testsuite/conformance/definitions/sched_h/8-3-buildon ly.c    2010-08-11 10:22:24.000000000 +0900

testcases/open_posix_testsuite/conformance/definitions/sched_h/8-3-buildonly.c +1 -1
@@ -18,7 +18,7 @@
 
  #if (defined(_POSIX_SPORADIC_SERVER) && _POSIX_SPORADIC_SERVER != -1) \
     || (defined(_POSIX_THREAD_SPORADIC_SERVER) && \
-       POSIX_THREAD_SPORADIC_SERVER != -1)
+       _POSIX_THREAD_SPORADIC_SERVER != -1)
 
  #ifndef SCHED_SPORADIC
  #error SCHED_SPORADIC not defined

============

Quoted 1 line

After applying above patch, "8-3-buildonly.c" succeeded to build.

Committed -- thanks!
-Garrett

------------------------------------------------------------------------------
This SF.net email is sponsored by

Make an app they can't live without
Enter the BlackBerry Developer Challenge
http://p.sf.net/sfu/RIM-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list