f2fs: avoid to left uninitialized data in page when read inline data
Subsystems (2)
PATCH 1/1 f2fs: avoid to left uninitialized data in page when read inline data
We left uninitialized data in the tail of page when we read an inline data page. So let's initialize left part of the page excluding inline data region.
Signed-off-by Chao Yu <[email protected]>
--- fs/f2fs/inline.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
fs/f2fs/inline.c +1 -2
@@ -48,8 +48,7 @@ int f2fs_read_inline_data(struct inode *inode, struct page *page)if (IS_ERR (ipage))return PTR_ERR (ipage); -zero_user_segment (page,INLINE_DATA_OFFSET , -INLINE_DATA_OFFSET +MAX_INLINE_DATA ); +zero_user_segment (page,MAX_INLINE_DATA ,PAGE_CACHE_SIZE );/* Copy the whole inline data block */ src_addr =inline_data_addr (ipage);
Signature · 9 lines
1.7.9.5 ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
Change log from v1:
o reduce unneeded memset in __f2fs_convert_inline_data
Quoted 1 line
From
58796be2bd2becbe8d52305210fb2a64e7dd80b6Mon Sep 17 00:00:00 2001
From: Chao Yu <[email protected]>
Date: Mon, 30 Dec 2013 09:21:33 +0800
Subject: [PATCH] f2fs: avoid to left uninitialized data in page when read
inline data
We left uninitialized data in the tail of page when we read an inline data page. So let's initialize left part of the page excluding inline data region.
Signed-off-by Chao Yu <[email protected]>
--- fs/f2fs/inline.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
fs/f2fs/inline.c +2 -3
@@ -48,8 +48,7 @@ int f2fs_read_inline_data(struct inode *inode, struct page *page)if (IS_ERR (ipage))return PTR_ERR (ipage); -zero_user_segment (page,INLINE_DATA_OFFSET , -INLINE_DATA_OFFSET +MAX_INLINE_DATA ); +zero_user_segment (page,MAX_INLINE_DATA ,PAGE_CACHE_SIZE );/* Copy the whole inline data block */ src_addr =inline_data_addr (ipage);
@@ -94,7 +93,7 @@ static int __f2fs_convert_inline_data(struct inode *inode, struct page *page)return err; } -zero_user_segment (page,0 ,PAGE_CACHE_SIZE ); +zero_user_segment (page,MAX_INLINE_DATA ,PAGE_CACHE_SIZE );/* Copy the whole inline data block */ src_addr =inline_data_addr (ipage);
Signature · 9 lines
1.7.9.5 ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk