exynos: arch: add support for exynos5260 SoC
Subsystems (5)
v2 cover exynos: arch: add support for exynos5260 SoC
This is re-spin of V2 which add arch-side support for exynos5260 SoC.
V2:
1) Split up DT patch into SoC and Board patch.
This series is based on Kukjin's for-next branch at
http://git.kernel.org/?p=linux/kernel/git/kgene/linux-samsung.git
Pankaj Dubey (1):
ARM: EXYNOS: initial board support for exynos5260 SoC
Rahul Sharma (2):
ARM: dts: add dts files for exynos5260 SoC
ARM: dts: add dts files for xyref5260 board
arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/exynos5260-pinctrl.dtsi | 572 +++++++++++++++++++++++ arch/arm/boot/dts/exynos5260-xyref5260-evt0.dts | 105 +++++ arch/arm/boot/dts/exynos5260.dtsi | 317 +++++++++++++ arch/arm/mach-exynos/Kconfig | 9 + arch/arm/mach-exynos/common.c | 18 + arch/arm/mach-exynos/include/mach/map.h | 1 + arch/arm/mach-exynos/mach-exynos5-dt.c | 1 + arch/arm/plat-samsung/include/plat/cpu.h | 8 + arch/arm/plat-samsung/include/plat/map-s5p.h | 1 + 10 files changed, 1033 insertions(+) create mode 100644 arch/arm/boot/dts/exynos5260-pinctrl.dtsi create mode 100644 arch/arm/boot/dts/exynos5260-xyref5260-evt0.dts create mode 100644 arch/arm/boot/dts/exynos5260.dtsi mode change 100644 => 100755 arch/arm/mach-exynos/include/mach/map.h mode change 100644 => 100755 arch/arm/mach-exynos/mach-exynos5-dt.c mode change 100644 => 100755 arch/arm/plat-samsung/include/plat/cpu.h
Signature · 1 line
1.7.9.5
PATCH v2 1/3 ARM: EXYNOS: initial board support for exynos5260 SoC
From: Pankaj Dubey <[email protected]>
This patch add basic arch side support for exynos5260 SoC.
--- arch/arm/mach-exynos/Kconfig | 9 +++++++++ arch/arm/mach-exynos/common.c | 18 ++++++++++++++++++ arch/arm/mach-exynos/include/mach/map.h | 1 + arch/arm/mach-exynos/mach-exynos5-dt.c | 1 + arch/arm/plat-samsung/include/plat/cpu.h | 8 ++++++++ arch/arm/plat-samsung/include/plat/map-s5p.h | 1 + 6 files changed, 38 insertions(+) mode change 100644 => 100755 arch/arm/mach-exynos/include/mach/map.h mode change 100644 => 100755 arch/arm/mach-exynos/mach-exynos5-dt.c mode change 100644 => 100755 arch/arm/plat-samsung/include/plat/cpu.h
arch/arm/mach-exynos/Kconfig +9 -0
@@ -91,6 +91,15 @@ config SOC_EXYNOS5250 help Enable EXYNOS5250 SoC support +config SOC_EXYNOS5260 + bool "SAMSUNG EXYNOS5260" + default y + depends on ARCH_EXYNOS5 + select AUTO_ZRELADDR + select SAMSUNG_DMADEV + help + Enable EXYNOS5260 SoC support + config SOC_EXYNOS5420 bool "SAMSUNG EXYNOS5420" default y
arch/arm/mach-exynos/common.c +18 -0
@@ -52,6 +52,7 @@ static const char name_exynos4210[] = "EXYNOS4210";static const char name_exynos4212[] ="EXYNOS4212" ;static const char name_exynos4412[] ="EXYNOS4412" ;static const char name_exynos5250[] ="EXYNOS5250" ; +static const char name_exynos5260[] ="EXYNOS5260" ;static const char name_exynos5420[] ="EXYNOS5420" ;static const char name_exynos5440[] ="EXYNOS5440" ;
@@ -85,6 +86,12 @@ static struct cpu_table cpu_ids[] __initdata = { .init = exynos_init, .name = name_exynos5250, }, { + .idcode = EXYNOS5260_SOC_ID, + .idmask = EXYNOS5_SOC_MASK, + .map_io = exynos5_map_io, + .init = exynos_init, + .name = name_exynos5260, + }, { .idcode = EXYNOS5420_SOC_ID, .idmask = EXYNOS5_SOC_MASK, .map_io = exynos5_map_io,
@@ -263,6 +270,15 @@ static struct map_desc exynos5_iodesc[] __initdata = { }, }; +static struct map_desc exynos5260_iodesc[]__initdata = { + { + .virtual = (unsigned long )S5P_VA_SYSRAM_NS , + .pfn =__phys_to_pfn (EXYNOS5260_PA_SYSRAM_NS ), + .length =SZ_4K , + .type =MT_DEVICE , + }, +}; +void exynos4_restart (enum reboot_mode mode,const char *cmd) {__raw_writel (0x1 ,S5P_SWRESET );
@@ -374,6 +390,8 @@ static void __init exynos5_map_io(void)if (soc_is_exynos5250 ())iotable_init (exynos5250_iodesc,ARRAY_SIZE (exynos5250_iodesc)); +if (soc_is_exynos5260 ()) +iotable_init (exynos5260_iodesc,ARRAY_SIZE (exynos5260_iodesc)); }struct bus_type exynos_subsys = {
arch/arm/mach-exynos/include/mach/map.h +1 -0
@@ -29,6 +29,7 @@#define EXYNOS4210_PA_SYSRAM_NS 0x0203F000#define EXYNOS4x12_PA_SYSRAM_NS 0x0204F000#define EXYNOS5250_PA_SYSRAM_NS 0x0204F000 +#define EXYNOS5260_PA_SYSRAM_NS 0x02073000#define EXYNOS_PA_CHIPID 0x10000000
arch/arm/mach-exynos/mach-exynos5-dt.c +1 -0
@@ -50,6 +50,7 @@ static void __init exynos5_dt_machine_init(void)static char const *exynos5_dt_compat[]__initdata = {"samsung,exynos5250" , +"samsung,exynos5260" ,"samsung,exynos5420" ,"samsung,exynos5440" ,NULL
arch/arm/plat-samsung/include/plat/cpu.h +8 -0
@@ -46,6 +46,7 @@ extern unsigned long samsung_cpu_id;#define EXYNOS4_CPU_MASK 0xFFFE0000#define EXYNOS5250_SOC_ID 0x43520000 +#define EXYNOS5260_SOC_ID 0xE5260000#define EXYNOS5420_SOC_ID 0xE5420000#define EXYNOS5440_SOC_ID 0xE5440000#define EXYNOS5_SOC_MASK 0xFFFFF000
@@ -68,6 +69,7 @@ IS_SAMSUNG_CPU(exynos4210, EXYNOS4210_CPU_ID, EXYNOS4_CPU_MASK) IS_SAMSUNG_CPU(exynos4212, EXYNOS4212_CPU_ID, EXYNOS4_CPU_MASK) IS_SAMSUNG_CPU(exynos4412, EXYNOS4412_CPU_ID, EXYNOS4_CPU_MASK) IS_SAMSUNG_CPU(exynos5250, EXYNOS5250_SOC_ID, EXYNOS5_SOC_MASK) +IS_SAMSUNG_CPU(exynos5260, EXYNOS5260_SOC_ID, EXYNOS5_SOC_MASK) IS_SAMSUNG_CPU(exynos5420, EXYNOS5420_SOC_ID, EXYNOS5_SOC_MASK)IS_SAMSUNG_CPU (exynos5440,EXYNOS5440_SOC_ID ,EXYNOS5_SOC_MASK )
@@ -148,6 +150,12 @@ IS_SAMSUNG_CPU(exynos5440, EXYNOS5440_SOC_ID, EXYNOS5_SOC_MASK)# define soc_is_exynos5250 () 0#endif +#if defined(CONFIG_SOC_EXYNOS5260 ) +# define soc_is_exynos5260 () is_samsung_exynos5260() +#else +# define soc_is_exynos5260 () 0 +#endif +#if defined(CONFIG_SOC_EXYNOS5420 )# define soc_is_exynos5420 () is_samsung_exynos5420()#else
arch/arm/plat-samsung/include/plat/map-s5p.h +1 -0
@@ -23,6 +23,7 @@#define S5P_VA_SYSRAM S3C_ADDR(0x02400000)#define S5P_VA_SYSRAM_NS S3C_ADDR(0x02410000) +#define S5P_VA_DMC0 S3C_ADDR(0x02440000)#define S5P_VA_DMC1 S3C_ADDR(0x02480000)#define S5P_VA_SROMC S3C_ADDR(0x024C0000)
Signature · 1 line
1.7.9.5
Re: [PATCH V2 1/3] ARM: EXYNOS: initial board support for exynos5260 SoC
Hi,
Quoted 25 lines · Rahul Sharma
From: Pankaj Dubey <[email protected]>
This patch add basic arch side support for exynos5260 SoC.
Signed-off-by Pankaj Dubey <[email protected]>Signed-off-by Arun Kumar K <[email protected]>Signed-off-by Rahul Sharma <[email protected]>--- arch/arm/mach-exynos/Kconfig | 9 +++++++++ arch/arm/mach-exynos/common.c | 18 ++++++++++++++++++ arch/arm/mach-exynos/include/mach/map.h | 1 + arch/arm/mach-exynos/mach-exynos5-dt.c | 1 + arch/arm/plat-samsung/include/plat/cpu.h | 8 ++++++++ arch/arm/plat-samsung/include/plat/map-s5p.h | 1 + 6 files changed, 38 insertions(+) mode change 100644 => 100755 arch/arm/mach-exynos/include/mach/map.h mode change 100644 => 100755 arch/arm/mach-exynos/mach-exynos5-dt.c mode change 100644 => 100755 arch/arm/plat-samsung/include/plat/cpu.harch/arm/mach-exynos/Kconfig +0
-0@@ -91,6 +91,15 @@ config SOC_EXYNOS5250 help
arch/arm/mach-exynos/Kconfig config SOC_EXYNOS5250 · line 101
Quoted 10 lines
arch/arm/mach-exynos/Kconfig +8
-0Enable EXYNOS5250 SoC support +config SOC_EXYNOS5260 + bool "SAMSUNG EXYNOS5260" + default y + depends on ARCH_EXYNOS5 + select AUTO_ZRELADDR + select SAMSUNG_DMADEV + help + Enable EXYNOS5260 SoC support
There's no point in having one of these for every SoC any more, so don't add new ones. The amount of code or data added by this is Kconfig is very small, we can just always include it with any EXYNOS5 build.
Quoted 19 lines
arch/arm/plat-samsung/include/plat/cpu.h +2
-0@@ -46,6 +46,7 @@ extern unsigned long samsung_cpu_id;#define EXYNOS4_CPU_MASK 0xFFFE0000#define EXYNOS5250_SOC_ID 0x43520000 +#define EXYNOS5260_SOC_ID 0xE5260000#define EXYNOS5420_SOC_ID 0xE5420000#define EXYNOS5440_SOC_ID 0xE5440000#define EXYNOS5_SOC_MASK 0xFFFFF000@@ -68,6 +69,7 @@ IS_SAMSUNG_CPU(exynos4210, EXYNOS4210_CPU_ID, EXYNOS4_CPU_MASK) IS_SAMSUNG_CPU(exynos4212, EXYNOS4212_CPU_ID, EXYNOS4_CPU_MASK) IS_SAMSUNG_CPU(exynos4412, EXYNOS4412_CPU_ID, EXYNOS4_CPU_MASK) IS_SAMSUNG_CPU(exynos5250, EXYNOS5250_SOC_ID, EXYNOS5_SOC_MASK) +IS_SAMSUNG_CPU(exynos5260, EXYNOS5260_SOC_ID, EXYNOS5_SOC_MASK) IS_SAMSUNG_CPU(exynos5420, EXYNOS5420_SOC_ID, EXYNOS5_SOC_MASK)IS_SAMSUNG_CPU (exynos5440,EXYNOS5440_SOC_ID ,EXYNOS5_SOC_MASK )
arch/arm/plat-samsung/include/plat/cpu.h IS_SAMSUNG_CPU(exynos5440, EXYNOS5440_SOC_ID, EXYNOS5_SOC_MASK) · line 157
Quoted 8 lines
arch/arm/plat-samsung/include/plat/cpu.h +5
-0@@ -148,6 +150,12 @@ IS_SAMSUNG_CPU(exynos5440, EXYNOS5440_SOC_ID, EXYNOS5_SOC_MASK)# define soc_is_exynos5250 () 0#endif +#if defined(CONFIG_SOC_EXYNOS5260 ) +# define soc_is_exynos5260 () is_samsung_exynos5260() +#else +# define soc_is_exynos5260 () 0 +#endif
This will likely conflict with cleanup patches going on right now which should do away with these header files (or at least move them).
arch/arm/plat-samsung/include/plat/map-s5p.h line 29
Quoted 12 lines
arch/arm/plat-samsung/include/plat/map-s5p.h +1
-0@@ -23,6 +23,7 @@#define S5P_VA_SYSRAM S3C_ADDR(0x02400000)#define S5P_VA_SYSRAM_NS S3C_ADDR(0x02410000) +#define S5P_VA_DMC0 S3C_ADDR(0x02440000)#define S5P_VA_DMC1 S3C_ADDR(0x02480000)#define S5P_VA_SROMC S3C_ADDR(0x024C0000)
Spurious change.
-Olof
PATCH v2 2/3 ARM: dts: add dts files for exynos5260 SoC
In reply to Rahul SharmaThe patch adds the dts files for exynos5260.
--- arch/arm/boot/dts/exynos5260-pinctrl.dtsi | 572 +++++++++++++++++++++++++++++ arch/arm/boot/dts/exynos5260.dtsi | 317 ++++++++++++++++ 2 files changed, 889 insertions(+) create mode 100644 arch/arm/boot/dts/exynos5260-pinctrl.dtsi create mode 100644 arch/arm/boot/dts/exynos5260.dtsi
arch/arm/boot/dts/exynos5260-pinctrl.dtsi new file +572 -0
@@ -0,0 +1,572 @@ +/* + * Samsung's Exynos5260 SoC pin-mux and pin-config device tree source + * + * Copyright (c) 2013 Samsung Electronics Co., Ltd. + * http://www.samsung.com + * + * Samsung's Exynos5260 SoC pin-mux and pin-config options are listed as device + * tree nodes are listed in this file. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. +*/ + +/ { + pinctrl@11600000 { + gpa0: gpa0 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpa1: gpa1 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpa2: gpa2 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpb0: gpb0 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpb1: gpb1 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpb2: gpb2 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpb3: gpb3 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpb4: gpb4 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpb5: gpb5 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpd0: gpd0 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpd1: gpd1 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpd2: gpd2 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpe0: gpe0 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpe1: gpe1 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpf0: gpf0 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpf1: gpf1 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpk0: gpk0 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpx0: gpx0 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpx1: gpx1 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpx2: gpx2 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpx3: gpx3 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + uart0_data: uart0-data { + samsung,pins = "gpa0-0", "gpa0-1"; + samsung,pin-function = <2>; + samsung,pin-pud = <0>; + samsung,pin-drv = <0>; + }; + + uart0_fctl: uart0-fctl { + samsung,pins = "gpa0-2", "gpa0-3"; + samsung,pin-function = <2>; + samsung,pin-pud = <0>; + samsung,pin-drv = <0>; + }; + + uart1_data: uart1-data { + samsung,pins = "gpa1-0", "gpa1-1"; + samsung,pin-function = <2>; + samsung,pin-pud = <0>; + samsung,pin-drv = <0>; + }; + + uart1_fctl: uart1-fctl { + samsung,pins = "gpa1-2", "gpa1-3"; + samsung,pin-function = <2>; + samsung,pin-pud = <0>; + samsung,pin-drv = <0>; + }; + + uart2_data: uart2-data { + samsung,pins = "gpa1-4", "gpa1-5"; + samsung,pin-function = <2>; + samsung,pin-pud = <0>; + samsung,pin-drv = <0>; + }; + + spi0_bus: spi0-bus { + samsung,pins = "gpa2-0", "gpa2-1", "gpa2-2", "gpa2-3"; + samsung,pin-function = <2>; + samsung,pin-pud = <3>; + samsung,pin-drv = <0>; + }; + + spi1_bus: spi1-bus { + samsung,pins = "gpa2-5", "gpa2-6", "gpa2-7"; + samsung,pin-function = <2>; + samsung,pin-pud = <3>; + samsung,pin-drv = <0>; + }; + + usb3_vbus0_en: usb3-vbus0-en { + samsung,pins = "gpa2-4"; + samsung,pin-function = <1>; + samsung,pin-pud = <0>; + samsung,pin-drv = <0>; + }; + + i2s1_bus: i2s1-bus { + samsung,pins = "gpb0-0", "gpb0-1", "gpb0-2", "gpb0-3", + "gpb0-4"; + samsung,pin-function = <2>; + samsung,pin-pud = <0>; + samsung,pin-drv = <0>; + }; + + pcm1_bus: pcm1-bus { + samsung,pins = "gpb0-0", "gpb0-1", "gpb0-2", "gpb0-3", + "gpb0-4"; + samsung,pin-function = <3>; + samsung,pin-pud = <0>; + samsung,pin-drv = <0>; + }; + + spdif1_bus: spdif1-bus { + samsung,pins = "gpb0-0", "gpb0-1", "gpb0-2"; + samsung,pin-function = <4>; + samsung,pin-pud = <0>; + samsung,pin-drv = <0>; + }; + + spi2_bus: spi2-bus { + samsung,pins = "gpb1-0", "gpb1-1", "gpb1-2", "gpb1-3"; + samsung,pin-function = <2>; + samsung,pin-pud = <3>; + samsung,pin-drv = <0>; + }; + + i2c0_hs_bus: i2c0-hs-bus { + samsung,pins = "gpb3-0", "gpb3-1"; + samsung,pin-function = <2>; + samsung,pin-pud = <3>; + samsung,pin-drv = <0>; + }; + + i2c1_hs_bus: i2c1-hs-bus { + samsung,pins = "gpb3-2", "gpb3-3"; + samsung,pin-function = <2>; + samsung,pin-pud = <3>; + samsung,pin-drv = <0>; + }; + + i2c2_hs_bus: i2c2-hs-bus { + samsung,pins = "gpb3-4", "gpb3-5"; + samsung,pin-function = <2>; + samsung,pin-pud = <3>; + samsung,pin-drv = <0>; + }; + + i2c3_hs_bus: i2c3-hs-bus { + samsung,pins = "gpb3-6", "gpb3-7"; + samsung,pin-function = <2>; + samsung,pin-pud = <3>; + samsung,pin-drv = <0>; + }; + + i2c4_bus: i2c4-bus { + samsung,pins = "gpb4-0", "gpb4-1"; + samsung,pin-function = <2>; + samsung,pin-pud = <3>; + samsung,pin-drv = <0>; + }; + + i2c5_bus: i2c5-bus { + samsung,pins = "gpb4-2", "gpb4-3"; + samsung,pin-function = <2>; + samsung,pin-pud = <3>; + samsung,pin-drv = <0>; + }; + + i2c6_bus: i2c6-bus { + samsung,pins = "gpb4-4", "gpb4-5"; + samsung,pin-function = <2>; + samsung,pin-pud = <3>; + samsung,pin-drv = <0>; + }; + + i2c7_bus: i2c7-bus { + samsung,pins = "gpb4-6", "gpb4-7"; + samsung,pin-function = <2>; + samsung,pin-pud = <3>; + samsung,pin-drv = <0>; + }; + + i2c8_bus: i2c8-bus { + samsung,pins = "gpb5-0", "gpb5-1"; + samsung,pin-function = <2>; + samsung,pin-pud = <3>; + samsung,pin-drv = <0>; + }; + + i2c9_bus: i2c9-bus { + samsung,pins = "gpb5-2", "gpb5-3"; + samsung,pin-function = <2>; + samsung,pin-pud = <3>; + samsung,pin-drv = <0>; + }; + + i2c10_bus: i2c10-bus { + samsung,pins = "gpb5-4", "gpb5-5"; + samsung,pin-function = <2>; + samsung,pin-pud = <3>; + samsung,pin-drv = <0>; + }; + + i2c11_bus: i2c11-bus { + samsung,pins = "gpb5-6", "gpb5-7"; + samsung,pin-function = <2>; + samsung,pin-pud = <3>; + samsung,pin-drv = <0>; + }; + + cam_gpio_a: cam-gpio-a { + samsung,pins = "gpe0-0", "gpe0-1", "gpe0-2", "gpe0-3", + "gpe0-4", "gpe0-5", "gpe0-6", "gpe0-7", + "gpe1-0", "gpe1-1"; + samsung,pin-function = <2>; + samsung,pin-pud = <0>; + samsung,pin-drv = <0>; + }; + + cam_gpio_b: cam-gpio-b { + samsung,pins = "gpf0-0", "gpf0-1", "gpf0-2", "gpf0-3", + "gpf1-0", "gpf1-1", "gpf1-2", "gpf1-3"; + samsung,pin-function = <3>; + samsung,pin-pud = <0>; + samsung,pin-drv = <0>; + }; + + cam_i2c1_bus: cam-i2c1-bus { + samsung,pins = "gpf0-2", "gpf0-3"; + samsung,pin-function = <2>; + samsung,pin-pud = <3>; + samsung,pin-drv = <0>; + }; + + cam_i2c0_bus: cam-i2c0-bus { + samsung,pins = "gpf0-0", "gpf0-1"; + samsung,pin-function = <2>; + samsung,pin-pud = <3>; + samsung,pin-drv = <0>; + }; + + cam_spi0_bus: cam-spi0-bus { + samsung,pins = "gpf1-0", "gpf1-1", "gpf1-2", "gpf1-3"; + samsung,pin-function = <2>; + samsung,pin-pud = <0>; + samsung,pin-drv = <0>; + }; + + cam_spi1_bus: cam-spi1-bus { + samsung,pins = "gpf1-4", "gpf1-5", "gpf1-6", "gpf1-7"; + samsung,pin-function = <2>; + samsung,pin-pud = <0>; + samsung,pin-drv = <0>; + }; + }; + + pinctrl@12290000 { + gpc0: gpc0 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpc1: gpc1 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpc2: gpc2 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpc3: gpc3 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpc4: gpc4 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + sd0_clk: sd0-clk { + samsung,pins = "gpc0-0"; + samsung,pin-function = <2>; + samsung,pin-pud = <0>; + samsung,pin-drv = <3>; + }; + + sd0_cmd: sd0-cmd { + samsung,pins = "gpc0-1"; + samsung,pin-function = <2>; + samsung,pin-pud = <0>; + samsung,pin-drv = <3>; + }; + + sd0_bus1: sd0-bus-width1 { + samsung,pins = "gpc0-2"; + samsung,pin-function = <2>; + samsung,pin-pud = <3>; + samsung,pin-drv = <3>; + }; + + sd0_bus4: sd0-bus-width4 { + samsung,pins = "gpc0-3", "gpc0-4", "gpc0-5"; + samsung,pin-function = <2>; + samsung,pin-pud = <3>; + samsung,pin-drv = <3>; + }; + + sd0_bus8: sd0-bus-width8 { + samsung,pins = "gpc3-0", "gpc3-1", "gpc3-2", "gpc3-3"; + samsung,pin-function = <2>; + samsung,pin-pud = <3>; + samsung,pin-drv = <3>; + }; + + sd0_rdqs: sd0-rdqs { + samsung,pins = "gpc0-6"; + samsung,pin-function = <2>; + samsung,pin-pud = <3>; + samsung,pin-drv = <3>; + }; + + sd1_clk: sd1-clk { + samsung,pins = "gpc1-0"; + samsung,pin-function = <2>; + samsung,pin-pud = <0>; + samsung,pin-drv = <3>; + }; + + sd1_cmd: sd1-cmd { + samsung,pins = "gpc1-1"; + samsung,pin-function = <2>; + samsung,pin-pud = <0>; + samsung,pin-drv = <3>; + }; + + sd1_bus1: sd1-bus-width1 { + samsung,pins = "gpc1-2"; + samsung,pin-function = <2>; + samsung,pin-pud = <3>; + samsung,pin-drv = <3>; + }; + + sd1_bus4: sd1-bus-width4 { + samsung,pins = "gpc1-3", "gpc1-4", "gpc1-5"; + samsung,pin-function = <2>; + samsung,pin-pud = <3>; + samsung,pin-drv = <3>; + }; + + sd1_bus8: sd1-bus-width8 { + samsung,pins = "gpc4-0", "gpc4-1", "gpc4-2", "gpc4-3"; + samsung,pin-function = <2>; + samsung,pin-pud = <3>; + samsung,pin-drv = <3>; + }; + + sd2_clk: sd2-clk { + samsung,pins = "gpc2-0"; + samsung,pin-function = <2>; + samsung,pin-pud = <0>; + samsung,pin-drv = <3>; + }; + + sd2_cmd: sd2-cmd { + samsung,pins = "gpc2-1"; + samsung,pin-function = <2>; + samsung,pin-pud = <0>; + samsung,pin-drv = <3>; + }; + + sd2_cd: sd2-cd { + samsung,pins = "gpc2-2"; + samsung,pin-function = <2>; + samsung,pin-pud = <3>; + samsung,pin-drv = <3>; + }; + + sd2_bus1: sd2-bus-width1 { + samsung,pins = "gpc2-3"; + samsung,pin-function = <2>; + samsung,pin-pud = <3>; + samsung,pin-drv = <3>; + }; + + sd2_bus4: sd2-bus-width4 { + samsung,pins = "gpc2-4", "gpc2-5", "gpc2-6"; + samsung,pin-function = <2>; + samsung,pin-pud = <3>; + samsung,pin-drv = <3>; + }; + }; + + pinctrl@128B0000 { + gpz0: gpz0 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpz1: gpz1 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + }; +};
arch/arm/boot/dts/exynos5260.dtsi new file +317 -0
317 lines not on this page · raw message
Signature · 1 line
1.7.9.5
PATCH v2 2/3 ARM: dts: add dts files for exynos5260 SoC
Hi Rahul, Pankaj, Arun,
[adding linux-arm-kernel, devicetree MLs and DT people on Cc]
I think it's good time to stop accepting DTS files like this and force new ones to use the proper structure with soc node, labels for every node and node references.
In case of previous Exynos 5 SoCs I hadn't complained, because they shared a lot of data with already existing exynos5.dtsi, but since Exynos5260 is completely different, I'd say it should be converted to the new layout.
As an example you can look at arch/arm/boot/dts/s3c64xx.dtsi and files that include it or, for more complete structures, DTS of other platforms, such as imx6*.
Btw. Please remember that linux-samsung-soc mailing list is just a convenient utility for reviewers of Samsung-specific patches to have all of them in one place. Sending patches to it alone is not enough - a general kernel ML list needs to be CCed as well, in this case linux-arm-kernel.
Also, please see my comments inline, for review comments unrelated to the issue described above.
Quoted 34 lines · Rahul Sharma
The patch adds the dts files for exynos5260.
Signed-off-by Pankaj Dubey <[email protected]>Signed-off-by Rahul Sharma <[email protected]>Signed-off-by Arun Kumar K <[email protected]>--- arch/arm/boot/dts/exynos5260-pinctrl.dtsi | 572 +++++++++++++++++++++++++++++ arch/arm/boot/dts/exynos5260.dtsi | 317 ++++++++++++++++ 2 files changed, 889 insertions(+)create mode 100644
arch/arm/boot/dts/exynos5260-pinctrl.dtsicreate mode 100644arch/arm/boot/dts/exynos5260.dtsiarch/arm/boot/dts/exynos5260-pinctrl.dtsi new file +16
-0@@ -0,0 +1,572 @@ +/* + * Samsung's Exynos5260 SoC pin-mux and pin-config device tree source + * + * Copyright (c) 2013 Samsung Electronics Co., Ltd. + * http://www.samsung.com + * + * Samsung's Exynos5260 SoC pin-mux and pin-config options are listed as device + * tree nodes are listed in this file. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. +*/ + +/ { + pinctrl at 11600000 {
[snip]
arch/arm/boot/dts/exynos5260-pinctrl.dtsi line 221
Quoted 2 lines
arch/arm/boot/dts/exynos5260-pinctrl.dtsi new file +2
-0+ spi0_bus: spi0-bus { + samsung,pins = "gpa2-0", "gpa2-1", "gpa2-2", "gpa2-3";
What is the reason for SPI0 to have 4 pins, while SPI1 has just 3?
Quoted 4 lines
arch/arm/boot/dts/exynos5260-pinctrl.dtsi new file +4
-0+ samsung,pin-function = <2>; + samsung,pin-pud = <3>; + samsung,pin-drv = <0>; + };
[snip]
Quoted 35 lines
arch/arm/boot/dts/exynos5260.dtsi new file +29
-0@@ -0,0 +1,317 @@ +/* + * SAMSUNG EXYNOS5260 SoC device tree source + * + * Copyright (c) 2013 Samsung Electronics Co., Ltd. + * http://www.samsung.com + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. +*/ + +#include "skeleton.dtsi" +#include "exynos5260-pinctrl.dtsi" + +#include <dt-bindings/clk/exynos5260-clk.h> + +/ { + compatible = "samsung,exynos5260"; + interrupt-parent = <&gic>; + + aliases { + pinctrl0 = &pinctrl_0; + pinctrl1 = &pinctrl_1; + pinctrl2 = &pinctrl_2; + }; + + chipid at 10000000 { + compatible = "samsung,exynos4210-chipid"; + reg = <0x10000000 0x100>;
arch/arm/boot/dts/exynos5260.dtsi line 39
Quoted 10 lines
arch/arm/boot/dts/exynos5260.dtsi new file +10
-0+ }; + + cpus { + #address-cells = <1>; + #size-cells = <0>; + + cpu at 0 { + device_type = "cpu"; + compatible = "arm,cortex-a15"; + reg = <0>;
nit: Please make this consistent with CPUs 10x below, by using hex here as well.
arch/arm/boot/dts/exynos5260.dtsi line 41
Quoted 2 lines
arch/arm/boot/dts/exynos5260.dtsi new file +2
-0+ cci-control-port = <&cci_control1>; + };
nit: Please keep 1 blank line of spacing between nodes.
Quoted 27 lines
arch/arm/boot/dts/exynos5260.dtsi new file +27
-0+ cpu at 1 { + device_type = "cpu"; + compatible = "arm,cortex-a15"; + reg = <1>; + cci-control-port = <&cci_control1>; + }; + cpu at 100 { + device_type = "cpu"; + compatible = "arm,cortex-a7"; + reg = <0x100>; + cci-control-port = <&cci_control0>; + }; + cpu at 101 { + device_type = "cpu"; + compatible = "arm,cortex-a7"; + reg = <0x101>; + cci-control-port = <&cci_control0>; + }; + cpu at 102 { + device_type = "cpu"; + compatible = "arm,cortex-a7"; + reg = <0x102>; + cci-control-port = <&cci_control0>; + }; + cpu at 103 { + device_type = "cpu"; + compatible = "arm,cortex-a7";
arch/arm/boot/dts/exynos5260.dtsi line 78
Quoted 10 lines
arch/arm/boot/dts/exynos5260.dtsi new file +10
-0+ reg = <0x103>; + cci-control-port = <&cci_control0>; + }; + }; + + cmus { + #address-cells = <1>; + #size-cells = <1>; + ranges; +
I don't think there is a need to group these nodes under a parent node that doesn't give any additional information, especially when the CMUs are scattered trough the whole address space, while we'd like to keep the nodes ordered by their addresses, as most platforms do.
arch/arm/boot/dts/exynos5260.dtsi line 80
Quoted 2 lines
arch/arm/boot/dts/exynos5260.dtsi new file +2
-0+ cmu_top: clock-controller at 10010000 { + compatible = "exynos5260-cmu-top", "samsung,exynos5260-clock";
I don't think that having the "samsung,exynos5260-clock" compatible string for every CMU is appropriate here, because there is no way to automatically recognize which CMU it is. Since every CMU instance is different, they need to have different compatible strings.
Quoted 3 lines
arch/arm/boot/dts/exynos5260.dtsi new file +3
-0+ reg = <0x10010000 0x10000>; + #clock-cells = <1>; + };
[snip]
arch/arm/boot/dts/exynos5260.dtsi line 175
Quoted 5 lines
arch/arm/boot/dts/exynos5260.dtsi new file +5
-0+ mct at 100B0000 { + compatible = "samsung,exynos4210-mct"; + reg = <0x100B0000 0x1000>; + interrupt-controller; + #interrups-cells = <1>;
MCT is not an interrupt controller, so the 2 properties above are incorrect.
Quoted 14 lines
arch/arm/boot/dts/exynos5260.dtsi new file +14
-0+ interrupt-parent = <&mct_map>; + interrupts = <0>, <1>, <2>, <3>, + <4>, <5>, <6>, <7>, + <8>, <9>, <10>, <11>; + clocks = <&cmu_top FIN_PLL>, <&cmu_peri PERI_CLK_MCT>; + clock-names = "fin_pll", "mct"; + + mct_map: mct-map { + #interrupt-cells = <1>; + #address-cells = <0>; + #size-cells = <0>; + interrupt-map = <0 &gic 0 104 0>, + <1 &gic 0 105 0>, + <2 &gic 0 106 0>,
arch/arm/boot/dts/exynos5260.dtsi line 199
Quoted 10 lines
arch/arm/boot/dts/exynos5260.dtsi new file +10
-0+ <3 &gic 0 107 0>, + <4 &gic 0 122 0>, + <5 &gic 0 123 0>, + <6 &gic 0 124 0>, + <7 &gic 0 125 0>, + <8 &gic 0 126 0>, + <9 &gic 0 127 0>, + <10 &gic 0 128 0>, + <11 &gic 0 129 0>; + };
There is no need for interrupt-map here, because all the interrupts are from GIC.
Quoted 1 line
arch/arm/boot/dts/exynos5260.dtsi new file +1
-0+ };
[snip]
arch/arm/boot/dts/exynos5260.dtsi line 290
Quoted 9 lines
arch/arm/boot/dts/exynos5260.dtsi new file +9
-0+ mmc_0: mmc0 at 12140000 { + compatible = "samsung,exynos5250-dw-mshc"; + reg = <0x12140000 0x2000>; + interrupts = <0 156 0>; + #address-cells = <1>; + #size-cells = <0>; + clocks = <&cmu_fsys FSYS_CLK_MMC0>, <&cmu_top TOP_SCLK_MMC0>; + clock-names = "biu", "ciu"; + fifo-depth = <0x40>;
nit: It might be more readable to use decimal 64 here.
Best regards,
Tomasz
PATCH v2 2/3 ARM: dts: add dts files for exynos5260 SoC
Hi Tomasz,
Quoted 7 lines · Tomasz Figa
Hi Rahul, Pankaj, Arun,
[adding linux-arm-kernel, devicetree MLs and DT people on Cc]
I think it's good time to stop accepting DTS files like this and force new ones to use the proper structure with soc node, labels for every node and node references.
I am unable to find information on SoC node and grouping inside SoC node. Please share some pointers.
Quoted 5 lines
In case of previous Exynos 5 SoCs I hadn't complained, because they shared a lot of data with already existing
exynos5.dtsi, but since Exynos5260 is completely different, I'd say it should be converted to the new layout.
Quoted 9 lines
As an example you can look at
arch/arm/boot/dts/s3c64xx.dtsiand files that include it or, for more complete structures, DTS of other platforms, such as imx6*.Btw. Please remember that linux-samsung-soc mailing list is just a convenient utility for reviewers of Samsung-specific patches to have all of them in one place. Sending patches to it alone is not enough - a general kernel ML list needs to be CCed as well, in this case linux-arm-kernel.
I will take care of this.
Quoted 48 lines
Also, please see my comments inline, for review comments unrelated to the issue described above.
Quoted 38 lines · Rahul Sharma
The patch adds the dts files for exynos5260.
Signed-off-by Pankaj Dubey <[email protected]>Signed-off-by Rahul Sharma <[email protected]>Signed-off-by Arun Kumar K <[email protected]>--- arch/arm/boot/dts/exynos5260-pinctrl.dtsi | 572 +++++++++++++++++++++++++++++ arch/arm/boot/dts/exynos5260.dtsi | 317 ++++++++++++++++ 2 files changed, 889 insertions(+)create mode 100644
arch/arm/boot/dts/exynos5260-pinctrl.dtsicreate mode 100644arch/arm/boot/dts/exynos5260.dtsiarch/arm/boot/dts/exynos5260-pinctrl.dtsi new file +7
-0@@ -0,0 +1,572 @@ +/* + * Samsung's Exynos5260 SoC pin-mux and pin-config device tree source + * + * Copyright (c) 2013 Samsung Electronics Co., Ltd. + * http://www.samsung.com + * + * Samsung's Exynos5260 SoC pin-mux and pin-config options are listed asdevice
+ * tree nodes are listed in this file.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.arch/arm/boot/dts/exynos5260-pinctrl.dtsi new file +4
-0+*/ + +/ { + pinctrl at 11600000 {[snip]
Quoted 7 lines
Quoted 3 lines
arch/arm/boot/dts/exynos5260-pinctrl.dtsi new file +2
-0+ spi0_bus: spi0-bus { + samsung,pins = "gpa2-0", "gpa2-1", "gpa2-2","gpa2-3";
What is the reason for SPI0 to have 4 pins, while SPI1 has just 3?
I should align SPI1 with SPI0.
Quoted 52 lines
Quoted 5 lines
arch/arm/boot/dts/exynos5260-pinctrl.dtsi new file +4
-0+ samsung,pin-function = <2>; + samsung,pin-pud = <3>; + samsung,pin-drv = <0>; + };[snip]
Quoted 42 lines
arch/arm/boot/dts/exynos5260.dtsi new file +35
-0@@ -0,0 +1,317 @@ +/* + * SAMSUNG EXYNOS5260 SoC device tree source + * + * Copyright (c) 2013 Samsung Electronics Co., Ltd. + * http://www.samsung.com + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. +*/ + +#include "skeleton.dtsi" +#include "exynos5260-pinctrl.dtsi" + +#include <dt-bindings/clk/exynos5260-clk.h> + +/ { + compatible = "samsung,exynos5260"; + interrupt-parent = <&gic>; + + aliases { + pinctrl0 = &pinctrl_0; + pinctrl1 = &pinctrl_1; + pinctrl2 = &pinctrl_2; + }; + + chipid at 10000000 { + compatible = "samsung,exynos4210-chipid"; + reg = <0x10000000 0x100>; + }; + + cpus { + #address-cells = <1>; + #size-cells = <0>; +
Quoted 9 lines
arch/arm/boot/dts/exynos5260.dtsi line 39
Quoted 4 lines
arch/arm/boot/dts/exynos5260.dtsi new file +4
-0+ cpu at 0 { + device_type = "cpu"; + compatible = "arm,cortex-a15"; + reg = <0>;nit: Please make this consistent with CPUs 10x below, by using hex here as well.
Done.
Quoted 7 lines
arch/arm/boot/dts/exynos5260.dtsi line 41
Quoted 3 lines
arch/arm/boot/dts/exynos5260.dtsi new file +2
-0+ cci-control-port = <&cci_control1>; + };nit: Please keep 1 blank line of spacing between nodes.
ok.
Quoted 36 lines
Quoted 36 lines
arch/arm/boot/dts/exynos5260.dtsi new file +35
-0+ cpu at 1 { + device_type = "cpu"; + compatible = "arm,cortex-a15"; + reg = <1>; + cci-control-port = <&cci_control1>; + }; + cpu at 100 { + device_type = "cpu"; + compatible = "arm,cortex-a7"; + reg = <0x100>; + cci-control-port = <&cci_control0>; + }; + cpu at 101 { + device_type = "cpu"; + compatible = "arm,cortex-a7"; + reg = <0x101>; + cci-control-port = <&cci_control0>; + }; + cpu at 102 { + device_type = "cpu"; + compatible = "arm,cortex-a7"; + reg = <0x102>; + cci-control-port = <&cci_control0>; + }; + cpu at 103 { + device_type = "cpu"; + compatible = "arm,cortex-a7"; + reg = <0x103>; + cci-control-port = <&cci_control0>; + }; + }; + + cmus { + #address-cells = <1>; + #size-cells = <1>;
Quoted 9 lines
arch/arm/boot/dts/exynos5260.dtsi line 78
Quoted 2 lines
arch/arm/boot/dts/exynos5260.dtsi new file +2
-0+ ranges; +I don't think there is a need to group these nodes under a parent node that doesn't give any additional information, especially when the CMUs are scattered trough the whole address space, while we'd like to keep the nodes ordered by their addresses, as most platforms do.
This is exactly the same case as "cpus". I mean, "cpus" also doesn't provide any common information about child cpu nodes. This looks to me as a logical grouping and I have implemented same thing for cmu nodes.
I am ok with removing this grouping Just want to understand the rational behind grouping cpus which seems similar to cmus.
Similarly "soc" is just a logical entity used to group SoC elements which looks optional to me. What are we achieving with this? Please help me in understanding this better.
Quoted 11 lines
Quoted 4 lines
arch/arm/boot/dts/exynos5260.dtsi new file +2
-0+ cmu_top: clock-controller at 10010000 { + compatible = "exynos5260-cmu-top","samsung,exynos5260-clock";
I don't think that having the "samsung,exynos5260-clock" compatible string for every CMU is appropriate here, because there is no way to automatically recognize which CMU it is. Since every CMU instance is different, they need to have different compatible strings.
Changed.
Quoted 9 lines
Quoted 4 lines
arch/arm/boot/dts/exynos5260.dtsi new file +3
-0+ reg = <0x10010000 0x10000>; + #clock-cells = <1>; + };[snip]
Quoted 9 lines
arch/arm/boot/dts/exynos5260.dtsi line 175
Quoted 5 lines
arch/arm/boot/dts/exynos5260.dtsi new file +5
-0+ mct at 100B0000 { + compatible = "samsung,exynos4210-mct"; + reg = <0x100B0000 0x1000>; + interrupt-controller; + #interrups-cells = <1>;MCT is not an interrupt controller, so the 2 properties above are incorrect.
Agree. I will change this.
Quoted 27 lines
Quoted 15 lines
arch/arm/boot/dts/exynos5260.dtsi new file +14
-0+ interrupt-parent = <&mct_map>; + interrupts = <0>, <1>, <2>, <3>, + <4>, <5>, <6>, <7>, + <8>, <9>, <10>, <11>; + clocks = <&cmu_top FIN_PLL>, <&cmu_peri PERI_CLK_MCT>; + clock-names = "fin_pll", "mct"; + + mct_map: mct-map { + #interrupt-cells = <1>; + #address-cells = <0>; + #size-cells = <0>; + interrupt-map = <0 &gic 0 104 0>, + <1 &gic 0 105 0>, + <2 &gic 0 106 0>,arch/arm/boot/dts/exynos5260.dtsi line 199
Quoted 10 lines
arch/arm/boot/dts/exynos5260.dtsi new file +10
-0+ <3 &gic 0 107 0>, + <4 &gic 0 122 0>, + <5 &gic 0 123 0>, + <6 &gic 0 124 0>, + <7 &gic 0 125 0>, + <8 &gic 0 126 0>, + <9 &gic 0 127 0>, + <10 &gic 0 128 0>, + <11 &gic 0 129 0>; + };
Quoted 3 lines
There is no need for interrupt-map here, because all the interrupts are from GIC.
Done.
Regards,
Rahul Sharma.
Quoted 22 lines
Quoted 1 line
+ };
[snip]
arch/arm/boot/dts/exynos5260.dtsi
Quoted 10 lines
arch/arm/boot/dts/exynos5260.dtsi new file +7
-0+ mmc_0: mmc0 at 12140000 { + compatible = "samsung,exynos5250-dw-mshc"; + reg = <0x12140000 0x2000>; + interrupts = <0 156 0>; + #address-cells = <1>; + #size-cells = <0>; + clocks = <&cmu_fsys FSYS_CLK_MMC0>, <&cmu_top
TOP_SCLK_MMC0>;arch/arm/boot/dts/exynos5260.dtsi new file +2
-0+ clock-names = "biu", "ciu"; + fifo-depth = <0x40>;nit: It might be more readable to use decimal 64 here.
Best regards,
Tomasz
PATCH v2 2/3 ARM: dts: add dts files for exynos5260 SoC
Hi Rahul,
Quoted 5 lines · Rahul Sharma
Hi Tomasz,
Quoted 2 lines · Tomasz Figa
Hi Rahul, Pankaj, Arun,
Quoted 8 lines
Quoted 5 lines
[adding linux-arm-kernel, devicetree MLs and DT people on Cc]
I think it's good time to stop accepting DTS files like this and force new ones to use the proper structure with soc node, labels for every node and node references.
I am unable to find information on SoC node and grouping inside SoC node. Please share some pointers.
Well, there is not much information needed about this. Basically all the devices built into the SoC should be listed under respective bus nodes or a single soc node, instead of root level. Such node should be a "simple-bus" and just group the components together to separate board-specific devices (which are still at root level) from SoC devices.
Even though it might seem useless, it improves DT readability a bit and still most of the platforms use this approach, so for consistency, Exynos should use too.
Just for reference, back in April 2013, in his review of S3C64xx DT series [1], Rob Herring requested that we don't submit any new device trees using flat approach and start using bus hierarchy.
[1]
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-April/163659.html
Quoted 11 lines
Quoted 8 lines
Quoted 4 lines
(quoted diff) +2
-0+ spi0_bus: spi0-bus { + samsung,pins = "gpa2-0", "gpa2-1", "gpa2-2","gpa2-3";
What is the reason for SPI0 to have 4 pins, while SPI1 has just 3?
I should align SPI1 with SPI0.
Are you sure that SPI0 is the correct one? SPI usually uses four pins - SDI, SDO, SCK and nCS, but we always used to treat nCS as a simple GPIO, due to the fact that the controller can only support one dedicated chip select and with direct GPIO control you can have more.
What is the fourth pin here?
Quoted 46 lines
Quoted 36 lines
Quoted 36 lines
arch/arm/boot/dts/exynos5260.dtsi new file +35
-0+ cpu at 1 { + device_type = "cpu"; + compatible = "arm,cortex-a15"; + reg = <1>; + cci-control-port = <&cci_control1>; + }; + cpu at 100 { + device_type = "cpu"; + compatible = "arm,cortex-a7"; + reg = <0x100>; + cci-control-port = <&cci_control0>; + }; + cpu at 101 { + device_type = "cpu"; + compatible = "arm,cortex-a7"; + reg = <0x101>; + cci-control-port = <&cci_control0>; + }; + cpu at 102 { + device_type = "cpu"; + compatible = "arm,cortex-a7"; + reg = <0x102>; + cci-control-port = <&cci_control0>; + }; + cpu at 103 { + device_type = "cpu"; + compatible = "arm,cortex-a7"; + reg = <0x103>; + cci-control-port = <&cci_control0>; + }; + }; + + cmus { + #address-cells = <1>; + #size-cells = <1>;Quoted 9 lines
arch/arm/boot/dts/exynos5260.dtsi line 78
Quoted 2 lines
arch/arm/boot/dts/exynos5260.dtsi new file +2
-0+ ranges; +I don't think there is a need to group these nodes under a parent node that doesn't give any additional information, especially when the CMUs are scattered trough the whole address space, while we'd like to keep the nodes ordered by their addresses, as most platforms do.
Quoted 5 lines
This is exactly the same case as "cpus". I mean, "cpus" also doesn't provide any common information about child cpu nodes. This looks to me as a logical grouping and I have implemented same thing for cmu nodes.
I am ok with removing this grouping Just want to understand the rational behind grouping cpus which seems similar to cmus.
The "cpus" node is a defined standard node that should be present at root of device tree and include subnodes for all CPUs. This is a standard binding defined for low level code to be able to simply find nodes of all CPUs in the system - so they can expect that at /cpus node all the subnodes are subsequent CPUs.
Quoted 3 lines
Similarly "soc" is just a logical entity used to group SoC elements which looks optional to me. What are we achieving with this? Please help me in understanding this better.
Also "soc" has a slightly wider meaning. It is a node grouping all nodes from a single address space - the node specifies #address-cells and #size-cells of this address space and all the devices under this "simple-bus" can be accessed using addresses in this format. In addition, it separates board-level devices from generic SoC devices.
Now, in case of "cmus", the only purpose is to group all CMU nodes together and, while this improves readability a bit, it doesn't make the DT better express the hardware topology, because the CMUs in the hardware are in fact scattered through the whole address space, not under a contiguous block of it, as the grouping would suggest.
Best regards,
Tomasz
PATCH v2 2/3 ARM: dts: add dts files for exynos5260 SoC
Thanks Tomasz,
I will add these changes to v3.
Regards,
Rahul Sharma.
Quoted 150 lines · Tomasz Figa
Hi Rahul,
Quoted 15 lines · Rahul Sharma
Hi Tomasz,
Quoted 9 lines · Tomasz Figa
Hi Rahul, Pankaj, Arun,
[adding linux-arm-kernel, devicetree MLs and DT people on Cc]
I think it's good time to stop accepting DTS files like this and force new
ones to use the proper structure with soc node, labels for every node and node references.Quoted 3 lines
I am unable to find information on SoC node and grouping inside SoC node. Please
share some pointers.Well, there is not much information needed about this. Basically all the devices built into the SoC should be listed under respective bus nodes or a single soc node, instead of root level. Such node should be a "simple-bus" and just group the components together to separate board-specific devices (which are still at root level) from SoC devices.
Even though it might seem useless, it improves DT readability a bit and still most of the platforms use this approach, so for consistency, Exynos should use too.
Just for reference, back in April 2013, in his review of S3C64xx DT series [1], Rob Herring requested that we don't submit any new device trees using flat approach and start using bus hierarchy.
[1]
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-April/163659.htmlQuoted 7 lines
Quoted 7 lines
Quoted 4 lines
(quoted diff) +2
-0+ spi0_bus: spi0-bus { + samsung,pins = "gpa2-0", "gpa2-1", "gpa2-2","gpa2-3";
Quoted 5 lines
Quoted 2 lines
What is the reason for SPI0 to have 4 pins, while SPI1 has just 3?
I should align SPI1 with SPI0.
Are you sure that SPI0 is the correct one? SPI usually uses four pins - SDI, SDO, SCK and nCS, but we always used to treat nCS as a simple GPIO, due to the fact that the controller can only support one dedicated chip select and with direct GPIO control you can have more.
What is the fourth pin here?
Quoted 49 lines
Quoted 41 lines
Quoted 28 lines
arch/arm/boot/dts/exynos5260.dtsi new file +27
-0+ cpu at 1 { + device_type = "cpu"; + compatible = "arm,cortex-a15"; + reg = <1>; + cci-control-port = <&cci_control1>; + }; + cpu at 100 { + device_type = "cpu"; + compatible = "arm,cortex-a7"; + reg = <0x100>; + cci-control-port = <&cci_control0>; + }; + cpu at 101 { + device_type = "cpu"; + compatible = "arm,cortex-a7"; + reg = <0x101>; + cci-control-port = <&cci_control0>; + }; + cpu at 102 { + device_type = "cpu"; + compatible = "arm,cortex-a7"; + reg = <0x102>; + cci-control-port = <&cci_control0>; + }; + cpu at 103 { + device_type = "cpu"; + compatible = "arm,cortex-a7";arch/arm/boot/dts/exynos5260.dtsi line 78
Quoted 10 lines
arch/arm/boot/dts/exynos5260.dtsi new file +10
-0+ reg = <0x103>; + cci-control-port = <&cci_control0>; + }; + }; + + cmus { + #address-cells = <1>; + #size-cells = <1>; + ranges; +Quoted 7 lines
I don't think there is a need to group these nodes under a parent node that
doesn't give any additional information, especially when the CMUs are scattered trough the whole address space, while we'd like to keep the nodes
ordered by their addresses, as most platforms do.Quoted 8 lines
This is exactly the same case as "cpus". I mean, "cpus" also doesn't provide
any common information about child cpu nodes. This looks to me as a logical
grouping and I have implemented same thing for cmu nodes.
I am ok with removing this grouping Just want to understand the rational behind
grouping cpus which seems similar to cmus.The "cpus" node is a defined standard node that should be present at root of device tree and include subnodes for all CPUs. This is a standard binding defined for low level code to be able to simply find nodes of all CPUs in the system - so they can expect that at /cpus node all the subnodes are subsequent CPUs.
Quoted 5 lines
Similarly "soc" is just a logical entity used to group SoC elements which looks
optional to me. What are we achieving with this? Please help me in understanding
this better.Also "soc" has a slightly wider meaning. It is a node grouping all nodes from a single address space - the node specifies #address-cells and #size-cells of this address space and all the devices under this "simple-bus" can be accessed using addresses in this format. In addition, it separates board-level devices from generic SoC devices.
Now, in case of "cmus", the only purpose is to group all CMU nodes together and, while this improves readability a bit, it doesn't make the DT better express the hardware topology, because the CMUs in the hardware are in fact scattered through the whole address space, not under a contiguous block of it, as the grouping would suggest.
Best regards,
Tomasz
PATCH v2 2/3 ARM: dts: add dts files for exynos5260 SoC
Quoted 70 lines · Rahul Sharma
Thanks Tomasz,
I will add these changes to v3.
Regards,
Rahul Sharma.Quoted 62 lines · Tomasz Figa
Hi Rahul,
Quoted 15 lines · Rahul Sharma
Hi Tomasz,
Quoted 9 lines · Tomasz Figa
Hi Rahul, Pankaj, Arun,
[adding linux-arm-kernel, devicetree MLs and DT people on Cc]
I think it's good time to stop accepting DTS files like this and force new
ones to use the proper structure with soc node, labels for every node and node references.Quoted 3 lines
I am unable to find information on SoC node and grouping inside SoC node. Please
share some pointers.Well, there is not much information needed about this. Basically all the devices built into the SoC should be listed under respective bus nodes or a single soc node, instead of root level. Such node should be a "simple-bus" and just group the components together to separate board-specific devices (which are still at root level) from SoC devices.
Even though it might seem useless, it improves DT readability a bit and still most of the platforms use this approach, so for consistency, Exynos should use too.
Just for reference, back in April 2013, in his review of S3C64xx DT series [1], Rob Herring requested that we don't submit any new device trees using flat approach and start using bus hierarchy.
[1]
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-April/163659.htmlQuoted 7 lines
Quoted 7 lines
Quoted 4 lines
(quoted diff) +2
-0+ spi0_bus: spi0-bus { + samsung,pins = "gpa2-0", "gpa2-1", "gpa2-2","gpa2-3";
Quoted 5 lines
Quoted 2 lines
What is the reason for SPI0 to have 4 pins, while SPI1 has just 3?
I should align SPI1 with SPI0.
Are you sure that SPI0 is the correct one? SPI usually uses four pins - SDI, SDO, SCK and nCS, but we always used to treat nCS as a simple GPIO, due to the fact that the controller can only support one dedicated chip select and with direct GPIO control you can have more.
What is the fourth pin here?
As you said, these are CLK, SS, MISO, MOSI (gpa2-0 to gpa2-3). Fourth pin is CS. It can be defined as a simple GPIO but better to include it in the SPI pingroup
as it belongs to there.
Regards,
Rahul Sharma.
Quoted 88 lines
Quoted 88 lines
Quoted 50 lines
Quoted 42 lines
Quoted 29 lines
arch/arm/boot/dts/exynos5260.dtsi new file +27
-0+ cpu at 1 { + device_type = "cpu"; + compatible = "arm,cortex-a15"; + reg = <1>; + cci-control-port = <&cci_control1>; + }; + cpu at 100 { + device_type = "cpu"; + compatible = "arm,cortex-a7"; + reg = <0x100>; + cci-control-port = <&cci_control0>; + }; + cpu at 101 { + device_type = "cpu"; + compatible = "arm,cortex-a7"; + reg = <0x101>; + cci-control-port = <&cci_control0>; + }; + cpu at 102 { + device_type = "cpu"; + compatible = "arm,cortex-a7"; + reg = <0x102>; + cci-control-port = <&cci_control0>; + }; + cpu at 103 { + device_type = "cpu"; + compatible = "arm,cortex-a7";arch/arm/boot/dts/exynos5260.dtsi line 78
Quoted 10 lines
arch/arm/boot/dts/exynos5260.dtsi new file +10
-0+ reg = <0x103>; + cci-control-port = <&cci_control0>; + }; + }; + + cmus { + #address-cells = <1>; + #size-cells = <1>; + ranges; +Quoted 7 lines
I don't think there is a need to group these nodes under a parent node that
doesn't give any additional information, especially when the CMUs are scattered trough the whole address space, while we'd like to keep the nodes
ordered by their addresses, as most platforms do.Quoted 8 lines
This is exactly the same case as "cpus". I mean, "cpus" also doesn't provide
any common information about child cpu nodes. This looks to me as a logical
grouping and I have implemented same thing for cmu nodes.
I am ok with removing this grouping Just want to understand the rational behind
grouping cpus which seems similar to cmus.The "cpus" node is a defined standard node that should be present at root of device tree and include subnodes for all CPUs. This is a standard binding defined for low level code to be able to simply find nodes of all CPUs in the system - so they can expect that at /cpus node all the subnodes are subsequent CPUs.
Quoted 5 lines
Similarly "soc" is just a logical entity used to group SoC elements which looks
optional to me. What are we achieving with this? Please help me in understanding
this better.Also "soc" has a slightly wider meaning. It is a node grouping all nodes from a single address space - the node specifies #address-cells and #size-cells of this address space and all the devices under this "simple-bus" can be accessed using addresses in this format. In addition, it separates board-level devices from generic SoC devices.
Now, in case of "cmus", the only purpose is to group all CMU nodes together and, while this improves readability a bit, it doesn't make the DT better express the hardware topology, because the CMUs in the hardware are in fact scattered through the whole address space, not under a contiguous block of it, as the grouping would suggest.
Best regards,
Tomasz
PATCH v2 2/3 ARM: dts: add dts files for exynos5260 SoC
Quoted 69 lines · Rahul Sharma
Quoted 68 lines · Rahul Sharma
Thanks Tomasz,
I will add these changes to v3.
Regards,
Rahul Sharma.Quoted 60 lines · Tomasz Figa
Hi Rahul,
Quoted 15 lines · Rahul Sharma
Hi Tomasz,
Quoted 9 lines · Tomasz Figa
Hi Rahul, Pankaj, Arun,
[adding linux-arm-kernel, devicetree MLs and DT people on Cc]
I think it's good time to stop accepting DTS files like this and force new
ones to use the proper structure with soc node, labels for every node and node references.Quoted 3 lines
I am unable to find information on SoC node and grouping inside SoC node. Please
share some pointers.Well, there is not much information needed about this. Basically all the devices built into the SoC should be listed under respective bus nodes or a single soc node, instead of root level. Such node should be a "simple-bus" and just group the components together to separate board-specific devices (which are still at root level) from SoC devices.
Even though it might seem useless, it improves DT readability a bit and still most of the platforms use this approach, so for consistency, Exynos should use too.
Just for reference, back in April 2013, in his review of S3C64xx DT series [1], Rob Herring requested that we don't submit any new device trees using flat approach and start using bus hierarchy.
[1]
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-April/163659.htmlQuoted 7 lines
Quoted 7 lines
Quoted 4 lines
(quoted diff) +2
-0+ spi0_bus: spi0-bus { + samsung,pins = "gpa2-0", "gpa2-1", "gpa2-2","gpa2-3";
Quoted 5 lines
Quoted 2 lines
What is the reason for SPI0 to have 4 pins, while SPI1 has just 3?
I should align SPI1 with SPI0.
Are you sure that SPI0 is the correct one? SPI usually uses four pins - SDI, SDO, SCK and nCS, but we always used to treat nCS as a simple GPIO, due to the fact that the controller can only support one dedicated chip select and with direct GPIO control you can have more.
Quoted 7 lines
Quoted 2 lines
Quoted 2 lines
What is the fourth pin here?
As you said, these are CLK, SS, MISO, MOSI (gpa2-0 to gpa2-3). Fourth pin is CS. It can be defined as a simple GPIO but better to include it in the SPI pingroup
as it belongs to there.
I have to disagree here.
If you define a pin in pinctrl group then it is tied to this specific hardware function and you can't use it as GPIO.
Since it's board specific to use it as HW chip select or GPIO chip select (the usual setup), it should not be included in this group.
Best regards,
Tomasz
PATCH v2 3/3 ARM: dts: add dts files for xyref5260 board
In reply to Rahul SharmaThe patch adds the dts files for xyref5260 board which is based on Exynos5260 Evt0 sample.
--- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/exynos5260-xyref5260-evt0.dts | 105 +++++++++++++++++++++++ 2 files changed, 106 insertions(+) create mode 100644 arch/arm/boot/dts/exynos5260-xyref5260-evt0.dts
arch/arm/boot/dts/Makefile +1 -0
@@ -64,6 +64,7 @@ dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-origen.dtb \ exynos5250-arndale.dtb \ exynos5250-smdk5250.dtb \ exynos5250-snow.dtb \ + exynos5260-xyref5260-evt0.dtb \ exynos5420-arndale-octa.dtb \ exynos5420-smdk5420.dtb \ exynos5440-sd5v1.dtb \
arch/arm/boot/dts/exynos5260-xyref5260-evt0.dts new file +105 -0
105 lines not on this page · raw message
Signature · 1 line
1.7.9.5
Quoted 25 lines · Rahul Sharma
This is re-spin of V2 which add arch-side support for exynos5260 SoC.
V2:
1) Split up DT patch into SoC and Board patch.This series is based on Kukjin's for-next branch at
http://git.kernel.org/?p=linux/kernel/git/kgene/linux-samsung.gitPankaj Dubey (1):
ARM: EXYNOS: initial board support for exynos5260 SoCRahul Sharma (2):
ARM: dts: add dts files for exynos5260 SoC
ARM: dts: add dts files for xyref5260 boardarch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/exynos5260-pinctrl.dtsi | 572 +++++++++++++++++++++++ arch/arm/boot/dts/exynos5260-xyref5260-evt0.dts | 105 +++++ arch/arm/boot/dts/exynos5260.dtsi | 317 +++++++++++++ arch/arm/mach-exynos/Kconfig | 9 + arch/arm/mach-exynos/common.c | 18 + arch/arm/mach-exynos/include/mach/map.h | 1 + arch/arm/mach-exynos/mach-exynos5-dt.c | 1 + arch/arm/plat-samsung/include/plat/cpu.h | 8 +
Quoted 8 lines
arch/arm/plat-samsung/include/plat/map-s5p.h | 1 + 10 files changed, 1033 insertions(+) create mode 100644 arch/arm/boot/dts/exynos5260-pinctrl.dtsi create mode 100644 arch/arm/boot/dts/exynos5260-xyref5260-evt0.dts create mode 100644 arch/arm/boot/dts/exynos5260.dtsi mode change 100644 => 100755 arch/arm/mach-exynos/include/mach/map.h mode change 100644 => 100755 arch/arm/mach-exynos/mach-exynos5-dt.c mode change 100644 => 100755 arch/arm/plat-samsung/include/plat/cpu.h
The mode of these three files should NOT be changed to 100755. Please fix it.
Best regards,
Jingoo Han
Oops. Thanks Jingoo Han.
Quoted 41 lines · Jingoo Han
Quoted 25 lines · Rahul Sharma
This is re-spin of V2 which add arch-side support for exynos5260 SoC.
V2:
1) Split up DT patch into SoC and Board patch.This series is based on Kukjin's for-next branch at
http://git.kernel.org/?p=linux/kernel/git/kgene/linux-samsung.gitPankaj Dubey (1):
ARM: EXYNOS: initial board support for exynos5260 SoCRahul Sharma (2):
ARM: dts: add dts files for exynos5260 SoC
ARM: dts: add dts files for xyref5260 boardarch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/exynos5260-pinctrl.dtsi | 572 +++++++++++++++++++++++ arch/arm/boot/dts/exynos5260-xyref5260-evt0.dts | 105 +++++ arch/arm/boot/dts/exynos5260.dtsi | 317 +++++++++++++ arch/arm/mach-exynos/Kconfig | 9 + arch/arm/mach-exynos/common.c | 18 + arch/arm/mach-exynos/include/mach/map.h | 1 + arch/arm/mach-exynos/mach-exynos5-dt.c | 1 + arch/arm/plat-samsung/include/plat/cpu.h | 8 +Quoted 8 lines
arch/arm/plat-samsung/include/plat/map-s5p.h | 1 + 10 files changed, 1033 insertions(+) create mode 100644 arch/arm/boot/dts/exynos5260-pinctrl.dtsi create mode 100644 arch/arm/boot/dts/exynos5260-xyref5260-evt0.dts create mode 100644 arch/arm/boot/dts/exynos5260.dtsi mode change 100644 => 100755 arch/arm/mach-exynos/include/mach/map.h mode change 100644 => 100755 arch/arm/mach-exynos/mach-exynos5-dt.c mode change 100644 => 100755 arch/arm/plat-samsung/include/plat/cpu.hThe mode of these three files should NOT be changed to 100755. Please fix it.
Best regards,
Jingoo Han