ath10k: Add chain-1 voltage regulator voting
Subsystems (3)
cover ath10k: Add chain-1 voltage regulator voting
Add the support to vote for the chain-1
voltage regulator for WCN3990. This is
added as an optional property.
Rakesh Pillai (2):
dt: bindings: Add new regulator as optional property for WCN3990
ath10k: Add support for chain1 regulator supply voting
Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 4 +++- drivers/net/wireless/ath/ath10k/snoc.c | 1 + 2 files changed, 4 insertions(+), 1 deletion(-)
Signature · 7 lines
2.7.4 _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
PATCH 1/2 dt: bindings: Add new regulator as optional property for WCN3990
Add an additional regulator supply as an optional
property for WCN3990.
Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1
--- Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt +3 -1
@@ -65,7 +65,8 @@ Optional properties: the length can vary between hw versions. - <supply-name>-supply: handle to the regulator device tree node optional "supply-name" are "vdd-0.8-cx-mx", - "vdd-1.8-xo", "vdd-1.3-rfa" and "vdd-3.3-ch0". + "vdd-1.8-xo", "vdd-1.3-rfa", "vdd-3.3-ch0" + and "vdd-3.3-ch1". - memory-region: Usage: optional Value type: <phandle>
@@ -204,6 +205,7 @@ wifi@18000000 { vdd-1.8-xo-supply = <&vreg_l7a_1p8>; vdd-1.3-rfa-supply = <&vreg_l17a_1p3>; vdd-3.3-ch0-supply = <&vreg_l25a_3p3>; + vdd-3.3-ch1-supply = <&vreg_l26a_3p3>; memory-region = <&wifi_msa_mem>; iommus = <&apps_smmu 0x0040 0x1>; qcom,msa-fixed-perm;
Signature · 7 lines
2.7.4 _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
Re: [PATCH 1/2] dt: bindings: Add new regulator as optional property for WCN3990
Hi,
Quoted 10 lines · Rakesh Pillai
Add an additional regulator supply as an optional
property for WCN3990.Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1
Signed-off-by Rakesh Pillai <[email protected]>--- Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Overall though: aren't you missing a whole lot of CCs? Have you tried using get_maintainer?
Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt Optional properties: · line 69
Quoted 11 lines
Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt +2
-1@@ -65,7 +65,8 @@ Optional properties: the length can vary between hw versions. - <supply-name>-supply: handle to the regulator device tree node optional "supply-name" are "vdd-0.8-cx-mx", - "vdd-1.8-xo", "vdd-1.3-rfa" and "vdd-3.3-ch0". + "vdd-1.8-xo", "vdd-1.3-rfa", "vdd-3.3-ch0" + and "vdd-3.3-ch1".
nit that could probably be fixed by maintainer when applying: missing comma at the end of "vdd-3.3-ch0"
I will also note that this file is in dire need of being converted to yaml. Pretty soon I think people are going to start disallowing changes to the bindings that haven't been converted to yaml so you probably want to get a jump start on it so future patches aren't stalled.
In any case:
_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
Re: [PATCH 1/2] dt: bindings: Add new regulator as optional property for WCN3990
In reply to Rakesh PillaiQuoted 10 lines · Rakesh Pillai
Add an additional regulator supply as an optional
property for WCN3990.Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1
Signed-off-by Rakesh Pillai <[email protected]>--- Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
Re: [PATCH 1/2] dt: bindings: Add new regulator as optional property for WCN3990
In reply to Rakesh PillaiQuoted 9 lines · Rakesh Pillai
Add an additional regulator supply as an optional property for WCN3990.
Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1
Signed-off-by Rakesh Pillai <[email protected]>Reviewed-by Douglas Anderson <[email protected]>Acked-by Rob Herring <[email protected]>Signed-off-by Kalle Valo <[email protected]>
2 patches applied to ath-next branch of ath.git, thanks.
8f1553694551 dt: bindings: Add new regulator as optional property for WCN3990 9e69fe31ca9a ath10k: Add support for chain1 regulator supply voting
Signature · 9 lines
https://patchwork.kernel.org/patch/11628309/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
Re: [PATCH 1/2] dt: bindings: Add new regulator as optional property for WCN3990
In reply to Rakesh PillaiQuoted 9 lines · Rakesh Pillai
Add an additional regulator supply as an optional property for WCN3990.
Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1
Signed-off-by Rakesh Pillai <[email protected]>Reviewed-by Douglas Anderson <[email protected]>Acked-by Rob Herring <[email protected]>Signed-off-by Kalle Valo <[email protected]>
2 patches applied to ath-next branch of ath.git, thanks.
8f1553694551 dt: bindings: Add new regulator as optional property for WCN3990 9e69fe31ca9a ath10k: Add support for chain1 regulator supply voting
Signature · 3 lines
https://patchwork.kernel.org/patch/11628309/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
PATCH 2/2 ath10k: Add support for chain1 regulator supply voting
In reply to Rakesh PillaiAdd support to vote for chain-1 voltage regulator
in WCN3990.
Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1
--- drivers/net/wireless/ath/ath10k/snoc.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/wireless/ath/ath10k/snoc.c +1 -0
@@ -45,6 +45,7 @@ static const char * const ath10k_regulators[] = {"vdd-1.8-xo" ,"vdd-1.3-rfa" ,"vdd-3.3-ch0" , + "vdd-3.3-ch1", }; static const char * const ath10k_clocks[] = {
Signature · 7 lines
2.7.4 _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
Re: [PATCH 2/2] ath10k: Add support for chain1 regulator supply voting
Hi,
Quoted 16 lines · Rakesh Pillai
Add support to vote for chain-1 voltage regulator
in WCN3990.Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1
Signed-off-by Rakesh Pillai <[email protected]>--- drivers/net/wireless/ath/ath10k/snoc.c | 1 + 1 file changed, 1 insertion(+)drivers/net/wireless/ath/ath10k/snoc.c +0
-0
drivers/net/wireless/ath/ath10k/snoc.c static const char * const ath10k_regulators[] = { · line 48
Quoted 4 lines
drivers/net/wireless/ath/ath10k/snoc.c +1
-0@@ -45,6 +45,7 @@ static const char * const ath10k_regulators[] = {"vdd-1.8-xo" ,"vdd-1.3-rfa" ,"vdd-3.3-ch0" , + "vdd-3.3-ch1",
...with the slight nit that ${SUBJECT} and description should probably call it "chan1" and not "chain1". Presumably the maintainer can fix when applying.
-Doug
_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
RE: [PATCH 2/2] ath10k: Add support for chain1 regulator supply voting
Quoted 40 lines
-----Original Message-----
From: Doug Anderson <[email protected]>
Sent: Saturday, June 27, 2020 3:22 AM
To: Rakesh Pillai <[email protected]>; Kalle Valo <[email protected]>
Cc: [email protected]; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS <[email protected]>; linux-wireless <linux- [email protected]>; LKML <[email protected]>
Subject: Re: [PATCH 2/2] ath10k: Add support for chain1 regulator supply votingHi,
Quoted 4 lines · Rakesh Pillai
Add support to vote for chain-1 voltage regulator
in WCN3990.Review
Quoted 8 lines
Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1
Signed-off-by Rakesh Pillai <[email protected]>--- drivers/net/wireless/ath/ath10k/snoc.c | 1 + 1 file changed, 1 insertion(+)(quoted diff) +0
-0
b/drivers/net/wireless/ath/ath10k/snoc.cdrivers/net/wireless/ath/ath10k/snoc.c static const char * const ath10k_regulators[] = { · line 48
Quoted 8 lines
index 645ed5f..407a074 100644
drivers/net/wireless/ath/ath10k/snoc.c +1
-0@@ -45,6 +45,7 @@ static const char * const ath10k_regulators[] = {"vdd-1.8-xo" ,"vdd-1.3-rfa" ,"vdd-3.3-ch0" , + "vdd-3.3-ch1",Reviewed-by Douglas Anderson <[email protected]>
Quoted 5 lines
...with the slight nit that ${SUBJECT} and description should probably call it "chan1" and not "chain1". Presumably the maintainer can fix when applying.
-Doug
Hi Doug,
It has to be chain1 only, not chan1.
This is the power supply rail for the wlan-chain1
_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
Re: [PATCH 2/2] ath10k: Add support for chain1 regulator supply voting
Hi,
Quoted 45 lines · Rakesh Pillai
Quoted 45 lines
-----Original Message-----
From: Doug Anderson <[email protected]>
Sent: Saturday, June 27, 2020 3:22 AM
To: Rakesh Pillai <[email protected]>; Kalle Valo <[email protected]>
Cc: [email protected]; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS <[email protected]>; linux-wireless <linux- [email protected]>; LKML <[email protected]>
Subject: Re: [PATCH 2/2] ath10k: Add support for chain1 regulator supply votingHi,
Quoted 4 lines · Rakesh Pillai
Add support to vote for chain-1 voltage regulator
in WCN3990.Review
Quoted 8 lines
Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1
Signed-off-by Rakesh Pillai <[email protected]>--- drivers/net/wireless/ath/ath10k/snoc.c | 1 + 1 file changed, 1 insertion(+)(quoted diff) +0
-0
b/drivers/net/wireless/ath/ath10k/snoc.cdrivers/net/wireless/ath/ath10k/snoc.c static const char * const ath10k_regulators[] = { · line 48
Quoted 8 lines
index 645ed5f..407a074 100644
drivers/net/wireless/ath/ath10k/snoc.c +1
-0@@ -45,6 +45,7 @@ static const char * const ath10k_regulators[] = {"vdd-1.8-xo" ,"vdd-1.3-rfa" ,"vdd-3.3-ch0" , + "vdd-3.3-ch1",Reviewed-by Douglas Anderson <[email protected]>...with the slight nit that ${SUBJECT} and description should probably call it "chan1" and not "chain1". Presumably the maintainer can fix when applying.
Quoted 6 lines
Quoted 1 line
-Doug
Hi Doug,
It has to be chain1 only, not chan1.
This is the power supply rail for the wlan-chain1
Whoa, really? "ch1" stands for "chain1", not "chan1"? That is seriously weird (at least to me), but I find at least one document that agrees with you. Sorry for the mistake!
-Doug
_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
Hi,
Quoted 5 lines · Rakesh Pillai
Add the support to vote for the chain-1
voltage regulator for WCN3990. This is
added as an optional property.
Quoted 7 lines
Rakesh Pillai (2):
dt: bindings: Add new regulator as optional property for WCN3990
ath10k: Add support for chain1 regulator supply votingDocumentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 4 +++- drivers/net/wireless/ath/ath10k/snoc.c | 1 + 2 files changed, 4 insertions(+), 1 deletion(-)
This series is marked as "Awaiting Upstream" in patchwork. I don't see anything blocking it landing now.
-Doug
_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
Quoted 12 lines · Doug Anderson
Hi,
Quoted 9 lines · Rakesh Pillai
Add the support to vote for the chain-1
voltage regulator for WCN3990. This is
added as an optional property.Rakesh Pillai (2):
dt: bindings: Add new regulator as optional property for WCN3990
ath10k: Add support for chain1 regulator supply voting
Quoted 6 lines
Quoted 3 lines
Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 4 +++- drivers/net/wireless/ath/ath10k/snoc.c | 1 + 2 files changed, 4 insertions(+), 1 deletion(-)This series is marked as "Awaiting Upstream" in patchwork. I don't see anything blocking it landing now.
Thanks, moved it to New state now.
Signature · 6 lines
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
Quoted 12 lines · Doug Anderson
Hi,
Quoted 9 lines · Rakesh Pillai
Add the support to vote for the chain-1
voltage regulator for WCN3990. This is
added as an optional property.Rakesh Pillai (2):
dt: bindings: Add new regulator as optional property for WCN3990
ath10k: Add support for chain1 regulator supply voting
Quoted 6 lines
Quoted 3 lines
Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 4 +++- drivers/net/wireless/ath/ath10k/snoc.c | 1 + 2 files changed, 4 insertions(+), 1 deletion(-)This series is marked as "Awaiting Upstream" in patchwork. I don't see anything blocking it landing now.
Thanks, moved it to New state now.
Signature · 1 line
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches