Skip to contentSkip to conversation

v4l: vb2-memops: use vma slab when vma allocation

PATCH In review Cho KyongHo 2 participants 3 messages Feb 5, 2015 – Apr 9, 2015 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 v4l: vb2-memops: use vma slab when vma allocation

The slab for vm_area_struct which is vm_area_cachep is already prepared for the general use. Instead of kmalloc() for the vma copy for userptr, allocation from vm_area_cachep is more beneficial.

CC Mauro Carvalho Chehab <[email protected]>
CC Hans Verkuil <[email protected]>
CC Laurent Pinchart <[email protected]>
---
 drivers/media/v4l2-core/videobuf2-memops.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/media/v4l2-core/videobuf2-memops.c +2 -2
index 81c1ad8..dd06efa 100644
@@ -37,7 +37,7 @@ struct vm_area_struct *vb2_get_vma(struct vm_area_struct *vma)
 {
 	struct vm_area_struct *vma_copy;
 
-	vma_copy = kmalloc(sizeof(*vma_copy), GFP_KERNEL);
+	vma_copy = kmem_cache_alloc(vm_area_cachep, GFP_KERNEL);
 	if (vma_copy == NULL)
 		return NULL;
 
@@ -75,7 +75,7 @@ void vb2_put_vma(struct vm_area_struct *vma)
 	if (vma->vm_file)
 		fput(vma->vm_file);
 
-	kfree(vma);
+	kmem_cache_free(vm_area_cachep, vma);
 }
 EXPORT_SYMBOL_GPL(vb2_put_vma);
 
Signature · 1 line
1.7.9.5
#1 lore raw

Mauro,

Please revert this patch: vm_area_cachep is not exported, so you cannot use this in a module.

Cho KyongHo, if you believe that vm_area_cachep should be exported so it can be used here, then please make a patch for that.

For the time being though, this patch should be reverted.

This patch slipped through the cracks and I clearly never reviewed it, and I only noticed the problem after I compiled the media_tree git repo after this patch was merged.

Regards,

Hans

Quoted 35 lines · Cho KyongHo

The slab for vm_area_struct which is vm_area_cachep is already prepared for the general use. Instead of kmalloc() for the vma copy for userptr, allocation from vm_area_cachep is more beneficial.

CC Mauro Carvalho Chehab <[email protected]>
CC Hans Verkuil <[email protected]>
CC Laurent Pinchart <[email protected]>
---
 drivers/media/v4l2-core/videobuf2-memops.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/media/v4l2-core/videobuf2-memops.c +2 -2
index 81c1ad8..dd06efa 100644
@@ -37,7 +37,7 @@ struct vm_area_struct *vb2_get_vma(struct vm_area_struct *vma)
 {
 	struct vm_area_struct *vma_copy;
 
-	vma_copy = kmalloc(sizeof(*vma_copy), GFP_KERNEL);
+	vma_copy = kmem_cache_alloc(vm_area_cachep, GFP_KERNEL);
 	if (vma_copy == NULL)
 		return NULL;
 
@@ -75,7 +75,7 @@ void vb2_put_vma(struct vm_area_struct *vma)
 	if (vma->vm_file)
 		fput(vma->vm_file);
 
-	kfree(vma);
+	kmem_cache_free(vm_area_cachep, vma);
 }
 EXPORT_SYMBOL_GPL(vb2_put_vma);
 
#2 lore raw

Hans,
I didn't notice that vb2_put_vma is exported because I don't build modules. I am sorry about bothering you.

Mauro,
I think it is better to drop my patch out from your tree because I don't think it is not worth to export vm_area_cache_p to use it in vb2_put_vma.

Regards,

KyongHo

-----Original Message-----
From: Hans Verkuil [mailto:[email protected]]
Sent: Thursday, April 09, 2015 1:01 AM

Mauro,

Please revert this patch: vm_area_cachep is not exported, so you cannot use this in a module.

Cho KyongHo, if you believe that vm_area_cachep should be exported so it can be used here, then please make a patch for that.

For the time being though, this patch should be reverted.

This patch slipped through the cracks and I clearly never reviewed it, and I only noticed the problem after I compiled the media_tree git repo after this patch was merged.

Regards,

Hans

Quoted 36 lines · Cho KyongHo

The slab for vm_area_struct which is vm_area_cachep is already prepared for the general use. Instead of kmalloc() for the vma copy for userptr, allocation from vm_area_cachep is more beneficial.

CC Mauro Carvalho Chehab <[email protected]>
CC Hans Verkuil <[email protected]>
CC Laurent Pinchart <[email protected]>
---
 drivers/media/v4l2-core/videobuf2-memops.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/media/v4l2-core/videobuf2-memops.c +2 -2
index 81c1ad8..dd06efa 100644
@@ -37,7 +37,7 @@ struct vm_area_struct *vb2_get_vma(struct 
 vm_area_struct *vma)  {
 	struct vm_area_struct *vma_copy;
 
-	vma_copy = kmalloc(sizeof(*vma_copy), GFP_KERNEL);
+	vma_copy = kmem_cache_alloc(vm_area_cachep, GFP_KERNEL);
 	if (vma_copy == NULL)
 		return NULL;
 
@@ -75,7 +75,7 @@ void vb2_put_vma(struct vm_area_struct *vma)
 	if (vma->vm_file)
 		fput(vma->vm_file);
 
-	kfree(vma);
+	kmem_cache_free(vm_area_cachep, vma);
 }
 EXPORT_SYMBOL_GPL(vb2_put_vma);