Skip to contentSkip to conversation

ARM: EXYNOS5: Add I2S SFR base addresse

PATCH New Padmavathi Venna 4 participants 4 messages Nov 6, 2012 – Nov 24, 2012

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm Samsung Exynos
lore
Share & tools
lore

Padmavathi Venna

author
#0 lore raw

PATCH v3 1/1 ARM: EXYNOS5: Add I2S SFR base addresse

This patch adds I2S controller0,1,2 base addresses

Signed-off-by Padmavathi Venna <[email protected]>

---

Changes since V2:
- Rebased on 3.7-rc3

Changes since V1:
- Rebased on 3.6-rc6
- Reverted Exynos4 I2S1,2 address changes that are added in V1 as Exynos4 based boards have different I2S base addresses.

 arch/arm/mach-exynos/include/mach/map.h |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
arch/arm/mach-exynos/include/mach/map.h +3 -0
index ef4958b..4192d23 100644
@@ -42,6 +42,9 @@
 #define EXYNOS4_PA_I2S0			0x03830000
 #define EXYNOS4_PA_I2S1			0xE3100000
 #define EXYNOS4_PA_I2S2			0xE2A00000
+#define EXYNOS5_PA_I2S0			0x03830000
+#define EXYNOS5_PA_I2S1			0x12D60000
+#define EXYNOS5_PA_I2S2			0x12D70000
 
 #define EXYNOS4_PA_PCM0			0x03840000
 #define EXYNOS4_PA_PCM1			0x13980000
Signature · 1 line
1.7.4.4
#2 lore raw

PATCH v3 1/1 ARM: EXYNOS5: Add I2S SFR base addresse

In reply to Padmavathi Venna

cc'ing Mark Brown

Quoted 37 lines · Padmavathi Venna

This patch adds I2S controller0,1,2 base addresses

Signed-off-by Padmavathi Venna <[email protected]>

---

Changes since V2:
- Rebased on 3.7-rc3

Changes since V1:
- Rebased on 3.6-rc6
- Reverted Exynos4 I2S1,2 address changes that are added in V1 as Exynos4 based boards have different I2S base addresses.

 arch/arm/mach-exynos/include/mach/map.h |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
arch/arm/mach-exynos/include/mach/map.h +3 -1
index ef4958b..4192d23 100644
@@ -42,6 +42,9 @@
 #define EXYNOS4_PA_I2S0                        0x03830000
 #define EXYNOS4_PA_I2S1                        0xE3100000
 #define EXYNOS4_PA_I2S2                        0xE2A00000
+#define EXYNOS5_PA_I2S0                        0x03830000
+#define EXYNOS5_PA_I2S1                        0x12D60000
+#define EXYNOS5_PA_I2S2                        0x12D70000
 
 #define EXYNOS4_PA_PCM0                        0x03840000
 #define EXYNOS4_PA_PCM1                        0x13980000
--

1.7.4.4

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw

PATCH v3 1/1 ARM: EXYNOS5: Add I2S SFR base addresse

In reply to Padmavathi Venna
Quoted 33 lines · Padmavathi Venna

This patch adds I2S controller0,1,2 base addresses

Signed-off-by Padmavathi Venna <[email protected]>

---

Changes since V2:
- Rebased on 3.7-rc3

Changes since V1:
- Rebased on 3.6-rc6
- Reverted Exynos4 I2S1,2 address changes that are added in V1 as Exynos4 based boards have different I2S base addresses.

 arch/arm/mach-exynos/include/mach/map.h |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
arch/arm/mach- renamed from arch/arm/mach-exynos/include/mach/map.h +0 -0

exynos/include/mach/map.h
index ef4958b..4192d23 100644

arch/arm/mach-exynos/include/mach/map.h +3 -1
@@ -42,6 +42,9 @@
 #define EXYNOS4_PA_I2S0			0x03830000
 #define EXYNOS4_PA_I2S1			0xE3100000
 #define EXYNOS4_PA_I2S2			0xE2A00000
+#define EXYNOS5_PA_I2S0			0x03830000
+#define EXYNOS5_PA_I2S1			0x12D60000
+#define EXYNOS5_PA_I2S2			0x12D70000
 
 #define EXYNOS4_PA_PCM0			0x03840000
 #define EXYNOS4_PA_PCM1			0x13980000
--
Quoted 1 line

1.7.4.4

I have 2 comments on this.

1. If above definitions are required, this patch can be squashed into the patch which they are used ([PATCH V3 2/2] ARM: EXYNOS: Enable platform support for I2S controllers) or this should be tied up one series with the patch.

2. I think, we don't need this because the value can be used in auxdata directly.

So, I don't apply this.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.