exfat: fix range validation error in alloc and free cluster
Subsystems (2)
PATCH 1/1 exfat: fix range validation error in alloc and free cluster
There is check error in range condition that can never be entered even with invalid input.
Replace incorrent checking code with already existing valid checker.
Signed-off-by hyeongseok.kim <[email protected]>
--- fs/exfat/fatent.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
fs/exfat/fatent.c +2 -2
@@ -169,7 +169,7 @@ int exfat_free_cluster(struct inode *inode, struct exfat_chain *p_chain)return 0 ;/* check cluster validation */ -if (p_chain->dir <2 && p_chain->dir >= sbi->num_clusters) { +if (!is_valid_cluster (sbi, p_chain->dir)) {exfat_err (sb,"invalid start cluster (%u)" , p_chain->dir);return -EIO ; }
@@ -346,7 +346,7 @@ int exfat_alloc_cluster(struct inode *inode, unsigned int num_alloc, }/* check cluster validation */ -if (hint_clu <EXFAT_FIRST_CLUSTER && hint_clu >= sbi->num_clusters) { +if (!is_valid_cluster (sbi, hint_clu)) {exfat_err (sb,"hint_cluster is invalid (%u)" , hint_clu); hint_clu =EXFAT_FIRST_CLUSTER ;
Signature · 1 line
2.7.4
Quoted 5 lines
There is check error in range condition that can never be entered even with invalid input.
Replace incorrent checking code with already existing valid checker.Signed-off-by hyeongseok.kim <[email protected]>
Acked-by Sungjong Seo <[email protected]>
Looks good. Thank you!
Quoted 31 lines
--- fs/exfat/fatent.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)fs/exfat/fatent.c index 267e5e0..4e5c5c9 renamed from fs/exfat/fatent.c +0
-0100644
fs/exfat/fatent.c +1
-1@@ -169,7 +169,7 @@ int exfat_free_cluster(struct inode *inode, struct exfat_chain *p_chain)return 0 ;/* check cluster validation */ -if (p_chain->dir <2 && p_chain->dir >= sbi->num_clusters) { +if (!is_valid_cluster (sbi, p_chain->dir)) {exfat_err (sb,"invalid start cluster (%u)" , p_chain->dir);return -EIO ;fs/exfat/fatent.c +1
-1}@@ -346,7 +346,7 @@ int exfat_alloc_cluster(struct inode *inode, unsigned int num_alloc, }/* check cluster validation */ -if (hint_clu <EXFAT_FIRST_CLUSTER && hint_clu >= sbi->num_clusters) { +if (!is_valid_cluster (sbi, hint_clu)) { exfat_err(sb, "hint_cluster is invalid (%u)",fs/exfat/fatent.c +0
-1hint_clu); hint_clu =EXFAT_FIRST_CLUSTER ; --2.7.4
Namjae Jeon
AppliedQuoted 10 lines
Quoted 6 lines
There is check error in range condition that can never be entered even with invalid input.
Replace incorrent checking code with already existing valid checker.Signed-off-by hyeongseok.kim <[email protected]>Acked-by Sungjong Seo <[email protected]>Looks good. Thank you!
Applied. Thanks!