Skip to contentSkip to conversation

fix "memcg_stress" test

PATCH In review Mitani 2 participants 2 messages Sep 22, 2010

lore
Share & tools
lore

Mitani

author
#0 lore raw

PATCH 1/1 fix "memcg_stress" test

I noticed that "memcg_stress" test failed in my RHEL5.5/RHEL4.8 systems:
------------(RHEL4.8)
cgroup_regression_test 10 TCONF : Remaining cases not appropriate for
configuration
grep: /proc/cgroups: No such file or directory
memcg_regression_test 1 TCONF : Either memory resource controller
kernel support absent
memcg_regression_test 1 TCONF : or feature is not enabled; skipping
all memcgroup testcases.
grep: /proc/cgroups: No such file or directory
WARNING:
Either Kernel does not support for memory resource controller or feature not enabled
Skipping all memcgroup testcases.... /opt/ltp/testcases/bin/memcg_stress_test.sh:
/opt/ltp/testcases/bin/memcg_stress_test.sh: cannot execute binary file
grep: /proc/cgroups: No such file or directory
WARNING:
Either kernel does not support memory resource controller or feature not enabled
Skipping all memcg_control testcases....
------------

------------(RHEL5.5)
cgroup_regression_test 10 TCONF : Remaining cases not appropriate for
configuration
grep: /proc/cgroups: No such file or directory
memcg_regression_test 1 TCONF : Either memory resource controller
kernel support absent
memcg_regression_test 1 TCONF : or feature is not enabled; skipping
all memcgroup testcases.
grep: /proc/cgroups: No such file or directory
WARNING:
Either Kernel does not support for memory resource controller or feature not enabled
Skipping all memcgroup testcases.... ★/opt/ltp/testcases/bin/memcg_stress_test.sh: line 1: ・ソ#!: command not found
grep: /proc/cgroups: No such file or directory
WARNING:
Either Kernel does not support for memory resource controller or feature not enabled
Skipping all memcgroup testcases....
grep: /proc/cgroups: No such file or directory
WARNING:
Either kernel does not support memory resource controller or feature not enabled
Skipping all memcg_control testcases....
------------

In RHEL4.8, the shell file is recognized as binary file. In RHEL5.5, the first command line of the shell cannnt be recognized.

By following patch, BOM (Byte Order Mark) was set to "memcg_stress_test.sh":
http://ltp.git.sourceforge.net/git/gitweb.cgi?p=ltp/ltp-dev.git;a=commitdiff
;h=9b9a6bb10258bc975bd1707b418699264d3bdcef#patch1

I noticed BOM in the shell by using "less memcg_stress_test.sh" command.

I removed this BOM and this test passed.

============
---
a/testcases/kernel/controllers/memcg/stress/memcg_stress_test.sh 2010
-09-20 23:22:34.000000000 +0900
+++
b/testcases/kernel/controllers/memcg/stress/memcg_stress_test.sh 2010
-09-22 10:30:50.000000000 +0900
@@ -1,4 +1,4 @@
-・ソ#! /bin/sh
+#! /bin/sh

############################################################################
####
##
##
============

Thank you--

-Tomonori Mitani

testcases/kernel/controllers/memcg/stress/memcg_stress_test.sh +1 -1
@@ -1,4 +1,4 @@
-#! /bin/sh
+#! /bin/sh
 
 ################################################################################
 ##                                                                            ##

------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#1 lore raw

2010/9/22 Mitani <[email protected]>:

Quoted 75 lines

I noticed that "memcg_stress" test failed in my RHEL5.5/RHEL4.8 systems:
------------(RHEL4.8)
cgroup_regression_test   10  TCONF  :  Remaining cases not appropriate for configuration
grep: /proc/cgroups: No such file or directory memcg_regression_test    1  TCONF  :  Either memory resource controller kernel support absent
memcg_regression_test    1  TCONF  :  or feature is not enabled; skipping all memcgroup testcases.
grep: /proc/cgroups: No such file or directory
WARNING:
Either Kernel does not support for memory resource controller or feature not enabled
Skipping all memcgroup testcases.... /opt/ltp/testcases/bin/memcg_stress_test.sh:
/opt/ltp/testcases/bin/memcg_stress_test.sh: cannot execute binary file
grep: /proc/cgroups: No such file or directory
WARNING:
Either kernel does not support memory resource controller or feature not enabled
Skipping all memcg_control testcases....
------------

------------(RHEL5.5)
cgroup_regression_test   10  TCONF  :  Remaining cases not appropriate for configuration
grep: /proc/cgroups: No such file or directory memcg_regression_test    1  TCONF  :  Either memory resource controller kernel support absent
memcg_regression_test    1  TCONF  :  or feature is not enabled; skipping all memcgroup testcases.
grep: /proc/cgroups: No such file or directory
WARNING:
Either Kernel does not support for memory resource controller or feature not enabled
Skipping all memcgroup testcases.... ★/opt/ltp/testcases/bin/memcg_stress_test.sh: line 1: ・ソ#!: command not found
grep: /proc/cgroups: No such file or directory
WARNING:
Either Kernel does not support for memory resource controller or feature not enabled
Skipping all memcgroup testcases....
grep: /proc/cgroups: No such file or directory
WARNING:
Either kernel does not support memory resource controller or feature not enabled
Skipping all memcg_control testcases....
------------

In RHEL4.8, the shell file is recognized as binary file. In RHEL5.5, the first command line of the shell cannnt be recognized.

By following patch, BOM (Byte Order Mark) was set to "memcg_stress_test.sh":
http://ltp.git.sourceforge.net/git/gitweb.cgi?p=ltp/ltp-dev.git;a=commitdiff
;h=9b9a6bb10258bc975bd1707b418699264d3bdcef#patch1

I noticed BOM in the shell by using "less memcg_stress_test.sh" command.

I removed this BOM and this test passed.

============
---
a/testcases/kernel/controllers/memcg/stress/memcg_stress_test.sh        2010 -09-20 23:22:34.000000000 +0900
+++
b/testcases/kernel/controllers/memcg/stress/memcg_stress_test.sh        2010 -09-22 10:30:50.000000000 +0900

(quoted diff) +1 -1
@@ -1,4 +1,4 @@
-・ソ#! /bin/sh
+#! /bin/sh
 
 
 ############################################################################
Quoted 4 lines

####
 ##
##
============

Fixed in ltp.git.
Cheers,
-Garrett

------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
Ltp-list mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list