387 emulator hack - mutant AAD trick - any objections?
Will there be any objections to using a quasi-documented mutation of the x86's AAD instruction in the 387 emulator? Every CPU around has to do this mutation correctly or a LOT of existing code will break...
The performance of storing to user space of BCD numbers in the 387 emulator code could be improved significantly by using the mutant AAD instruction trick (i.e. alter its implicit base from 10 to 16). See reg_ld_str.c, in function FPU_store_bcd()
As it stands now, the BCD digits are being decoded one at a time in a 10 iteration divide by 10 loop that makes two calls to an extended precision division routine.
This loop could be morphed into a 5 iteration divide by 100 loop.
The remainder of a divide by 100 would be processed thus (pseudo asm code):
AL = remainder
AH = 0
AAM /* this creates BCD nibbles in low 4 of AH and AL */
AAD (mutated with 16 as base rather than 10)
Now AL contains two packed BCD digits. Here's a worked out example of the
transformation of data starting with an initial remainder of 35 (decimal) in AX
1) Start with AX = 0x0023
2) Execute AAM instruction
3) Now AX = 0x0203 (unpacked BCD)
4) Execute base 16 AAD instruction
5) Now AX = 0x0023 (packed BCD)
AAM and AAD aren't cheap instructions, but compared to the cost of 2X trips through the extended precision divide routine, they are quite a bargain.
Quoted 8 lines · [email protected] writes:
Will there be any objections to using a quasi-documented mutation of the x86's AAD instruction in the 387 emulator? Every CPU around has to do this mutation correctly or a LOT of existing code will break...
The performance of storing to user space of BCD numbers in the 387 emulator code could be improved significantly by using the mutant AAD instruction trick (i.e. alter its implicit base from 10 to 16). See
reg_ld_str.c, in functionFPU_store_bcd()
What do you mean by "quasi-documented" and "mutant"? Intel certainly documents the "D5 ib" form as being a valid way to change the base from the default 10.
The only issue AFAIK is that assemblers may only recognise the plain base-10 AAD syntax. No biggie.
/Mikael
Quoted 2 lines · Mikael Pettersson
The only issue AFAIK is that assemblers may only recognise the plain base-10 AAD syntax. No biggie.
And actually gas has supported the explicit operand variations for "aad"
and "aam" for a long time now.
Maciej