Skip to contentSkip to conversation

rtc: rtc-mv: remove erroneous __exit annotation

PATCH Jingoo Han 1 participant 1 message Feb 28, 2013

lore
Share & tools
lore

Jingoo Han

author
#0 lore raw
Quoted 7 lines · Jingoo Han

__init/__exit annotations for probe()/remove() are supposed to be __devinit/__devexit, because __init/__exit for probe()/remove() are not correct. However, __devinit/__devexit are not used, because CONFIG_HOTPLUG was removed. Thus, these annotations should be removed.

Hi Andrew,

As Geert Uytterhoeven mentioned, the patchset is useless because the drivers I sent for use platform_driver_probe().

Please, abandon all patchset that I sent.
Thank you.

Best regards,
Jingoo Han

Quoted 29 lines
---
 drivers/rtc/rtc-mv.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/rtc/rtc-mv.c +2 -3
index 57233c8..8cb15d2 100644
@@ -284,7 +284,7 @@ static int mv_rtc_probe(struct platform_device *pdev)
 	return 0;
 }
 
-static int __exit mv_rtc_remove(struct platform_device *pdev)
+static int mv_rtc_remove(struct platform_device *pdev)
 {
 	struct rtc_plat_data *pdata = platform_get_drvdata(pdev);
 
@@ -303,7 +303,7 @@ static struct of_device_id rtc_mv_of_match_table[] = {
 #endif
 
 static struct platform_driver mv_rtc_driver = {
-	.remove		= __exit_p(mv_rtc_remove),
+	.remove		= mv_rtc_remove,
 	.driver		= {
 		.name	= "rtc-mv",
 		.owner	= THIS_MODULE,
--

1.7.2.5