thermal: rcar: remove unnecessary platform_set_drvdata()
Subsystems (2)
PATCH 5/6 thermal: rcar: remove unnecessary platform_set_drvdata()
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.
--- drivers/thermal/rcar_thermal.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/thermal/rcar_thermal.c +0 -2
@@ -487,8 +487,6 @@ static int rcar_thermal_remove(struct platform_device *pdev)rcar_thermal_irq_disable (priv); } -platform_set_drvdata (pdev,NULL ); -pm_runtime_put_sync (dev);pm_runtime_disable (dev);
Signature · 1 line
1.7.2.5
Dear Jingoo, Sachin
Quoted 15 lines
The driver core clears the driver data to NULL after
device_releaseor on probe failure, since commit0998d0631001288a5974afc0b2a5f568bcdecb4d(device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.Signed-off-by Jingoo Han <[email protected]>--- drivers/thermal/rcar_thermal.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)drivers/thermal/rcar_thermal.c +0
-0
drivers/thermal/rcar_thermal.c static int rcar_thermal_remove(struct platform_device *pdev) · line 491
Quoted 7 lines
drivers/thermal/rcar_thermal.c +0
-2@@ -487,8 +487,6 @@ static int rcar_thermal_remove(struct platform_device *pdev)rcar_thermal_irq_disable (priv); } -platform_set_drvdata (pdev,NULL ); -pm_runtime_put_sync (dev);pm_runtime_disable (dev);
I got very similar patch for rcar_thermal.c
from Jingoo and Sachin
Subject: [PATCH 5/6] thermal: rcar: remove unnecessary platform_set_drvdata()
From: Jingoo Han <[email protected]>
Subject: [PATCH 5/6] Thermal: rcar: Remove redundant platform_set_drvdata()
From: Sachin Kamat <[email protected]>
I'm not sure which one will be applied, but, for both patch,
Best regards
--
Kuninori Morimoto
Quoted 32 lines · Kuninori Morimoto
Dear Jingoo, Sachin
Quoted 15 lines
The driver core clears the driver data to NULL after
device_releaseor on probe failure, since commit0998d0631001288a5974afc0b2a5f568bcdecb4d(device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.Signed-off-by Jingoo Han <[email protected]>--- drivers/thermal/rcar_thermal.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)drivers/thermal/rcar_thermal.c +0
-0drivers/thermal/rcar_thermal.c static int rcar_thermal_remove(struct platform_device *pdev) · line 491
Quoted 7 lines
drivers/thermal/rcar_thermal.c +0
-2@@ -487,8 +487,6 @@ static int rcar_thermal_remove(struct platform_device *pdev)rcar_thermal_irq_disable (priv); } -platform_set_drvdata (pdev,NULL ); -pm_runtime_put_sync (dev);pm_runtime_disable (dev);I got very similar patch for
rcar_thermal.c
from Jingoo and SachinSubject: [PATCH 5/6] thermal: rcar: remove unnecessary
platform_set_drvdata()
From: Jingoo Han <[email protected]>
Quoted 6 lines
Subject: [PATCH 5/6] Thermal: rcar: Remove redundant
platform_set_drvdata()
From: Sachin Kamat <[email protected]>I'm not sure which one will be applied, but, for both patch,
Hi Kuninori Morimoto,
In this case, Sachin submitted the patchset before I did; thus, Sachin's patch will be merged.
Sachin, thank you for your job.
Without you, cleaning cannot be done. :)
Best regards,
Jingoo Han
Quoted 5 lines
Best regards
--
Kuninori Morimoto