Skip to contentSkip to conversation

mfd: menelaus: use NULL instead of 0

PATCH Applied Jingoo Han 2 participants 2 messages Aug 2, 2013

Subsystems (2)
lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH v2 1/1 mfd: menelaus: use NULL instead of 0

'mmc_callback_data' and 'vtg' are pointers.
Fix the following sparse warning:

drivers/mfd/menelaus.c:445:43: warning: Using plain integer as NULL pointer drivers/mfd/menelaus.c:469:20: warning: Using plain integer as NULL pointer

---
 drivers/mfd/menelaus.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/mfd/menelaus.c +2 -2
index 998ce8c..e4c9339 100644
@@ -442,7 +442,7 @@ void menelaus_unregister_mmc_callback(void)
 	menelaus_remove_irq_work(MENELAUS_MMC_S2D1_IRQ);
 
 	the_menelaus->mmc_callback = NULL;
-	the_menelaus->mmc_callback_data = 0;
+	the_menelaus->mmc_callback_data = NULL;
 }
 EXPORT_SYMBOL(menelaus_unregister_mmc_callback);
 
@@ -466,7 +466,7 @@ static int menelaus_set_voltage(const struct menelaus_vtg *vtg, int mV,
 	struct i2c_client *c = the_menelaus->client;
 
 	mutex_lock(&the_menelaus->lock);
-	if (vtg == 0)
+	if (!vtg)
 		goto set_voltage;
 
 	ret = menelaus_read_reg(vtg->vtg_reg);
Signature · 1 line
1.7.10.4
Applied
#1 lore raw

drivers/mfd/menelaus.c

Quoted 12 lines · Jingoo Han

'mmc_callback_data' and 'vtg' are pointers.
Fix the following sparse warning:

drivers/mfd/menelaus.c:445:43: warning: Using plain integer as NULL pointer drivers/mfd/menelaus.c:469:20: warning: Using plain integer as NULL pointer

---
 drivers/mfd/menelaus.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/mfd/menelaus.c +0 -0

Applied, thanks.

Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog