Skip to contentSkip to conversation

When the inside functions of a sfq are called ?

LARTC Adrian Saileanu 3 participants 7 messages Apr 15, 2004 – Apr 19, 2004

lore
Share & tools
lore
#0 lore raw

I read the sched/qdiscs code from kernel source ... and I have some
questions :

When the .enqueue, .dequeue, .drop, .requeue functions are called ? What
is the event that triggers them and how often this event apears ( per second ? ) ? When a qdisc is dequeued ( when it's limit is reached ) ?

Thanks

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

#1 lore raw

Logicaly it would be so:
enqueue caled by last(leaf) filter
dequeue called by htb
drop should not be used in normal operation, probably called on "tc dev eth0 del root"

(this is what I think it should be not nessecary t is so)

----- Original Message -----
From: "Adrian Saileanu" <[email protected]>
To: <[email protected]>
Sent: Thursday, April 15, 2004 8:10 PM
Subject: [LARTC] When the inside functions of a sfq are called ?

Quoted 14 lines

I read the sched/qdiscs code from kernel source ... and I have some
questions :

When the .enqueue, .dequeue, .drop, .requeue functions are called ? What
is the event that triggers them and how often this event apears ( per second ? ) ? When a qdisc is dequeued ( when it's limit is reached ) ?

Thanks

Quoted 4 lines

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

#2 lore raw
In reply to Adrian Saileanu
Quoted 5 lines

Logicaly it would be so:
enqueue caled by last(leaf) filter
dequeue called by htb
drop should not be used in normal operation, probably called on "tc dev

eth0 del root"

I think .drop is not being called when the qdisc gets deleted ...
Haven't you ever seen droped pachets when looking at the statistics by a qdisc ? I suspect that htb is also calling this function whenever the bandwith requested by the qdisk is not big enough !

Quoted 25 lines

(this is what I think it should be not nessecary t is so)

----- Original Message -----
From: "Adrian Saileanu" <[email protected]>
To: <[email protected]>
Sent: Thursday, April 15, 2004 8:10 PM
Subject: [LARTC] When the inside functions of a sfq are called ?

Quoted 15 lines

I read the sched/qdiscs code from kernel source ... and I have some
questions :

When the .enqueue, .dequeue, .drop, .requeue functions are called ?
What
is the event that triggers them and how often this event apears ( per second ? ) ? When a qdisc is dequeued ( when it's limit is reached ) ?

Thanks

Quoted 9 lines
Quoted 4 lines

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

Adrian Saileanu
Netmaster Communications Srl

address: Str. Ion Brezoianu Nr. 20
Sector 1, Bucuresti, Romania

office: +40 21 315 92 00
mobile: +40 723 979 586
email: [email protected]

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

#3 lore raw
In reply to Adrian Saileanu

----- Original Message -----
From: "Adrian Saileanu" <[email protected]>
To: "Roy" <[email protected]>
Cc: <[email protected]>
Sent: Friday, April 16, 2004 3:24 PM
Subject: Re: [LARTC] When the inside functions of a sfq are called ?

Quoted 5 lines
Quoted 5 lines

Logicaly it would be so:
enqueue caled by last(leaf) filter
dequeue called by htb
drop should not be used in normal operation, probably called on

Quoted 7 lines

'"'tc dev
eth0 del root'"'

I think .drop is not being called when the qdisc gets deleted ...
Haven't you ever seen droped pachets when looking at the statistics by a qdisc ? I suspect that htb is also calling this function whenever the bandwith requested by the qdisk is not big enough !

No, that is incorrect, when qdisc gets deleted its statistic also gets deleted,
and if you are downloading at that time you may notice that downloads stops for short time
so pakets are deleted, or else who will dequeue them if you deleted htb?

Quoted 18 lines
Quoted 2 lines

(this is what I think it should be not nessecary t is

so)

Quoted 3 lines

----- Original Message -----
From: '"'Adrian Saileanu'"'

http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

Quoted 6 lines
Quoted 1 line

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

Adrian Saileanu
Netmaster Communications Srl

Quoted 12 lines

address: Str. Ion Brezoianu Nr. 20
Sector 1, Bucuresti, Romania

office: +40 21 315 92 00
mobile: +40 723 979 586
email: [email protected]

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

#4 lore raw
In reply to Adrian Saileanu
Quoted 4 lines · Adrian Saileanu

I read the sched/qdiscs code from kernel source ... and I have some
questions :

When the .enqueue, .dequeue, .drop, .requeue functions are called ?

Do you mean in sfq.c - ie sfq_enqueue etc. Maybe you mean something else.

What

Quoted 2 lines

is the event that triggers them and how often this event apears ( per second ? ) ?

I don't know as such, but always assumed that when attached to HTB - a packet gets enqueued if there aren't enough (c)tokens to send it and dequeued when there are. As for timing I don't think sfq uses any - it's up to whatever it is attached to.

sfq_drop is called from sfq_enqueue when the queue is full. It drops from the longest slot.

requeue - don't know.

Andy.

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

#5 lore raw
In reply to Adrian Saileanu
Quoted 8 lines
Quoted 4 lines · Adrian Saileanu

I read the sched/qdiscs code from kernel source ... and I have some
questions :

When the .enqueue, .dequeue, .drop, .requeue functions are called ?

Do you mean in sfq.c - ie sfq_enqueue etc. Maybe you mean something else.

Yes, I ment the functions in the Qdisc_ops struct :

+static struct Qdisc_ops dup_qdisc_ops = {

+        .next                = NULL,
+        .cl_ops                = NULL,
+        .id                = "sfq",
+        .priv_size        = sizeof(struct sfq_sched_data),
+        .enqueue        = sfq_enqueue,
+        .dequeue        = sfq_dequeue,
+        .requeue        = sfq_requeue,
+        .drop                = sfq_drop,
+        .init                = sfq_init,
+        .reset                = sfq_reset,
+        .destroy        = NULL,
+        .change                = sfq_init,
+        .dump                = sfq_dump,
+        .owner                = THIS_MODULE,

+};

Quoted 9 lines

What

Quoted 2 lines

is the event that triggers them and how often this event apears ( per second ? ) ?

I don't know as such, but always assumed that when attached to HTB - a packet gets enqueued if there aren't enough (c)tokens to send it and dequeued when there are. As for timing I don't think sfq uses any - it's up to whatever it is attached to.

Ok, the packet gets enqueued ... and the queue gets full. Then if a new
packet arrives and the queue is still full ( it has not been dequeued ) then this packet is dropped. My question is ... is the queue dequeued when it is full ? Or t can be dequeued even when the maximum has not been reatched ? When this .dequeue function is called ?

Quoted 3 lines

sfq_drop is called from sfq_enqueue when the queue is full. It drops from the longest slot.

I know this ...

Quoted 8 lines

requeue - don't know.

Andy.

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

Adrian Saileanu
Netmaster Communications Srl

address: Str. Ion Brezoianu Nr. 20
Sector 1, Bucuresti, Romania

office: +40 21 315 92 00
mobile: +40 723 979 586
email: [email protected]

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

#6 lore raw
In reply to Adrian Saileanu
Quoted 43 lines · Adrian Saileanu
Quoted 8 lines
Quoted 4 lines · Adrian Saileanu

I read the sched/qdiscs code from kernel source ... and I have some
questions :

When the .enqueue, .dequeue, .drop, .requeue functions are called ?

Do you mean in sfq.c - ie sfq_enqueue etc. Maybe you mean something else.

Yes, I ment the functions in the Qdisc_ops struct :

(quoted diff) +16 -0
+static struct Qdisc_ops dup_qdisc_ops = {
+        .next                = NULL,
+        .cl_ops                = NULL,
+        .id                = "sfq",
+        .priv_size        = sizeof(struct sfq_sched_data),
+        .enqueue        = sfq_enqueue,
+        .dequeue        = sfq_dequeue,
+        .requeue        = sfq_requeue,
+        .drop                = sfq_drop,
+        .init                = sfq_init,
+        .reset                = sfq_reset,
+        .destroy        = NULL,
+        .change                = sfq_init,
+        .dump                = sfq_dump,
+        .owner                = THIS_MODULE,
+};
Quoted 5 lines

What

Quoted 8 lines
Quoted 2 lines

is the event that triggers them and how often this event apears ( per second ? ) ?

I don't know as such, but always assumed that when attached to HTB - a packet gets enqueued if there aren't enough (c)tokens to send it and dequeued when there are. As for timing I don't think sfq uses any - it's up to whatever it is attached to.

Quoted 3 lines

Ok, the packet gets enqueued ... and the queue gets full. Then if a new
packet arrives and the queue is still full ( it has not been dequeued ) then this packet is dropped.

I think a packet gets enqueued - then the queue length is checked and if it's full sfq_drop is called. sfq_drop drops a packet from the longest slot - hence the packet that filled the queue may or may not be the one that is dropped depending on which slot it got hashed to.

Quoted 3 lines

My question is ... is the queue dequeued
when it is full ? Or t can be dequeued even when the maximum has not been reatched ? When this .dequeue function is called ?

It is normal for dequeue to be called before the queue is full - exactly when it gets called is the job of whatever the sfq got attached to.

Andy.

_______________________________________________
LARTC mailing list / [email protected]
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/