Skip to contentSkip to conversation

: Add Makefile, config.mk and u-boot.lds.S in board/st/stls/ directory!

PATCH New Ryan CHEN 3 participants 5 messages Jul 30, 2008 – Jul 31, 2008

lore
Share & tools
lore

Ryan CHEN

author
#0 lore raw

PATCH 1/1 : Add Makefile, config.mk and u-boot.lds.S in board/st/stls/ directory!

commit d66194654186b0e82d926ce4844b73e3508397f4

Parent: 699f05125509249072a0b865c8d35520d97cd501
Author: Ryan Chen <[email protected]>
Date:   Tue Jul 29 13:35:15 2008 -0400
Signed-off-by Ryan Chen <[email protected]>

new file: board/st/stls/Makefile
new file: board/st/stls/config.mk
new file: board/st/stls/u-boot.lds.S

board/st/stls/Makefile new file +48 -0
new file mode 100755
index 0000000..8213838
@@ -0,0 +1,48 @@
+#
+# (C) Copyright 2003-2006
+# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+include $(TOPDIR)/config.mk
+
+LIB	= $(obj)lib$(BOARD).a
+
+COBJS	= flash.o pci.o stls_board.o ide.o
+
+SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
+OBJS	:= $(addprefix $(obj),$(COBJS))
+SOBJS	:= $(addprefix $(obj),$(SOBJS))
+
+$(LIB):	$(obj).depend $(OBJS) $(SOBJS) u-boot.lds
+	$(AR) $(ARFLAGS) $@ $(OBJS) $(SOBJS)
+
+u-boot.lds: u-boot.lds.S
+	$(CPP) $(CPPFLAGS) -P $^ > [email protected]
+	mv -f [email protected] $@
+
+#########################################################################
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#########################################################################
board/st/stls/config.mk new file +29 -0
new file mode 100755
index 0000000..683b009
@@ -0,0 +1,29 @@
+#
+# (C) Copyright 2003
+# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+#
+# ST development board stls, Loongson core
+#
+TEXT_BASE = 0xc0000000
+
+#GUI_SUPPORT = minigui
\ No newline at end of file
board/st/stls/u-boot.lds.S new file +69 -0

69 lines not on this page · raw message

Best Regards,
Ryan Chen

#1 lore raw

PATCH 1/1 : Add Makefile, config.mk and u-boot.lds.S in board/st/stls/ directory!

Quoted 10 lines · In message <[email protected]> you wrote:

commit d66194654186b0e82d926ce4844b73e3508397f4

Parent: 699f05125509249072a0b865c8d35520d97cd501
Author: Ryan Chen <[email protected]>
Date:   Tue Jul 29 13:35:15 2008 -0400
Signed-off-by Ryan Chen <[email protected]>

new file: board/st/stls/Makefile
new file: board/st/stls/config.mk
new file: board/st/stls/u-boot.lds.S

Please use git-format-patch to format the patch. Above text is NOT an acceptable commit message.

Quoted 6 lines
(quoted diff) +1 -0
+#########################################################################
board/st/stls/config.mk new file +0 -0
new file mode 100755
index 0000000..683b009

...

Quoted 2 lines

+#GUI_SUPPORT = minigui
\ No newline at end of file

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Please fix this!!

board/st/stls/u-boot.lds.S

Quoted 5 lines
board/st/stls/u-boot.lds.S new file +0 -0
new file mode 100755
index 0000000..5e7bb76

Why not u-boot.lds like for all the other boards? The ".S" suffix suggests it is an assembler file, which it ain't.

Hm... This patch is incomplete, as it does not add all filkes needed to support this board. On the other hand, it is not part of a patch series (at least it is not m,arked as such, and not threaded accordingly).

Please fix.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
(null cookie; hope that's ok)
author
#2 lore raw

PATCH 1/1 : Add Makefile, config.mk and u-boot.lds.S in board/st/stls/ directory!

Hi Wolfgang,
I have modified my patch name and contents to follow proper U-Boot patch way.
The reason that I use u-boot.lds.S file is that it includes TEXT_BASE parameter and need be pre-compiled to generate u-boot.lds file. The TEXT_BASE parameter only be defined in board/st/stls/config.mk file. I don't want to write it as a fixed value in u-boot.lds. I think it's a good way to keep the same parameter coherent in different places.

board/st/stls/Makefile new file mode renamed from board/st/stls/Makefile +0 -0

100755 index 0000000..8213838

board/st/stls/Makefile new file +48 -0

48 lines not on this page · raw message

+##

board/st/stls/config.mk new file mode renamed from board/st/stls/config.mk +0 -0

100755 index 0000000..683b009

board/st/stls/config.mk new file +27 -0
@@ -0,0 +1,29 @@
+#
+# (C) Copyright 2003
+# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
+#
+# See file CREDITS for list of people who contributed to this # 
+project.
+#
+# This program is free software; you can redistribute it and/or # 
+modify it under the terms of the GNU General Public License as # 
+published by the Free Software Foundation; either version 2 of # the 
+License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful, # but 
+WITHOUT ANY WARRANTY; without even the implied warranty of # 
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the # GNU 
+General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License # 
+along with this program; if not, write to the Free Software # 
+Foundation, Inc., 59 Temple Place, Suite 330, Boston, # MA 02111-1307 
+USA #
+
+#
+# ST development board stls, Loongson core # TEXT_BASE = 0xc0000000
+
+#GUI_SUPPORT = minigui
+
board/st/stls/u-boot.lds.S new renamed from board/st/stls/u-boot.lds.S +0 -0

file mode 100755 index 0000000..5e7bb76

board/st/stls/u-boot.lds.S new file +69 -0

69 lines not on this page · raw message

+}

Best Regards,
Ryan Chen
-----Original Message-----
From: [email protected] [mailto:wd at denx.de]
Sent: Wednesday, July 30, 2008 2:56 PM
To: Ryan CHEN
Cc: u-boot-users at lists.sourceforge.net; Antonio Maria BORNEO
Subject: Re: [U-Boot-Users] [PATCH for STLS]: Add Makefile, config.mk and u-boot.lds.S in board/st/stls/ directory!

Quoted 10 lines · In message <[email protected]> you wrote:

commit d66194654186b0e82d926ce4844b73e3508397f4

Parent: 699f05125509249072a0b865c8d35520d97cd501
Author: Ryan Chen <[email protected]>
Date:   Tue Jul 29 13:35:15 2008 -0400
Signed-off-by Ryan Chen <[email protected]>

new file: board/st/stls/Makefile
new file: board/st/stls/config.mk
new file: board/st/stls/u-boot.lds.S

Please use git-format-patch to format the patch. Above text is NOT an acceptable commit message.

Quoted 6 lines
(quoted diff) +2 -0
+#####################################################################
+####
board/st/stls/config.mk new renamed from board/st/stls/config.mk +0 -0

file mode 100755 index 0000000..683b009

board/st/stls/config.mk new file +0 -0

...

Quoted 2 lines

+#GUI_SUPPORT = minigui
\ No newline at end of file

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Please fix this!!

board/st/stls/u-boot.lds.S

Quoted 4 lines
board/st/stls/u-boot.lds.S new file +0 -0
new file mode 100755 index 0000000..5e7bb76

Why not u-boot.lds like for all the other boards? The ".S" suffix suggests it is an assembler file, which it ain't.

Hm... This patch is incomplete, as it does not add all filkes needed to support this board. On the other hand, it is not part of a patch series (at least it is not m,arked as such, and not threaded accordingly).

Please fix.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
(null cookie; hope that's ok)
#3 lore raw

PATCH 1/1 : Add Makefile, config.mk and u-boot.lds.S in board/st/stls/ directory!

In reply to Ryan CHEN
Quoted 10 lines · Ryan CHEN

commit d66194654186b0e82d926ce4844b73e3508397f4

Parent: 699f05125509249072a0b865c8d35520d97cd501
Author: Ryan Chen <[email protected]>
Date:   Tue Jul 29 13:35:15 2008 -0400
Signed-off-by Ryan Chen <[email protected]>

new file: board/st/stls/Makefile
new file: board/st/stls/config.mk
new file: board/st/stls/u-boot.lds.S

Could you do it in the same patch where you add the board support?

with the update of the General Makefile, MAKALL and MAINTAINERS in it

Best Regards,
J.

Quoted 31 lines
board/st/stls/Makefile new file +24 -0
new file mode 100755
index 0000000..8213838
@@ -0,0 +1,48 @@
+#
+# (C) Copyright 2003-2006
+# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+include $(TOPDIR)/config.mk

board/st/stls/Makefile line 34

Quoted 10 lines
board/st/stls/Makefile new file +10 -0
+
+LIB	= $(obj)lib$(BOARD).a
+
+COBJS	= flash.o pci.o stls_board.o ide.o
+
+SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
+OBJS	:= $(addprefix $(obj),$(COBJS))
+SOBJS	:= $(addprefix $(obj),$(SOBJS))
+
+$(LIB):	$(obj).depend $(OBJS) $(SOBJS) u-boot.lds

please use $(obj) for generated file in order to build it out-of-tree

board/st/stls/Makefile line 40

Quoted 6 lines
board/st/stls/Makefile new file +6 -0
+	$(AR) $(ARFLAGS) $@ $(OBJS) $(SOBJS)
+
+u-boot.lds: u-boot.lds.S
+	$(CPP) $(CPPFLAGS) -P $^ > [email protected]
+	mv -f [email protected] $@
+

Best Regards,
J.

author
#4 lore raw

PATCH 1/1 : Add Makefile, config.mk and u-boot.lds.S in board/st/stls/ directory!

Hi all,
Sorry, I need resend my patch according to Jean's suggestions and please ignore previous [Part 1 of A PATCH SERIES for STLS] mail. Thanks! Hi Jean,
I will send [Part 2 of A PATCH SERIES for STLS] email to update General Makefile, MAKALL and MAINTAINERS files. And I will try to move board/st/stls/flash.c to mtd support directory. Thanks!

Signed-off-by Ryan Chen <[email protected]>
board/st/stls/Makefile new file mode renamed from board/st/stls/Makefile +0 -0

100755 index 0000000..8213838

board/st/stls/Makefile new file +48 -0

48 lines not on this page · raw message

+##

board/st/stls/config.mk new file mode renamed from board/st/stls/config.mk +0 -0

100755 index 0000000..683b009

board/st/stls/config.mk new file +27 -0
@@ -0,0 +1,29 @@
+#
+# (C) Copyright 2003
+# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
+#
+# See file CREDITS for list of people who contributed to this # 
+project.
+#
+# This program is free software; you can redistribute it and/or # 
+modify it under the terms of the GNU General Public License as # 
+published by the Free Software Foundation; either version 2 of # the 
+License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful, # but 
+WITHOUT ANY WARRANTY; without even the implied warranty of # 
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the # GNU 
+General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License # 
+along with this program; if not, write to the Free Software # 
+Foundation, Inc., 59 Temple Place, Suite 330, Boston, # MA 02111-1307 
+USA #
+
+#
+# ST development board stls, Loongson core # TEXT_BASE = 0xc0000000
+
+#GUI_SUPPORT = minigui
+
board/st/stls/u-boot.lds.S new renamed from board/st/stls/u-boot.lds.S +0 -0

file mode 100755 index 0000000..5e7bb76

board/st/stls/u-boot.lds.S new file +69 -0

69 lines not on this page · raw message

+}

Best Regards,
Ryan Chen
-----Original Message-----
From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj at jcrosoft.com]
Sent: Wednesday, July 30, 2008 2:57 PM
To: Ryan CHEN
Cc: u-boot-users at lists.sourceforge.net; Antonio Maria BORNEO
Subject: Re: [U-Boot-Users] [PATCH for STLS]: Add Makefile, config.mk andu-boot.lds.S in board/st/stls/ directory!

Quoted 10 lines · Ryan CHEN

commit d66194654186b0e82d926ce4844b73e3508397f4

Parent: 699f05125509249072a0b865c8d35520d97cd501
Author: Ryan Chen <[email protected]>
Date:   Tue Jul 29 13:35:15 2008 -0400
Signed-off-by Ryan Chen <[email protected]>

new file: board/st/stls/Makefile
new file: board/st/stls/config.mk
new file: board/st/stls/u-boot.lds.S

Could you do it in the same patch where you add the board support?

with the update of the General Makefile, MAKALL and MAINTAINERS in it

Best Regards,
J.