Skip to contentSkip to conversation

Question on dvb-core re-structure

dvb Hamad Kadmany 4 participants 7 messages Jan 10, 2013 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

Hi,

With the new structure of dvb-core (moved up one directory), previous DVB/ATSC adapters were moved to media/usb, media/pci and media/mmc.

For SoC that supports integrated DVB functionality, where should the adapter's code be located in the new structure? I don't see it fit any of the above three options.

Thanks,

--
Hamad Kadmany,
QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

#1 lore raw
Quoted 8 lines · Hamad Kadmany

Hi,

With the new structure of dvb-core (moved up one directory), previous DVB/ATSC adapters were moved to media/usb, media/pci and media/mmc.

For SoC that supports integrated DVB functionality, where should the adapter's code be located in the new structure? I don't see it fit any of the above three options.

I could guess that even for the SoCs there is some bus used internally. If it is not one of those already existing, then create new directly just like one of those existing and put it there.

regards
Antti

Signature · 1 line
http://palosaari.fi/
#2 lore raw
Quoted 2 lines · Antti Palosaari

I could guess that even for the SoCs there is some bus used internally. If it is not one of those already existing, then create new directly just

like one of those existing and put it there.

Thanks for the answer. I just wanted to clarify - it's integrated into the chip and accessed via memory mapped registers, so I'm not sure which category to give the new directory (parallel to pci/mms/usb). Should I just put the adapter's sources directory directly under media directory?

Thanks,

--
Hamad Kadmany,
QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

#3 lore raw

Em Thu, 10 Jan 2013 13:49:52 +0200
"Hamad Kadmany" <[email protected]> escreveu:

Quoted 9 lines · Antti Palosaari
Quoted 2 lines

I could guess that even for the SoCs there is some bus used internally. If it is not one of those already existing, then create new directly just

like one of those existing and put it there.

Thanks for the answer. I just wanted to clarify - it's integrated into the chip and accessed via memory mapped registers, so I'm not sure which category to give the new directory (parallel to pci/mms/usb). Should I just put the adapter's sources directory directly under media directory?

That's the case of all other drivers under drivers/media/platform: they're IP blocks inside the SoC chip. I think that all arch-dependent drivers are there.

The menu needs to be renamed to "Media platform drivers" when the first DVB driver arrives there (it currently says V4L, as there's no DVB driver there yet). Feel free to add such patch on your patch series at the time you submit your driver, if nobody else submit any DVB platform driver earlier than yours.

Regards,
Mauro

#4 lore raw
Quoted 17 lines · Mauro Carvalho Chehab

Em Thu, 10 Jan 2013 13:49:52 +0200
"Hamad Kadmany" <[email protected]> escreveu:

Quoted 9 lines · Antti Palosaari
Quoted 2 lines

I could guess that even for the SoCs there is some bus used internally. If it is not one of those already existing, then create new directly just

like one of those existing and put it there.

Thanks for the answer. I just wanted to clarify - it's integrated into the chip and accessed via memory mapped registers, so I'm not sure which category to give the new directory (parallel to pci/mms/usb). Should I just put the adapter's sources directory directly under media directory?

That's the case of all other drivers under drivers/media/platform: they're IP blocks inside the SoC chip. I think that all arch-dependent drivers are there.

Quoted 5 lines

The menu needs to be renamed to "Media platform drivers" when the first DVB driver arrives there (it currently says V4L, as there's no DVB driver there yet). Feel free to add such patch on your patch series at the time you submit your driver, if nobody else submit any DVB platform driver earlier than yours.

What about DVB cores which can be used via different busses?
E.g. ddbridge initially only used PCIe. Now we also use the same function blocks (I2C, DVB input, etc.) connected to a SoC via an EBI (extension bus interface) and register it as a platform device. Because a lot of code can be shared I do not want to split it over several directories.

Regards,
Ralph

#5 lore raw

Em Thu, 10 Jan 2013 17:01:57 +0100
Ralph Metzler <[email protected]> escreveu:

Quoted 25 lines
Quoted 17 lines · Mauro Carvalho Chehab

Em Thu, 10 Jan 2013 13:49:52 +0200
"Hamad Kadmany" <[email protected]> escreveu:

Quoted 9 lines · Antti Palosaari
Quoted 2 lines

I could guess that even for the SoCs there is some bus used internally. If it is not one of those already existing, then create new directly just

like one of those existing and put it there.

Thanks for the answer. I just wanted to clarify - it's integrated into the chip and accessed via memory mapped registers, so I'm not sure which category to give the new directory (parallel to pci/mms/usb). Should I just put the adapter's sources directory directly under media directory?

That's the case of all other drivers under drivers/media/platform: they're IP blocks inside the SoC chip. I think that all arch-dependent drivers are there.

Quoted 5 lines

The menu needs to be renamed to "Media platform drivers" when the first DVB driver arrives there (it currently says V4L, as there's no DVB driver there yet). Feel free to add such patch on your patch series at the time you submit your driver, if nobody else submit any DVB platform driver earlier than yours.

Quoted 5 lines

What about DVB cores which can be used via different busses?
E.g. ddbridge initially only used PCIe. Now we also use the same function blocks (I2C, DVB input, etc.) connected to a SoC via an EBI (extension bus interface) and register it as a platform device. Because a lot of code can be shared I do not want to split it over several directories.

What we're doing on such cases is to put the common stuff under drivers/media/common and the bus-specific (or platform-specific) code under drivers/media/pci, drivers/media/usb, drivers/media/mmc, etc. There are, currenlty, 3 drivers like that: saa7146 (the common code were always stored at /common), b2c2 and siano.

Cheers,
Mauro

#6 lore raw
In reply to Hamad Kadmany

Em Thu, 10 Jan 2013 12:44:14 +0200
"Hamad Kadmany" <[email protected]> escreveu:

Quoted 8 lines

Hi,

With the new structure of dvb-core (moved up one directory), previous DVB/ATSC adapters were moved to media/usb, media/pci and media/mmc.

For SoC that supports integrated DVB functionality, where should the adapter's code be located in the new structure? I don't see it fit any of the above three options.

It should be inside drivers/media/platform.

Regards,
Mauro