find_isa_irq_pin can't be __init
A message that is not in the archive (sent off-list or not yet received): [email protected]
Confirmed, taking the __init off find_isa_irq_pin prevents the oops on reboot for me.
----- Original Message ----- From: "Dave Jones" <[email protected]>
Newsgroups: fa.linux.kernel
To: <[email protected]>; <[email protected]>
Cc: <[email protected]>
Sent: Sunday, October 10, 2004 4:58 PM
Subject: [PATCH] find_isa_irq_pin can't be __init
Quoted 25 lines
As spotted by one of our Fedora users, we sometimes oops during shutdown (http://www.roberthancock.com/kerneloops.png)
becausedisable_IO_APIC()wants to callfind_isa_irq_pin(), which we threw away during init.Signed-off-by Dave Jones <[email protected]>--- linux-2.6.8/arch/i386/kernel/io_apic.c~ 2004-10-10 18:54:27.490567168 -0400
+++linux-2.6.8/arch/i386/kernel/io_apic.c2004-10-10 18:54:44.660956872 -0400(quoted diff) +1
-2@@ -745,7 +745,7 @@ static int __init find_irq_entry(int api /* * Find the pin to which IRQ[irq] (ISA) is connected */ -static int __init find_isa_irq_pin(int irq, int type) +static int find_isa_irq_pin(int irq, int type) { int i; -To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/