Fix all tests pass error
PATCH 1/1 Fix all tests pass error
ret_code comes from "set +x" which always return 0, this makes all tests PASS. Actually, "set +x" isn't needed here, just get rid of it.
--- testcases/open_posix_testsuite/bin/run-tests.sh | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
testcases/open_posix_testsuite/bin/run-tests.sh +0 -2
@@ -48,8 +48,6 @@ run_test() { sh -c "$SCRIPT_DIR/t0 $TIMEOUT_VAL ./$1 $(cat ./$(echo "$1" | sed 's,\.[^\.]*,,').args 2>/dev/null)" > $complog 2>&1 - set +x - ret_code=$? if [ "$ret_code" = "0" ]; then
Signature · 12 lines
1.7.0.4 ------------------------------------------------------------------------------ Nokia and AT&T present the 2010 Calling All Innovators-North America contest Create new apps & games for the Nokia N8 for consumers in U.S. and Canada $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store http://p.sf.net/sfu/nokia-dev2dev _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
Quoted 32 lines
-----Original Message-----
From: Gui Jianfeng [mailto:[email protected]]
Sent: Thursday, October 28, 2010 10:55 AM
To: Garrett Cooper
Cc: [email protected]; [email protected]
Subject: [PATCH] Fix all tests pass error
ret_codecomes from "set +x" which always return 0, this makes all tests PASS.
Actually, "set +x" isn't needed here, just get rid of it.Signed-off-by Gui Jianfeng <[email protected]>--- testcases/open_posix_testsuite/bin/run-tests.sh | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)testcases/open_posix_testsuite/bin/run-tests.sh +0
-0@@ -48,8 +48,6 @@ run_test() { sh -c "$SCRIPT_DIR/t0 $TIMEOUT_VAL ./$1 $(cat ./$(echo "$1"| sed 's,\.[^\.]*,,').args 2>/dev/null)" > $complog 2>&1
testcases/open_posix_testsuite/bin/run-tests.sh +0
-3- set +x - ret_code=$? if [ "$ret_code" = "0" ]; then --
Quoted 1 line
1.7.0.4
Great!
I was forestalled :)
I have the same opinion, too.
Thank you--
-Tomonori Mitani
------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest Create new apps & games for the Nokia N8 for consumers in U.S. and Canada $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
Quoted 37 lines · Mitani
Quoted 26 lines
-----Original Message-----
From: Gui Jianfeng [mailto:[email protected]]
Sent: Thursday, October 28, 2010 10:55 AM
To: Garrett Cooper
Cc: [email protected]; [email protected]
Subject: [PATCH] Fix all tests pass error
ret_codecomes from "set +x" which always return 0, this makes all tests PASS.
Actually, "set +x" isn't needed here, just get rid of it.Signed-off-by Gui Jianfeng <[email protected]>---
testcases/open_posix_testsuite/bin/run-tests.sh | 2 --1 files changed, 0 insertions(+), 2 deletions(-)testcases/open_posix_testsuite/bin/run-tests.sh +0
-0@@ -48,8 +48,6 @@ run_test() {sh -c "$SCRIPT_DIR/t0 $TIMEOUT_VAL ./$1 $(cat ./$(echo "$1" | sed 's,\.[^\.]*,,').args 2>/dev/null)" > $complog 2>&1
Quoted 7 lines
- set +x
-
ret_code=$?if [ "$ret_code" = "0" ]; then
--
1.7.0.4Great!
Quoted 2 lines
I was forestalled :)
I have the same opinion, too.
Fixed -- thanks :/...
-Garrett
------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest Create new apps & games for the Nokia N8 for consumers in U.S. and Canada $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list