Skip to contentSkip to conversation

Add device drivers (GbE, Packet Hub) for Topcliff

PATCH In review Masayuki Ohtake 3 participants 4 messages Apr 16, 2010 – Apr 19, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add device drivers (GbE, Packet Hub) for Topcliff

I developed the device drivers for Linux kernel 2.6.33-1. This time, I added the following drivers
- GbE device
- Packet HUB device

Would you check them?

The patch is uploaded to our WEB site in Sourceforge.net, Because the patch size was large.

[Our WEB site in Sourceforge.net.]
http://sourceforge.net/projects/generalembedded/files/
"All Files" -> "Downloads" -> "Dev" -> "kernel 2.6.33-1"
- pch_gbe.patch (for GbE device)
- pch_phub.patch (for Packet HUB device)

[About our development product]
Topcliff is a chip that has many peripherals.
The chip has UART, I2C, SPI, IEEE1588, CAN, Packet HUB, SATA, USB host, USB device, SDIO, Gigabit Ethernet, GPIO and DMA.

Best regards,

#1 lore raw
Quoted 6 lines · On Fri, 16 Apr 2010 19:09:04 +0900 "Masayuki Ohtake"…

I developed the device drivers for Linux kernel 2.6.33-1. This time, I added the following drivers
- GbE device
- Packet HUB device

Would you check them?

Thanks for making your code available. May I suggest, though, that you will get a much better response if you post the patches directly to the mailing list? That is how our process works; it is simply harder to review code if you have to do digging through web sites to find it.

Networking-specific patches should be posted to the netdev list as well.

More information on how to post code for review can be found in the kernel source tree:

Documentation/HOWTO
Documentation/development-process

Thanks,

jon

#2 lore raw

Hi jon,
Thanks for your suggestion again.
I joined the netdev and send my patch to "netdev <[email protected]>".

--
Hello netdev users,

I developed the device drivers for Linux kernel 2.6.33-1. This time, I added the following drivers
- GbE device
- Packet HUB device

The GbE and Packet Hub device drivers are related with each other. Because I send patch to LKML <[email protected]> and the netdev <[email protected]> mailing list.

Would you check them?

The patch is uploaded to our WEB site in Sourceforge.net, Because the patch size was large.

[Our WEB site in Sourceforge.net.]
http://sourceforge.net/projects/generalembedded/files/
"All Files" -> "Downloads" -> "Dev" -> "kernel 2.6.33-1"
- pch_gbe.patch (for GbE device)
- pch_phub.patch (for Packet HUB device)

[About our development product]
Topcliff is a chip that has many peripherals.
The chip has UART, I2C, SPI, IEEE1588, CAN, Packet HUB, SATA, USB host, USB device, SDIO, Gigabit Ethernet, GPIO and DMA.

Best regards,
Masayuki Ohtake <[email protected]>
----- Original Message -----
From: "Jonathan Corbet" <[email protected]>
To: "Masayuki Ohtake" <[email protected]>
Cc: "LKML" <[email protected]>; "Intel OTC" <[email protected]>; <[email protected]>
Sent: Friday, April 16, 2010 11:35 PM
Subject: Re: [PATCH]Add device drivers (GbE, Packet Hub) for Topcliff

Quoted 27 lines
Quoted 6 lines · On Fri, 16 Apr 2010 19:09:04 +0900 "Masayuki Ohtake"…

I developed the device drivers for Linux kernel 2.6.33-1. This time, I added the following drivers
- GbE device
- Packet HUB device

Would you check them?

Thanks for making your code available. May I suggest, though, that you will get a much better response if you post the patches directly to the mailing list? That is how our process works; it is simply harder to review code if you have to do digging through web sites to find it.

Networking-specific patches should be posted to the netdev list as well.

More information on how to post code for review can be found in the kernel source tree:

Documentation/HOWTO
Documentation/development-process

Thanks,

jon

#3 lore raw
Quoted 12 lines · Masayuki Ohtake

Hi jon,
Thanks for your suggestion again.
I joined the netdev and send my patch to "netdev <[email protected]>".

--
Hello netdev users,

I developed the device drivers for Linux kernel 2.6.33-1. This time, I added the following drivers
- GbE device
- Packet HUB device

Quoted 8 lines

The GbE and Packet Hub device drivers are related with each other. Because I send patch to LKML <[email protected]> and the netdev <[email protected]> mailing list.

Would you check them?

The patch is uploaded to our WEB site in Sourceforge.net, Because the patch size was large.

[...]

Patches must be sent directly to the list for review, with few exceptions.

The size limit for the list is 100 K. Given that none of your source files are this larger, you should be able to split pch_gbe.patch into 3 or more groups of source files, each within this limit. The changes to drivers/net/Kconfig and drivers/net/Makefile should be in the last part.

Ben.

Signature · 3 lines
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.