regulator: ab3100: use devm_regulator_register()
Subsystems (4)
PATCH 1/20 regulator: ab3100: use devm_regulator_register()
Use devm_regulator_register() to make cleanup paths simpler.
--- drivers/regulator/ab3100.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/regulator/ab3100.c +1 -2
@@ -535,7 +535,7 @@ static int ab3100_regulator_register(struct platform_device *pdev, config.dev = &pdev->dev; config.driver_data = reg; - rdev =regulator_register (desc, &config); + rdev =devm_regulator_register (&pdev->dev, desc, &config);if (IS_ERR (rdev)) { err =PTR_ERR (rdev); dev_err(&pdev->dev,
@@ -616,7 +616,6 @@ static int ab3100_regulators_remove(struct platform_device *pdev)for (i =0 ; i <AB3100_NUM_REGULATORS ; i++) {struct ab3100_regulator *reg = &ab3100_regulators[i]; -regulator_unregister (reg->rdev); reg->rdev =NULL ; }return 0 ;
Signature · 1 line
1.7.10.4
PATCH 2/20 regulator: ab8500: use devm_regulator_register()
Use devm_regulator_register() to make cleanup paths simpler.
--- drivers/regulator/ab8500.c | 20 +++----------------- 1 file changed, 3 insertions(+), 17 deletions(-)
drivers/regulator/ab8500.c +3 -17
@@ -3058,16 +3058,12 @@ static int ab8500_regulator_register(struct platform_device *pdev, }/* register regulator with framework */ - info->regulator =regulator_register (&info->desc, &config); + info->regulator =devm_regulator_register (&pdev->dev, &info->desc, + &config);if (IS_ERR (info->regulator)) { err =PTR_ERR (info->regulator);dev_err (&pdev->dev,"failed to register regulator %s\n" , info->desc.name); -/* when we fail, un-register all earlier regulators */ -while (--id >=0 ) { - info = &abx500_regulator.info[id]; -regulator_unregister (info->regulator); - }return err; }
@@ -3172,17 +3168,7 @@ static int ab8500_regulator_probe(struct platform_device *pdev)static int ab8500_regulator_remove (struct platform_device *pdev) { -int i, err; - -for (i =0 ; i < abx500_regulator.info_size; i++) { -struct ab8500_regulator_info *info =NULL ; - info = &abx500_regulator.info[i]; - -dev_vdbg (rdev_get_dev (info->regulator), -"%s-remove\n" , info->desc.name); - -regulator_unregister (info->regulator); - } +int err;/* remove regulator debug */ err =ab8500_regulator_debug_exit (pdev);
Signature · 1 line
1.7.10.4
Re: [PATCH 02/20] regulator: ab8500: use devm_regulator_register()
Quoted 5 lines · Jingoo Han
Use
devm_regulator_register()to make cleanup paths simpler.drivers/regulator/ab8500.c +0
-3-for (i =0 ; i < abx500_regulator.info_size; i++) { -struct ab8500_regulator_info *info =NULL ; - info = &abx500_regulator.info[i];
drivers/regulator/ab8500.c static int ab8500_regulator_probe(struct platform_device *pdev) · line 3174
Quoted 10 lines
drivers/regulator/ab8500.c +1
-6- -dev_vdbg (rdev_get_dev (info->regulator), -"%s-remove\n" , info->desc.name); - -regulator_unregister (info->regulator); - } +int err;/* remove regulator debug */ err =ab8500_regulator_debug_exit (pdev);
Wouldn't re-ordering (unregistering after ab8500_regulator_debug_exit) cause any problems here ?
Signature · 2 lines
With warm regards, Sachin
Re: [PATCH 02/20] regulator: ab8500: use devm_regulator_register()
Quoted 14 lines · Sachin Kamat
Quoted 13 lines · Jingoo Han
Use
devm_regulator_register()to make cleanup paths simpler.drivers/regulator/ab8500.c +1
-9-for (i =0 ; i < abx500_regulator.info_size; i++) { -struct ab8500_regulator_info *info =NULL ; - info = &abx500_regulator.info[i]; - -dev_vdbg (rdev_get_dev (info->regulator), -"%s-remove\n" , info->desc.name); - -regulator_unregister (info->regulator); - } +int err;
Quoted 6 lines
Quoted 2 lines
/* remove regulator debug */ err = ab8500_regulator_debug_exit(pdev);Wouldn't re-ordering (unregistering after
ab8500_regulator_debug_exit) cause any problems here ?
OK, I see.
There is no ab8500_regulator_debug_exit() in the current kernel. However, in my opinion, ab8500_regulator_debug_exit() should be called, after regulator_unregister() is called.
I will remove this patch from next V2 patch series. Thank you.
Bengt Jonsson,
If I am wrong, please let me know kindly. :-)
Best regards,
Jingoo Han
PATCH 3/20 regulator: ab8500-ext: use devm_regulator_register()
In reply to Jingoo HanUse devm_regulator_register() to make cleanup paths simpler, and remove unnecessary remove().
--- drivers/regulator/ab8500-ext.c | 26 ++------------------------ 1 file changed, 2 insertions(+), 24 deletions(-)
drivers/regulator/ab8500-ext.c +2 -24
@@ -413,16 +413,12 @@ static int ab8500_ext_regulator_probe(struct platform_device *pdev) &pdata->ext_regulator[i];/* register regulator with framework */ - info->rdev =regulator_register (&info->desc, &config); + info->rdev =devm_regulator_register (&pdev->dev, &info->desc, + &config);if (IS_ERR (info->rdev)) { err =PTR_ERR (info->rdev);dev_err (&pdev->dev,"failed to register regulator %s\n" , info->desc.name); -/* when we fail, un-register all earlier regulators */ -while (--i >=0 ) { - info = &ab8500_ext_regulator_info[i]; -regulator_unregister (info->rdev); - }return err; }
@@ -433,26 +429,8 @@ static int ab8500_ext_regulator_probe(struct platform_device *pdev)return 0 ; } -static int ab8500_ext_regulator_remove (struct platform_device *pdev) -{ -int i; - -for (i =0 ; i <ARRAY_SIZE (ab8500_ext_regulator_info); i++) { -struct ab8500_ext_regulator_info *info =NULL ; - info = &ab8500_ext_regulator_info[i]; - -dev_vdbg (rdev_get_dev (info->rdev), -"%s-remove\n" , info->desc.name); - -regulator_unregister (info->rdev); - } - -return 0 ; -} -static struct platform_driver ab8500_ext_regulator_driver = { .probe = ab8500_ext_regulator_probe, - .remove = ab8500_ext_regulator_remove, .driver = { .name ="ab8500-ext-regulator" , .owner =THIS_MODULE ,
Signature · 1 line
1.7.10.4
PATCH 4/20 regulator: da9063: use devm_regulator_register()
In reply to Jingoo HanUse devm_regulator_register() to make cleanup paths simpler.
--- drivers/regulator/da9063-regulator.c | 21 ++++----------------- 1 file changed, 4 insertions(+), 17 deletions(-)
drivers/regulator/da9063-regulator.c +4 -17
@@ -847,13 +847,13 @@ static int da9063_regulator_probe(struct platform_device *pdev)if (da9063_reg_matches) config.of_node = da9063_reg_matches[id].of_node; config.regmap = da9063->regmap; - regl->rdev =regulator_register (®l->desc, &config); + regl->rdev =devm_regulator_register (&pdev->dev, ®l->desc, + &config);if (IS_ERR (regl->rdev)) {dev_err (&pdev->dev,"Failed to register %s regulator\n" , regl->desc.name); - ret =PTR_ERR (regl->rdev); - goto err; +return PTR_ERR (regl->rdev); } id++; n++;
@@ -862,9 +862,8 @@ static int da9063_regulator_probe(struct platform_device *pdev)/* LDOs overcurrent event support */ irq =platform_get_irq_byname (pdev,"LDO_LIM" );if (irq <0 ) { - ret = irq;dev_err (&pdev->dev,"Failed to get IRQ.\n" ); - goto err; +return irq; } regulators->irq_ldo_lim =regmap_irq_get_virq (da9063->regmap_irq, irq);
@@ -881,27 +880,15 @@ static int da9063_regulator_probe(struct platform_device *pdev) }return 0 ; - -err: -/* Wind back regulators registeration */ -while (--n >=0 ) -regulator_unregister (regulators->regulator[n].rdev); - -return ret; }static int da9063_regulator_remove (struct platform_device *pdev) {struct da9063_regulators *regulators =platform_get_drvdata (pdev); -struct da9063_regulator *regl;free_irq (regulators->irq_ldo_lim, regulators);free_irq (regulators->irq_uvov, regulators); -for (regl = ®ulators->regulator[regulators->n_regulators -1 ]; - regl >= ®ulators->regulator[0 ]; regl--) -regulator_unregister (regl->rdev); -return 0 ; }
Signature · 1 line
1.7.10.4
PATCH 5/20 regulator: da9210: use devm_regulator_register()
In reply to Jingoo HanUse devm_regulator_register() to make cleanup paths simpler, and remove unnecessary remove().
--- drivers/regulator/da9210-regulator.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)
drivers/regulator/da9210-regulator.c +1 -9
@@ -152,7 +152,7 @@ static int da9210_i2c_probe(struct i2c_client *i2c, config.driver_data = chip; config.regmap = chip->regmap; - rdev =regulator_register (&da9210_reg, &config); + rdev =devm_regulator_register (&i2c->dev, &da9210_reg, &config);if (IS_ERR (rdev)) {dev_err (&i2c->dev,"Failed to register DA9210 regulator\n" );return PTR_ERR (rdev);
@@ -165,13 +165,6 @@ static int da9210_i2c_probe(struct i2c_client *i2c,return 0 ; } -static int da9210_i2c_remove (struct i2c_client *i2c) -{ -struct da9210 *chip =i2c_get_clientdata (i2c); -regulator_unregister (chip->rdev); -return 0 ; -} -static const struct i2c_device_id da9210_i2c_id[] = { {"da9210" ,0 }, {},
@@ -185,7 +178,6 @@ static struct i2c_driver da9210_regulator_driver = { .owner = THIS_MODULE, }, .probe = da9210_i2c_probe, - .remove = da9210_i2c_remove, .id_table = da9210_i2c_id, };
Signature · 1 line
1.7.10.4
PATCH 6/20 regulator: fixed: use devm_regulator_register()
In reply to Jingoo HanUse devm_regulator_register() to make cleanup paths simpler.
--- drivers/regulator/fixed.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/regulator/fixed.c +2 -2
@@ -188,7 +188,8 @@ static int reg_fixed_voltage_probe(struct platform_device *pdev) cfg.driver_data = drvdata; cfg.of_node = pdev->dev.of_node; - drvdata->dev =regulator_register (&drvdata->desc, &cfg); + drvdata->dev =devm_regulator_register (&pdev->dev, &drvdata->desc, + &cfg);if (IS_ERR (drvdata->dev)) { ret =PTR_ERR (drvdata->dev);dev_err (&pdev->dev,"Failed to register regulator: %d\n" , ret);
@@ -214,7 +215,6 @@ static int reg_fixed_voltage_remove(struct platform_device *pdev) {struct fixed_voltage_data *drvdata =platform_get_drvdata (pdev); -regulator_unregister (drvdata->dev);kfree (drvdata->desc.supply_name);kfree (drvdata->desc.name);
Signature · 1 line
1.7.10.4
PATCH 7/20 regulator: gpio-regulator: use devm_regulator_register()
In reply to Jingoo HanUse devm_regulator_register() to make cleanup paths simpler.
--- drivers/regulator/gpio-regulator.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/regulator/gpio-regulator.c +2 -3
@@ -322,7 +322,8 @@ static int gpio_regulator_probe(struct platform_device *pdev) cfg.ena_gpio_flags |=GPIOF_OUT_INIT_HIGH ; } - drvdata->dev =regulator_register (&drvdata->desc, &cfg); + drvdata->dev =devm_regulator_register (&pdev->dev, &drvdata->desc, + &cfg);if (IS_ERR (drvdata->dev)) { ret =PTR_ERR (drvdata->dev);dev_err (&pdev->dev,"Failed to register regulator: %d\n" , ret);
@@ -349,8 +350,6 @@ static int gpio_regulator_remove(struct platform_device *pdev) {struct gpio_regulator_data *drvdata =platform_get_drvdata (pdev); -regulator_unregister (drvdata->dev); -gpio_free_array (drvdata->gpios, drvdata->nr_gpios);kfree (drvdata->states);
Signature · 1 line
1.7.10.4
PATCH 8/20 regulator: lp3971: use devm_regulator_register()
In reply to Jingoo HanUse devm_regulator_register() to make cleanup paths simpler.
--- drivers/regulator/lp3971.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-)
drivers/regulator/lp3971.c +3 -8
@@ -400,8 +400,9 @@ static int setup_regulators(struct lp3971 *lp3971, config.init_data = reg->initdata; config.driver_data = lp3971; - lp3971->rdev[i] =regulator_register (®ulators[reg->id], - &config); + lp3971->rdev[i] =devm_regulator_register (lp3971->dev, + ®ulators[reg->id], + &config);if (IS_ERR (lp3971->rdev[i])) { err =PTR_ERR (lp3971->rdev[i]); dev_err(lp3971->dev, "regulator init failed: %d\n",
@@ -413,8 +414,6 @@ static int setup_regulators(struct lp3971 *lp3971,return 0 ; error: -while (--i >=0 ) -regulator_unregister (lp3971->rdev[i]);kfree (lp3971->rdev); lp3971->rdev =NULL ; err_nomem:
@@ -463,10 +462,6 @@ static int lp3971_i2c_probe(struct i2c_client *i2c,static int lp3971_i2c_remove (struct i2c_client *i2c) {struct lp3971 *lp3971 =i2c_get_clientdata (i2c); -int i; - -for (i =0 ; i < lp3971->num_regulators; i++) -regulator_unregister (lp3971->rdev[i]);kfree (lp3971->rdev);
Signature · 1 line
1.7.10.4
PATCH 9/20 regulator: lp3972: use devm_regulator_register()
In reply to Jingoo HanUse devm_regulator_register() to make cleanup paths simpler.
--- drivers/regulator/lp3972.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
drivers/regulator/lp3972.c +3 -7
@@ -495,8 +495,9 @@ static int setup_regulators(struct lp3972 *lp3972, config.init_data = reg->initdata; config.driver_data = lp3972; - lp3972->rdev[i] =regulator_register (®ulators[reg->id], - &config); + lp3972->rdev[i] =devm_regulator_register (lp3972->dev, + ®ulators[reg->id], + &config);if (IS_ERR (lp3972->rdev[i])) { err =PTR_ERR (lp3972->rdev[i]); dev_err(lp3972->dev, "regulator init failed: %d\n",
@@ -507,8 +508,6 @@ static int setup_regulators(struct lp3972 *lp3972,return 0 ; error: -while (--i >=0 ) -regulator_unregister (lp3972->rdev[i]);kfree (lp3972->rdev); lp3972->rdev =NULL ; err_nomem:
@@ -560,10 +559,7 @@ static int lp3972_i2c_probe(struct i2c_client *i2c,static int lp3972_i2c_remove (struct i2c_client *i2c) {struct lp3972 *lp3972 =i2c_get_clientdata (i2c); -int i; -for (i =0 ; i < lp3972->num_regulators; i++) -regulator_unregister (lp3972->rdev[i]);kfree (lp3972->rdev);return 0 ;
Signature · 1 line
1.7.10.4
Re: [PATCH 09/20] regulator: lp3972: use devm_regulator_register()
drivers/regulator/lp3972.c static int lp3972_i2c_probe(struct i2c_client *i2c, · line 563
Quoted 10 lines · Jingoo Han
Use
devm_regulator_register()to make cleanup paths simpler.static int
lp3972_i2c_remove(struct i2c_client *i2c){ struct lp3972 *lp3972 = i2c_get_clientdata(i2c);drivers/regulator/lp3972.c +0
-3-int i; -for (i =0 ; i < lp3972->num_regulators; i++) -regulator_unregister (lp3972->rdev[i]);kfree (lp3972->rdev);
With devm the unregister would happen after the freeing of the device. Wouldn't this re-ordering cause any
problems?
Signature · 2 lines
With warm regards, Sachin
Re: [PATCH 09/20] regulator: lp3972: use devm_regulator_register()
Quoted 8 lines · Sachin Kamat
Quoted 7 lines · Jingoo Han
Use
devm_regulator_register()to make cleanup paths simpler.static int
lp3972_i2c_remove(struct i2c_client *i2c){ struct lp3972 *lp3972 = i2c_get_clientdata(i2c);- int i;
Quoted 7 lines
drivers/regulator/lp3972.c static int lp3972_i2c_probe(struct i2c_client *i2c, · line 563
Quoted 3 lines
drivers/regulator/lp3972.c +0
-2-for (i =0 ; i < lp3972->num_regulators; i++) -regulator_unregister (lp3972->rdev[i]);kfree (lp3972->rdev);With devm the unregister would happen after the freeing of the device. Wouldn't this re-ordering cause any
problems?
It seems to make the problem.
I will remove this patch from next V2 patch series. Thank you.
Best regards,
Jingoo Han
PATCH 10/20 regulator: lp872x: use devm_regulator_register()
In reply to Jingoo HanUse devm_regulator_register() to make cleanup paths simpler, and remove unnecessary remove().
--- drivers/regulator/lp872x.c | 33 +++------------------------------ 1 file changed, 3 insertions(+), 30 deletions(-)
drivers/regulator/lp872x.c +3 -30
@@ -785,7 +785,7 @@ static int lp872x_regulator_register(struct lp872x *lp)struct regulator_desc *desc;struct regulator_config cfg = { };struct regulator_dev *rdev; -int i, ret; +int i;for (i =0 ; i < lp->num_regulators; i++) { desc = (lp->chipid == LP8720) ? &lp8720_regulator_desc[i] :
@@ -796,34 +796,16 @@ static int lp872x_regulator_register(struct lp872x *lp) cfg.driver_data = lp; cfg.regmap = lp->regmap; - rdev =regulator_register (desc, &cfg); + rdev =devm_regulator_register (lp->dev, desc, &cfg);if (IS_ERR (rdev)) {dev_err (lp->dev,"regulator register err" ); - ret =PTR_ERR (rdev); - goto err; +return PTR_ERR (rdev); } *(lp->regulators + i) = rdev; }return 0 ; -err: -while (--i >=0 ) { - rdev = *(lp->regulators + i); -regulator_unregister (rdev); - } -return ret; -} - -static void lp872x_regulator_unregister (struct lp872x *lp) -{ -struct regulator_dev *rdev; -int i; - -for (i =0 ; i < lp->num_regulators; i++) { - rdev = *(lp->regulators + i); -regulator_unregister (rdev); - } }static const struct regmap_config lp872x_regmap_config = {
@@ -979,14 +961,6 @@ err_dev:return ret; } -static int lp872x_remove (struct i2c_client *cl) -{ -struct lp872x *lp =i2c_get_clientdata (cl); - -lp872x_regulator_unregister (lp); -return 0 ; -} -static const struct of_device_id lp872x_dt_ids[] = { { .compatible ="ti,lp8720" , }, { .compatible ="ti,lp8725" , },
@@ -1008,7 +982,6 @@ static struct i2c_driver lp872x_driver = { .of_match_table = of_match_ptr(lp872x_dt_ids), }, .probe = lp872x_probe, - .remove = lp872x_remove, .id_table = lp872x_ids, };
Signature · 1 line
1.7.10.4
PATCH 11/20 regulator: lp8788-buck: use devm_regulator_register()
In reply to Jingoo HanUse devm_regulator_register() to make cleanup paths simpler, and remove unnecessary remove().
--- drivers/regulator/lp8788-buck.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-)
drivers/regulator/lp8788-buck.c +1 -11
@@ -515,7 +515,7 @@ static int lp8788_buck_probe(struct platform_device *pdev) cfg.driver_data = buck; cfg.regmap = lp->regmap; - rdev =regulator_register (&lp8788_buck_desc[id], &cfg); + rdev =devm_regulator_register (&pdev->dev, &lp8788_buck_desc[id], &cfg);if (IS_ERR (rdev)) { ret =PTR_ERR (rdev); dev_err(&pdev->dev, "BUCK%d regulator register err = %d\n",
@@ -529,18 +529,8 @@ static int lp8788_buck_probe(struct platform_device *pdev)return 0 ; } -static int lp8788_buck_remove (struct platform_device *pdev) -{ -struct lp8788_buck *buck =platform_get_drvdata (pdev); - -regulator_unregister (buck->regulator); - -return 0 ; -} -static struct platform_driver lp8788_buck_driver = { .probe = lp8788_buck_probe, - .remove = lp8788_buck_remove, .driver = { .name =LP8788_DEV_BUCK , .owner =THIS_MODULE ,
Signature · 1 line
1.7.10.4
PATCH 12/20 regulator: lp8788-ldo: use devm_regulator_register()
In reply to Jingoo HanUse devm_regulator_register() to make cleanup paths simpler, and remove unnecessary remove().
--- drivers/regulator/lp8788-ldo.c | 24 ++---------------------- 1 file changed, 2 insertions(+), 22 deletions(-)
drivers/regulator/lp8788-ldo.c +2 -22
@@ -543,7 +543,7 @@ static int lp8788_dldo_probe(struct platform_device *pdev) cfg.driver_data = ldo; cfg.regmap = lp->regmap; - rdev =regulator_register (&lp8788_dldo_desc[id], &cfg); + rdev =devm_regulator_register (&pdev->dev, &lp8788_dldo_desc[id], &cfg);if (IS_ERR (rdev)) { ret =PTR_ERR (rdev); dev_err(&pdev->dev, "DLDO%d regulator register err = %d\n",
@@ -557,18 +557,8 @@ static int lp8788_dldo_probe(struct platform_device *pdev)return 0 ; } -static int lp8788_dldo_remove (struct platform_device *pdev) -{ -struct lp8788_ldo *ldo =platform_get_drvdata (pdev); - -regulator_unregister (ldo->regulator); - -return 0 ; -} -static struct platform_driver lp8788_dldo_driver = { .probe = lp8788_dldo_probe, - .remove = lp8788_dldo_remove, .driver = { .name =LP8788_DEV_DLDO , .owner =THIS_MODULE ,
@@ -603,7 +593,7 @@ static int lp8788_aldo_probe(struct platform_device *pdev) cfg.driver_data = ldo; cfg.regmap = lp->regmap; - rdev =regulator_register (&lp8788_aldo_desc[id], &cfg); + rdev =devm_regulator_register (&pdev->dev, &lp8788_aldo_desc[id], &cfg);if (IS_ERR (rdev)) { ret =PTR_ERR (rdev); dev_err(&pdev->dev, "ALDO%d regulator register err = %d\n",
@@ -617,18 +607,8 @@ static int lp8788_aldo_probe(struct platform_device *pdev)return 0 ; } -static int lp8788_aldo_remove (struct platform_device *pdev) -{ -struct lp8788_ldo *ldo =platform_get_drvdata (pdev); - -regulator_unregister (ldo->regulator); - -return 0 ; -} -static struct platform_driver lp8788_aldo_driver = { .probe = lp8788_aldo_probe, - .remove = lp8788_aldo_remove, .driver = { .name =LP8788_DEV_ALDO , .owner =THIS_MODULE ,
Signature · 1 line
1.7.10.4
PATCH 13/20 regulator: max8925: use devm_regulator_register()
In reply to Jingoo HanUse devm_regulator_register() to make cleanup paths simpler, and remove unnecessary remove().
--- drivers/regulator/max8925-regulator.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-)
drivers/regulator/max8925-regulator.c +1 -11
@@ -312,7 +312,7 @@ static int max8925_regulator_probe(struct platform_device *pdev)if (pdata) config.init_data = pdata; - rdev =regulator_register (&ri->desc, &config); + rdev =devm_regulator_register (&pdev->dev, &ri->desc, &config);if (IS_ERR (rdev)) {dev_err (&pdev->dev,"failed to register regulator %s\n" , ri->desc.name);
@@ -323,22 +323,12 @@ static int max8925_regulator_probe(struct platform_device *pdev)return 0 ; } -static int max8925_regulator_remove (struct platform_device *pdev) -{ -struct regulator_dev *rdev =platform_get_drvdata (pdev); - -regulator_unregister (rdev); - -return 0 ; -} -static struct platform_driver max8925_regulator_driver = { .driver = { .name ="max8925-regulator" , .owner =THIS_MODULE , }, .probe = max8925_regulator_probe, - .remove = max8925_regulator_remove, };static int __init max8925_regulator_init (void )
Signature · 1 line
1.7.10.4
PATCH 14/20 regulator: max8952: use devm_regulator_register()
In reply to Jingoo HanUse devm_regulator_register() to make cleanup paths simpler.
--- drivers/regulator/max8952.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/regulator/max8952.c +2 -4
@@ -231,7 +231,8 @@ static int max8952_pmic_probe(struct i2c_client *client,if (pdata->reg_data->constraints.boot_on) config.ena_gpio_flags |=GPIOF_OUT_INIT_HIGH ; - max8952->rdev =regulator_register (®ulator, &config); + max8952->rdev =devm_regulator_register (&client->dev, ®ulator, + &config);if (IS_ERR (max8952->rdev)) { ret =PTR_ERR (max8952->rdev);
@@ -321,9 +322,6 @@ static int max8952_pmic_remove(struct i2c_client *client) {struct max8952_data *max8952 =i2c_get_clientdata (client);struct max8952_platform_data *pdata = max8952->pdata; -struct regulator_dev *rdev = max8952->rdev; - -regulator_unregister (rdev);gpio_free (pdata->gpio_vid0);gpio_free (pdata->gpio_vid1);
Signature · 1 line
1.7.10.4
PATCH 15/20 regulator: pcap: use devm_regulator_register()
In reply to Jingoo HanUse devm_regulator_register() to make cleanup paths simpler, and remove unnecessary remove().
--- drivers/regulator/pcap-regulator.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-)
drivers/regulator/pcap-regulator.c +2 -11
@@ -246,7 +246,8 @@ static int pcap_regulator_probe(struct platform_device *pdev) config.init_data =dev_get_platdata (&pdev->dev); config.driver_data = pcap; - rdev =regulator_register (&pcap_regulators[pdev->id], &config); + rdev =devm_regulator_register (&pdev->dev, &pcap_regulators[pdev->id], + &config);if (IS_ERR (rdev))return PTR_ERR (rdev);
@@ -255,22 +256,12 @@ static int pcap_regulator_probe(struct platform_device *pdev)return 0 ; } -static int pcap_regulator_remove (struct platform_device *pdev) -{ -struct regulator_dev *rdev =platform_get_drvdata (pdev); - -regulator_unregister (rdev); - -return 0 ; -} -static struct platform_driver pcap_regulator_driver = { .driver = { .name ="pcap-regulator" , .owner =THIS_MODULE , }, .probe = pcap_regulator_probe, - .remove = pcap_regulator_remove, };static int __init pcap_regulator_init (void )
Signature · 1 line
1.7.10.4
PATCH 16/20 regulator: pcf50633: use devm_regulator_register()
In reply to Jingoo HanUse devm_regulator_register() to make cleanup paths simpler, and remove unnecessary remove().
--- drivers/regulator/pcf50633-regulator.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-)
drivers/regulator/pcf50633-regulator.c +2 -11
@@ -90,7 +90,8 @@ static int pcf50633_regulator_probe(struct platform_device *pdev) config.driver_data = pcf; config.regmap = pcf->regmap; - rdev =regulator_register (®ulators[pdev->id], &config); + rdev =devm_regulator_register (&pdev->dev, ®ulators[pdev->id], + &config);if (IS_ERR (rdev))return PTR_ERR (rdev);
@@ -102,21 +103,11 @@ static int pcf50633_regulator_probe(struct platform_device *pdev)return 0 ; } -static int pcf50633_regulator_remove (struct platform_device *pdev) -{ -struct regulator_dev *rdev =platform_get_drvdata (pdev); - -regulator_unregister (rdev); - -return 0 ; -} -static struct platform_driver pcf50633_regulator_driver = { .driver = { .name ="pcf50633-regltr" , }, .probe = pcf50633_regulator_probe, - .remove = pcf50633_regulator_remove, };static int __init pcf50633_regulator_init (void )
Signature · 1 line
1.7.10.4
PATCH 17/20 regulator: tps6105x: use devm_regulator_register()
In reply to Jingoo HanUse devm_regulator_register() to make cleanup paths simpler, and remove unnecessary remove().
--- drivers/regulator/tps6105x-regulator.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-)
drivers/regulator/tps6105x-regulator.c +3 -10
@@ -146,8 +146,9 @@ static int tps6105x_regulator_probe(struct platform_device *pdev) config.driver_data = tps6105x;/* Register regulator with framework */ - tps6105x->regulator =regulator_register (&tps6105x_regulator_desc, - &config); + tps6105x->regulator =devm_regulator_register (&pdev->dev, + &tps6105x_regulator_desc, + &config);if (IS_ERR (tps6105x->regulator)) { ret =PTR_ERR (tps6105x->regulator); dev_err(&tps6105x->client->dev,
@@ -159,20 +160,12 @@ static int tps6105x_regulator_probe(struct platform_device *pdev)return 0 ; } -static int tps6105x_regulator_remove (struct platform_device *pdev) -{ -struct tps6105x *tps6105x =dev_get_platdata (&pdev->dev); -regulator_unregister (tps6105x->regulator); -return 0 ; -} -static struct platform_driver tps6105x_regulator_driver = { .driver = { .name ="tps6105x-regulator" , .owner =THIS_MODULE , }, .probe = tps6105x_regulator_probe, - .remove = tps6105x_regulator_remove, };static __init int tps6105x_regulator_init (void )
Signature · 1 line
1.7.10.4
Re: [PATCH 17/20] regulator: tps6105x: use devm_regulator_register()
Quoted 4 lines · Jingoo Han
Use
devm_regulator_register()to make cleanup paths simpler, and remove unnecessaryremove().Signed-off-by Jingoo Han <[email protected]>
Yours,
Linus Walleij
PATCH 18/20 regulator: tps6524x: use devm_regulator_register()
In reply to Jingoo HanUse devm_regulator_register() to make cleanup paths simpler.
--- drivers/regulator/tps6524x-regulator.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/regulator/tps6524x-regulator.c +3 -4
@@ -584,10 +584,8 @@ static int pmic_remove(struct spi_device *spi)if (!hw)return 0 ; -for (i =0 ; i <N_REGULATORS ; i++) { -regulator_unregister (hw->rdev[i]); +for (i =0 ; i <N_REGULATORS ; i++) hw->rdev[i] =NULL ; - }return 0 ; }
@@ -631,7 +629,8 @@ static int pmic_probe(struct spi_device *spi) config.init_data = init_data; config.driver_data = hw; - hw->rdev[i] =regulator_register (&hw->desc[i], &config); + hw->rdev[i] =devm_regulator_register (dev, &hw->desc[i], + &config);if (IS_ERR (hw->rdev[i])) { ret =PTR_ERR (hw->rdev[i]); hw->rdev[i] =NULL ;
Signature · 1 line
1.7.10.4
PATCH 19/20 regulator: twl: use devm_regulator_register()
In reply to Jingoo HanUse devm_regulator_register() to make cleanup paths simpler.
--- drivers/regulator/twl-regulator.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/regulator/twl-regulator.c +1 -2
@@ -1188,7 +1188,7 @@ static int twlreg_probe(struct platform_device *pdev) config.driver_data = info; config.of_node = pdev->dev.of_node; - rdev =regulator_register (&info->desc, &config); + rdev =devm_regulator_register (&pdev->dev, &info->desc, &config);if (IS_ERR (rdev)) {dev_err (&pdev->dev,"can't register %s, %ld\n" , info->desc.name,PTR_ERR (rdev));
@@ -1217,7 +1217,6 @@ static int twlreg_remove(struct platform_device *pdev)struct regulator_dev *rdev =platform_get_drvdata (pdev);struct twlreg_info *info = rdev->reg_data; -regulator_unregister (rdev);kfree (info);return 0 ; }
Signature · 1 line
1.7.10.4
Re: [PATCH 19/20] regulator: twl: use devm_regulator_register()
Quoted 32 lines · Jingoo Han
Use
devm_regulator_register()to make cleanup paths simpler.Signed-off-by Jingoo Han <[email protected]>--- drivers/regulator/twl-regulator.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/regulator/twl-regulator.c +1
-2@@ -1188,7 +1188,7 @@ static int twlreg_probe(struct platform_device *pdev) config.driver_data = info; config.of_node = pdev->dev.of_node; - rdev =regulator_register (&info->desc, &config); + rdev =devm_regulator_register (&pdev->dev, &info->desc, &config);if (IS_ERR (rdev)) {dev_err (&pdev->dev,"can't register %s, %ld\n" , info->desc.name,PTR_ERR (rdev));@@ -1217,7 +1217,6 @@ static int twlreg_remove(struct platform_device *pdev)struct regulator_dev *rdev =platform_get_drvdata (pdev);struct twlreg_info *info = rdev->reg_data; -regulator_unregister (rdev);kfree (info);return 0 ; }Signature · 1 line
1.7.10.4
Signature · 2 lines
Regards, Nishanth Menon
PATCH 20/20 regulator: vexpress: use devm_regulator_register()
In reply to Jingoo HanUse devm_regulator_register() to make cleanup paths simpler.
--- drivers/regulator/vexpress.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/regulator/vexpress.c +1 -2
@@ -96,7 +96,7 @@ static int vexpress_regulator_probe(struct platform_device *pdev) config.driver_data = reg; config.of_node = pdev->dev.of_node; - reg->regdev =regulator_register (®->desc, &config); + reg->regdev =devm_regulator_register (&pdev->dev, ®->desc, &config);if (IS_ERR (reg->regdev)) { err =PTR_ERR (reg->regdev); goto error_regulator_register;
@@ -119,7 +119,6 @@ static int vexpress_regulator_remove(struct platform_device *pdev)struct vexpress_regulator *reg =platform_get_drvdata (pdev);vexpress_config_func_put (reg->func); -regulator_unregister (reg->regdev);return 0 ; }
Signature · 1 line
1.7.10.4
Re: [PATCH 20/20] regulator: vexpress: use devm_regulator_register()
Quoted 21 lines · Jingoo Han
Use
devm_regulator_register()to make cleanup paths simpler.Signed-off-by Jingoo Han <[email protected]>--- drivers/regulator/vexpress.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/regulator/vexpress.c +1
-1@@ -96,7 +96,7 @@ static int vexpress_regulator_probe(struct platform_device *pdev) config.driver_data = reg; config.of_node = pdev->dev.of_node; - reg->regdev =regulator_register (®->desc, &config); + reg->regdev =devm_regulator_register (&pdev->dev, ®->desc, &config);if (IS_ERR (reg->regdev)) { err =PTR_ERR (reg->regdev); goto error_regulator_register;
drivers/regulator/vexpress.c static int vexpress_regulator_remove(struct platform_device *pdev) · line 124
Quoted 7 lines
drivers/regulator/vexpress.c +0
-1@@ -119,7 +119,6 @@ static int vexpress_regulator_remove(struct platform_device *pdev)struct vexpress_regulator *reg =platform_get_drvdata (pdev);vexpress_config_func_put (reg->func); -regulator_unregister (reg->regdev);return 0 ; }
I'm assuming it's following a patch adding devm_regulator_register()?
Based on this:
Thanks!
Pawel
Quoted 3 lines · Jingoo Han
Use
devm_regulator_register()to make cleanup paths simpler.Signed-off-by Jingoo Han <[email protected]>
Yours,
Linus Walleij