backlight: Remove unnecessary OOM messages
Subsystems (3)
cover backlight: Remove unnecessary OOM messages
The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message. For example, k.alloc and v.alloc failures use dump_stack().
Jingoo Han (12):
backlight: aat2870: Remove unnecessary OOM messages
backlight: adp8860: Remove unnecessary OOM messages
backlight: adp8870: Remove unnecessary OOM messages
backlight: corgi_lcd: Remove unnecessary OOM messages
backlight: hx8357: Remove unnecessary OOM messages
backlight: ili922x: Remove unnecessary OOM messages
backlight: ili9320: Remove unnecessary OOM messages
backlight: l4f00242t03: Remove unnecessary OOM messages
backlight: lm3533_bl: Remove unnecessary OOM messages
backlight: lms283gf05: Remove unnecessary OOM messages
backlight: platform_lcd: Remove unnecessary OOM messages
backlight: tps65217_bl: Remove unnecessary OOM messages
--- drivers/video/backlight/aat2870_bl.c | 2 -- drivers/video/backlight/adp8860_bl.c | 4 +--- drivers/video/backlight/adp8870_bl.c | 4 +--- drivers/video/backlight/corgi_lcd.c | 4 +--- drivers/video/backlight/hx8357.c | 4 +--- drivers/video/backlight/ili922x.c | 4 +--- drivers/video/backlight/ili9320.c | 4 +--- drivers/video/backlight/l4f00242t03.c | 5 +---- drivers/video/backlight/lm3533_bl.c | 5 +---- drivers/video/backlight/lms283gf05.c | 4 +--- drivers/video/backlight/platform_lcd.c | 4 +--- drivers/video/backlight/tps65217_bl.c | 5 +---- 12 files changed, 11 insertions(+), 38 deletions(-)
PATCH 1/12 backlight: aat2870: Remove unnecessary OOM messages
The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.
--- drivers/video/backlight/aat2870_bl.c | 2 -- 1 file changed, 2 deletions(-)
drivers/video/backlight/aat2870_bl.c +0 -2
@@ -149,8 +149,6 @@ static int aat2870_bl_probe(struct platform_device *pdev)sizeof (struct aat2870_bl_driver_data ), GFP_KERNEL);if (!aat2870_bl) { -dev_err (&pdev->dev, -"Failed to allocate memory for aat2870 backlight\n" ); ret = -ENOMEM ; goto out; }
Signature · 1 line
1.7.10.4
Re: [PATCH 01/12] backlight: aat2870: Remove unnecessary OOM messages
Quoted 21 lines · Jingoo Han
The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.
Signed-off-by Jingoo Han <[email protected]>--- drivers/video/backlight/aat2870_bl.c | 2 -- 1 file changed, 2 deletions(-)drivers/video/backlight/aat2870_bl.c +0
-2@@ -149,8 +149,6 @@ static int aat2870_bl_probe(struct platform_device *pdev)sizeof (struct aat2870_bl_driver_data ), GFP_KERNEL);if (!aat2870_bl) { -dev_err (&pdev->dev, -"Failed to allocate memory for aat2870 backlight\n" ); ret = -ENOMEM ; goto out; }
PATCH 2/12 backlight: adp8860: Remove unnecessary OOM messages
In reply to Jingoo HanThe site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.
--- drivers/video/backlight/adp8860_bl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/video/backlight/adp8860_bl.c +1 -3
@@ -224,10 +224,8 @@ static int adp8860_led_probe(struct i2c_client *client) led =devm_kzalloc (&client->dev,sizeof (*led) * pdata->num_leds,GFP_KERNEL ); -if (led ==NULL ) { -dev_err (&client->dev,"failed to alloc memory\n" ); +if (led ==NULL )return -ENOMEM ; - } ret =adp8860_write (client,ADP8860_ISCFR , pdata->led_fade_law); ret = adp8860_write(client, ADP8860_ISCT1,
Signature · 1 line
1.7.10.4
PATCH 3/12 backlight: adp8870: Remove unnecessary OOM messages
In reply to Jingoo HanThe site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.
--- drivers/video/backlight/adp8870_bl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/video/backlight/adp8870_bl.c +1 -3
@@ -246,10 +246,8 @@ static int adp8870_led_probe(struct i2c_client *client) led =devm_kzalloc (&client->dev, pdata->num_leds *sizeof (*led),GFP_KERNEL ); -if (led ==NULL ) { -dev_err (&client->dev,"failed to alloc memory\n" ); +if (led ==NULL )return -ENOMEM ; - } ret =adp8870_write (client,ADP8870_ISCLAW , pdata->led_fade_law);if (ret)
Signature · 1 line
1.7.10.4
Re: [PATCH 03/12] backlight: adp8870: Remove unnecessary OOM messages
Quoted 4 lines · Jingoo Han
The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.
Signed-off-by Jingoo Han <[email protected]>
Quoted 20 lines
--- drivers/video/backlight/adp8870_bl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/video/backlight/adp8870_bl.c +1
-3@@ -246,10 +246,8 @@ static int adp8870_led_probe(struct i2c_client *client) led =devm_kzalloc (&client->dev, pdata->num_leds *sizeof (*led),GFP_KERNEL ); -if (led ==NULL ) { -dev_err (&client->dev,"failed to alloc memory\n" ); +if (led ==NULL )return -ENOMEM ; - } ret =adp8870_write (client,ADP8870_ISCLAW , pdata->led_fade_law);if (ret)
Signature · 8 lines
Greetings, Michael -- Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368; Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, Margaret Seif
PATCH 4/12 backlight: corgi_lcd: Remove unnecessary OOM messages
In reply to Jingoo HanThe site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.
--- drivers/video/backlight/corgi_lcd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/video/backlight/corgi_lcd.c +1 -3
@@ -543,10 +543,8 @@ static int corgi_lcd_probe(struct spi_device *spi) } lcd =devm_kzalloc (&spi->dev,sizeof (struct corgi_lcd ),GFP_KERNEL ); -if (!lcd) { -dev_err (&spi->dev,"failed to allocate memory\n" ); +if (!lcd)return -ENOMEM ; - } lcd->spi_dev = spi;
Signature · 1 line
1.7.10.4
PATCH 5/12 backlight: hx8357: Remove unnecessary OOM messages
In reply to Jingoo HanThe site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.
--- drivers/video/backlight/hx8357.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/video/backlight/hx8357.c +1 -3
@@ -587,10 +587,8 @@ static int hx8357_probe(struct spi_device *spi)int i, ret; lcd =devm_kzalloc (&spi->dev,sizeof (*lcd),GFP_KERNEL ); -if (!lcd) { -dev_err (&spi->dev,"Couldn't allocate lcd internal structure!\n" ); +if (!lcd)return -ENOMEM ; - } ret =spi_setup (spi);if (ret <0 ) {
Signature · 1 line
1.7.10.4
Re: [PATCH 05/12] backlight: hx8357: Remove unnecessary OOM messages
Quoted 4 lines · Jingoo Han
The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.
Signed-off-by Jingoo Han <[email protected]>
Thanks!
Signature · 3 lines
Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 6/12 backlight: ili922x: Remove unnecessary OOM messages
In reply to Jingoo HanThe site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.
--- drivers/video/backlight/ili922x.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/video/backlight/ili922x.c +1 -3
@@ -482,10 +482,8 @@ static int ili922x_probe(struct spi_device *spi)u16 reg =0 ; ili =devm_kzalloc (&spi->dev,sizeof (*ili),GFP_KERNEL ); -if (!ili) { -dev_err (&spi->dev,"cannot alloc priv data\n" ); +if (!ili)return -ENOMEM ; - } ili->spi = spi;spi_set_drvdata (spi, ili);
Signature · 1 line
1.7.10.4
Re: [PATCH 06/12] backlight: ili922x: Remove unnecessary OOM messages
Hi Jingoo,
Quoted 15 lines · Jingoo Han
The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.
Signed-off-by Jingoo Han <[email protected]>--- drivers/video/backlight/ili922x.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/video/backlight/ili922x.c +0
-0@@ -482,10 +482,8 @@ static int ili922x_probe(struct spi_device *spi)u16 reg =0 ;
drivers/video/backlight/ili922x.c static int ili922x_probe(struct spi_device *spi) · line 489
Quoted 10 lines
drivers/video/backlight/ili922x.c +1
-3ili =devm_kzalloc (&spi->dev,sizeof (*ili),GFP_KERNEL ); -if (!ili) { -dev_err (&spi->dev,"cannot alloc priv data\n" ); +if (!ili)return -ENOMEM ; - } ili->spi = spi;spi_set_drvdata (spi, ili);
Thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected] =====================================================================
PATCH 7/12 backlight: ili9320: Remove unnecessary OOM messages
In reply to Jingoo HanThe site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.
--- drivers/video/backlight/ili9320.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/video/backlight/ili9320.c +1 -3
@@ -219,10 +219,8 @@ int ili9320_probe_spi(struct spi_device *spi,/* allocate and initialse our state */ ili =devm_kzalloc (&spi->dev,sizeof (struct ili9320 ),GFP_KERNEL ); -if (ili ==NULL ) { -dev_err (dev,"no memory for device\n" ); +if (ili ==NULL )return -ENOMEM ; - } ili->access.spi.id =ILI9320_SPI_IDCODE |ILI9320_SPI_ID (1 );
Signature · 1 line
1.7.10.4
PATCH 8/12 backlight: l4f00242t03: Remove unnecessary OOM messages
In reply to Jingoo HanThe site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.
--- drivers/video/backlight/l4f00242t03.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/video/backlight/l4f00242t03.c +1 -4
@@ -181,11 +181,8 @@ static int l4f00242t03_probe(struct spi_device *spi) priv =devm_kzalloc (&spi->dev,sizeof (struct l4f00242t03_priv ),GFP_KERNEL ); - -if (priv ==NULL ) { -dev_err (&spi->dev,"No memory for this device.\n" ); +if (priv ==NULL )return -ENOMEM ; - }spi_set_drvdata (spi, priv); spi->bits_per_word =9 ;
Signature · 1 line
1.7.10.4
PATCH 9/12 backlight: lm3533_bl: Remove unnecessary OOM messages
In reply to Jingoo HanThe site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.
--- drivers/video/backlight/lm3533_bl.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/video/backlight/lm3533_bl.c +1 -4
@@ -296,11 +296,8 @@ static int lm3533_bl_probe(struct platform_device *pdev) } bl =devm_kzalloc (&pdev->dev,sizeof (*bl),GFP_KERNEL ); -if (!bl) { -dev_err (&pdev->dev, -"failed to allocate memory for backlight\n" ); +if (!bl)return -ENOMEM ; - } bl->lm3533 = lm3533; bl->id = pdev->id;
Signature · 1 line
1.7.10.4
Re: [PATCH 09/12] backlight: lm3533_bl: Remove unnecessary OOM messages
Quoted 4 lines · Jingoo Han
The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.
Signed-off-by Jingoo Han <[email protected]>
Thanks,
Johan
Quoted 21 lines
--- drivers/video/backlight/lm3533_bl.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)drivers/video/backlight/lm3533_bl.c +1
-4@@ -296,11 +296,8 @@ static int lm3533_bl_probe(struct platform_device *pdev) } bl =devm_kzalloc (&pdev->dev,sizeof (*bl),GFP_KERNEL ); -if (!bl) { -dev_err (&pdev->dev, -"failed to allocate memory for backlight\n" ); +if (!bl)return -ENOMEM ; - } bl->lm3533 = lm3533; bl->id = pdev->id;
PATCH 10/12 backlight: lms283gf05: Remove unnecessary OOM messages
In reply to Jingoo HanThe site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.
--- drivers/video/backlight/lms283gf05.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/video/backlight/lms283gf05.c +1 -3
@@ -168,10 +168,8 @@ static int lms283gf05_probe(struct spi_device *spi) st =devm_kzalloc (&spi->dev,sizeof (struct lms283gf05_state ),GFP_KERNEL ); -if (st ==NULL ) { -dev_err (&spi->dev,"No memory for device state\n" ); +if (st ==NULL )return -ENOMEM ; - } ld =devm_lcd_device_register (&spi->dev,"lms283gf05" , &spi->dev, st, &lms_ops);
Signature · 1 line
1.7.10.4
Re: [PATCH 10/12] backlight: lms283gf05: Remove unnecessary OOM messages
Quoted 4 lines · Jingoo Han
The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.
Signed-off-by Jingoo Han <[email protected]>
Best regards,
Marek Vasut
PATCH 11/12 backlight: platform_lcd: Remove unnecessary OOM messages
In reply to Jingoo HanThe site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.
--- drivers/video/backlight/platform_lcd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/video/backlight/platform_lcd.c +1 -3
@@ -94,10 +94,8 @@ static int platform_lcd_probe(struct platform_device *pdev) plcd =devm_kzalloc (&pdev->dev,sizeof (struct platform_lcd ),GFP_KERNEL ); -if (!plcd) { -dev_err (dev,"no memory for state\n" ); +if (!plcd)return -ENOMEM ; - } plcd->us = dev; plcd->pdata = pdata;
Signature · 1 line
1.7.10.4
PATCH 12/12 backlight: tps65217_bl: Remove unnecessary OOM messages
In reply to Jingoo HanThe site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message.
--- drivers/video/backlight/tps65217_bl.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/video/backlight/tps65217_bl.c +1 -4
@@ -200,7 +200,6 @@ tps65217_bl_parse_dt(struct platform_device *pdev) pdata =devm_kzalloc (&pdev->dev,sizeof (*pdata),GFP_KERNEL );if (!pdata) { -dev_err (&pdev->dev,"failed to allocate platform data\n" ); err =ERR_PTR (-ENOMEM ); goto err; }
@@ -296,10 +295,8 @@ static int tps65217_bl_probe(struct platform_device *pdev) tps65217_bl =devm_kzalloc (&pdev->dev,sizeof (*tps65217_bl),GFP_KERNEL ); -if (tps65217_bl ==NULL ) { -dev_err (&pdev->dev,"allocation of struct tps65217_bl failed\n" ); +if (tps65217_bl ==NULL )return -ENOMEM ; - } tps65217_bl->tps = tps; tps65217_bl->dev = &pdev->dev;
Signature · 1 line
1.7.10.4