f2fs: avoid unneeded lookup when xattr name length is too long

PATCH New Chao Yu 1 participant 1 message Mar 22, 2014

Subsystems (2)

VFS F2FS file system

lore

Share & tools

lore

Chao Yu

author

2014-03-22 06:59 UTC #0 lore raw

PATCH 2/2 f2fs: avoid unneeded lookup when xattr name length is too long

In f2fs_setxattr we have limit this attribute name length, so we should also check it in f2fs_getxattr to avoid useless lookup caused by invalid name length.

Signed-off-by Chao Yu <[email protected]>

---
 fs/f2fs/xattr.c |    2 ++
 1 file changed, 2 insertions(+)

fs/f2fs/xattr.c +2 -0

index 0121e45..503c245 100644
@@ -407,6 +407,8 @@ int f2fs_getxattr(struct inode *inode, int name_index, const char *name,
 	if (name == NULL)
 		return -EINVAL;
 	name_len = strlen(name);
+	if (name_len > F2FS_NAME_LEN)
+		return -ERANGE;
 
 	base_addr = read_all_xattrs(inode, NULL);
 	if (!base_addr)

Signature · 1 line

1.7.9.5