Skip to contentSkip to conversation

fix sis900 <-> Crossfire 8720 (switch) auto-negotiation, please test

fix 2.5 Rune 1 participant 1 message Feb 13, 2003

lore
Share & tools
lore

Rune

author
#0 lore raw

Hi,
by accident I discovered a fix for auto-negotiation on the sis-900.

in sis900_open(), sis900_check_mode() looks redundant, and when removing it auto-negotiation works for sis900 and Crossfire 8720 (perhaps others).

I have tested it, but I have no ideas if there is any side effects, so please test this on non-Crossfire setups.

the patch is made against 2.5.60-bk2 but this code havent changed for a long time.
for some reason this has no effect on kernel 2.4...

Rune Petersen

sis900.c renamed from sis900.c.orig +0 -2
@@ -937,8 +937,6 @@
 	outl(RxENA | inl(ioaddr + cr), ioaddr + cr);
 	outl(IE, ioaddr + ier);
 
-	sis900_check_mode(net_dev, sis_priv->mii);
-
 	/* Set the timer to switch to check for link beat and perhaps switch
 	   to an alternate media type. */
 	init_timer(&sis_priv->timer);