Skip to contentSkip to conversation

mmc: dw_mmc-pltfm: include 'dw_mmc-pltfm.h'

PATCH In review Jingoo Han 3 participants 3 messages Aug 6, 2013 – Aug 25, 2013

Subsystems (2)
MMC, SD and SDIO Synopsys DesignWare MMC/SD/SDIO driver
lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 1/1 mmc: dw_mmc-pltfm: include 'dw_mmc-pltfm.h'

Include 'dw_mmc-pltfm.h' header file in order to fix the following sparse warnings:

drivers/mmc/host/dw_mmc-pltfm.c:36:5: warning: symbol 'dw_mci_pltfm_register' was not declared. Should it be static? drivers/mmc/host/dw_mmc-pltfm.c:94:1: warning: symbol 'dw_mci_pltfm_pmops' was not declared. Should it be static? drivers/mmc/host/dw_mmc-pltfm.c:118:5: warning: symbol 'dw_mci_pltfm_remove' was not declared. Should it be static?

Suggested-by Dan Carpenter <[email protected]>
Signed-off-by Jingoo Han <[email protected]>
---
 drivers/mmc/host/dw_mmc-pltfm.c |    1 +
 1 file changed, 1 insertion(+)
drivers/mmc/host/dw_mmc-pltfm.c +1 -0
index ee52556..2089752 100644
@@ -23,6 +23,7 @@
 #include <linux/of.h>
 
 #include "dw_mmc.h"
+#include "dw_mmc-pltfm.h"
 
 static void dw_mci_rockchip_prepare_command(struct dw_mci *host, u32 *cmdr)
 {
Signature · 1 line
1.7.10.4
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · On Tue, August 06, 2013,Jingoo Han wrote:

Include 'dw_mmc-pltfm.h' header file in order to fix the following sparse warnings:

drivers/mmc/host/dw_mmc-pltfm.c:36:5: warning: symbol 'dw_mci_pltfm_register' was not declared. Should it be static?
drivers/mmc/host/dw_mmc-pltfm.c:94:1: warning: symbol 'dw_mci_pltfm_pmops' was not declared. Should it be static?
drivers/mmc/host/dw_mmc-pltfm.c:118:5: warning: symbol 'dw_mci_pltfm_remove' was not declared. Should it be static?

Quoted 2 lines
Suggested-by Dan Carpenter <[email protected]>
Signed-off-by Jingoo Han <[email protected]>
Acked-by Seungwon Jeon <[email protected]>
#2 lore raw

Hi Seungwon,

Quoted 14 lines · Seungwon Jeon
Quoted 13 lines · On Tue, August 06, 2013,Jingoo Han wrote:

Include 'dw_mmc-pltfm.h' header file in order to fix the following sparse warnings:

drivers/mmc/host/dw_mmc-pltfm.c:36:5: warning: symbol dw_mci_pltfm_register' was not declared. Should it be static? drivers/mmc/host/dw_mmc-pltfm.c:94:1: warning: symbol dw_mci_pltfm_pmops' was not declared. Should it be static? drivers/mmc/host/dw_mmc-pltfm.c:118:5: warning: symbol dw_mci_pltfm_remove' was not declared. Should it be static?

Quoted 4 lines
Quoted 2 lines
Suggested-by Dan Carpenter <[email protected]>
Signed-off-by Jingoo Han <[email protected]>
Acked-by Seungwon Jeon <[email protected]>

Thanks, pushed to mmc-next for 3.12.

- Chris.

Signature · 1 line
Chris Ball   <[email protected]>   <http://printf.net/>