PCI: drop a redundant variable from pci_add_device()
PATCH 1/1 PCI: drop a redundant variable from pci_add_device()
Surrounding code already uses the available alternative, after all.
Signed-off-by Jan Beulich <[email protected]>
xen/drivers/passthrough/pci.c +2 -2
@@ -760,7 +760,6 @@ int pci_add_device(u16 seg, u8 bus, u8 d {unsigned int idx = pos +PCI_SRIOV_BAR + i *4 ;uint32_t bar =pci_conf_read32 (pdev->sbdf, idx); -pci_sbdf_t sbdf =PCI_SBDF3 (seg, bus, devfn);if ( (bar &PCI_BASE_ADDRESS_SPACE ) ==PCI_BASE_ADDRESS_SPACE_IO )
@@ -771,7 +770,8 @@ int pci_add_device(u16 seg, u8 bus, u8 d seg, bus, slot, func, i);continue ; } - ret =pci_size_mem_bar (sbdf, idx,NULL , &pdev->vf_rlen[i], + ret =pci_size_mem_bar (pdev->sbdf, idx,NULL , + &pdev->vf_rlen[i],PCI_BAR_VF | ((i ==PCI_SRIOV_NUM_BARS -1 ) ?PCI_BAR_LAST :0 ));
Quoted 3 lines · Jan Beulich
Surrounding code already uses the available alternative, after all.
Signed-off-by Jan Beulich <[email protected]>
Acked-by Andrew Cooper <[email protected]>
Quoted 11 lines
-----Original Message-----
From: Jan Beulich <[email protected]>
Sent: 28 April 2020 14:00
To: [email protected]
Cc: Paul Durrant <[email protected]>
Subject: [PATCH] PCI: drop a redundant variable frompci_add_device()Surrounding code already uses the available alternative, after all.
Signed-off-by Jan Beulich <[email protected]>
Reviewed-by Paul Durrant <[email protected]>