scsi: replace strict_strtoul() with kstrtoul()
Subsystems (2)
PATCH v2 1/1 scsi: replace strict_strtoul() with kstrtoul()
The usage of strict_strtoul() is not preferred, because strict_strtoul() is obsolete. Thus, kstrtoul() should be used.
Signed-off-by Jingoo Han <[email protected]>
---
Changes since v1:
- Used return code from kstrtoul().
drivers/scsi/pmcraid.c | 6 ++++-- drivers/scsi/scsi_sysfs.c | 6 ++++-- 2 files changed, 8 insertions(+), 4 deletions(-)
drivers/scsi/pmcraid.c +4 -2
@@ -4203,9 +4203,11 @@ static ssize_t pmcraid_store_log_level(struct Scsi_Host *shost;struct pmcraid_instance *pinstance;unsigned long val; +int ret; -if (strict_strtoul (buf,10 , &val)) -return -EINVAL ; + ret =kstrtoul (buf,10 , &val); +if (ret) +return ret;/* log-level should be from 0 to 2 */ if (val >2 )return -EINVAL ;
drivers/scsi/scsi_sysfs.c +4 -2
@@ -789,9 +789,11 @@ sdev_store_queue_ramp_up_period(struct device *dev, {struct scsi_device *sdev =to_scsi_device (dev);unsigned long period; +int ret; -if (strict_strtoul (buf,10 , &period)) -return -EINVAL ; + ret =kstrtoul (buf,10 , &period); +if (ret) +return ret; sdev->queue_ramp_up_period =msecs_to_jiffies (period);return period;
Signature · 1 line
1.7.10.4
Quoted 5 lines · Jingoo Han
The usage of
strict_strtoul()is not preferred, becausestrict_strtoul()is obsolete. Thus,kstrtoul()should be used.Signed-off-by Jingoo Han <[email protected]>
Reviewed-by Andy Shevchenko <[email protected]>
Quoted 45 lines
---
Changes since v1:
- Used return code fromkstrtoul().drivers/scsi/pmcraid.c | 6 ++++-- drivers/scsi/scsi_sysfs.c | 6 ++++-- 2 files changed, 8 insertions(+), 4 deletions(-)drivers/scsi/pmcraid.c +4
-2@@ -4203,9 +4203,11 @@ static ssize_t pmcraid_store_log_level(struct Scsi_Host *shost;struct pmcraid_instance *pinstance;unsigned long val; +int ret; -if (strict_strtoul (buf,10 , &val)) -return -EINVAL ; + ret =kstrtoul (buf,10 , &val); +if (ret) +return ret;/* log-level should be from 0 to 2 */ if (val >2 )return -EINVAL ;drivers/scsi/scsi_sysfs.c +4
-3@@ -789,9 +789,11 @@ sdev_store_queue_ramp_up_period(struct device *dev, {struct scsi_device *sdev =to_scsi_device (dev);unsigned long period; +int ret; -if (strict_strtoul (buf,10 , &period)) -return -EINVAL ; + ret =kstrtoul (buf,10 , &period); +if (ret) +return ret; sdev->queue_ramp_up_period =msecs_to_jiffies (period);return period; --
Quoted 3 lines
1.7.10.4
--
With Best Regards,
Andy Shevchenko