Skip to contentSkip to conversation

net: netx-eth: remove unnecessary casting when using dev_get_platdata()

PATCH Superseded Jingoo Han 3 participants 4 messages Sep 2, 2013 – Sep 4, 2013

Subsystems (2)
lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 1/1 net: netx-eth: remove unnecessary casting when using dev_get_platdata()

Casting from 'void *' is unnecessary when using dev_get_platdata().

---
 drivers/net/ethernet/netx-eth.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/netx-eth.c +1 -1
index 235fd51..e6f0a43 100644
@@ -390,7 +390,7 @@ static int netx_eth_drv_probe(struct platform_device *pdev)
 
 	priv = netdev_priv(ndev);
 
-	pdata = (struct netxeth_platform_data *)dev_get_platdata(&pdev->dev);
+	pdata = dev_get_platdata(&pdev->dev);
 	priv->xc = request_xc(pdata->xcno, &pdev->dev);
 	if (!priv->xc) {
 		dev_err(&pdev->dev, "unable to request xc engine\n");
Signature · 1 line
1.7.10.4
author
#2 lore raw

PATCH v2 1/1 net: netx-eth: remove unnecessary casting

In reply to Jingoo Han

Casting from 'void *' is unnecessary, because casting from 'void *' to any pointer type is automatic.

---
 drivers/net/ethernet/netx-eth.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/netx-eth.c +1 -1
index 235fd51..e6f0a43 100644
@@ -390,7 +390,7 @@ static int netx_eth_drv_probe(struct platform_device *pdev)
 
 	priv = netdev_priv(ndev);
 
-	pdata = (struct netxeth_platform_data *)dev_get_platdata(&pdev->dev);
+	pdata = dev_get_platdata(&pdev->dev);
 	priv->xc = request_xc(pdata->xcno, &pdev->dev);
 	if (!priv->xc) {
 		dev_err(&pdev->dev, "unable to request xc engine\n");
Signature · 1 line
1.7.10.4