Skip to contentSkip to conversation

uio: uio_aec: remove unnecessary pci_set_drvdata()

PATCH New Jingoo Han 1 participant 5 messages Sep 12, 2013 Userspace I/O (UIO)

lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 1/5 uio: uio_aec: remove unnecessary pci_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/uio/uio_aec.c |    1 -
 1 file changed, 1 deletion(-)
drivers/uio/uio_aec.c +0 -1
index f3611c2..1549fab 100644
@@ -147,7 +147,6 @@ static void remove(struct pci_dev *pdev)
 	uio_unregister_device(info);
 	pci_release_regions(pdev);
 	pci_disable_device(pdev);
-	pci_set_drvdata(pdev, NULL);
 	iounmap(info->priv);
 
 	kfree(info);
Signature · 1 line
1.7.10.4
author
#1 lore raw

PATCH 2/5 uio: uio_cif: remove unnecessary pci_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/uio/uio_cif.c |    1 -
 1 file changed, 1 deletion(-)
drivers/uio/uio_cif.c +0 -1
index 22cdf38..30f533c 100644
@@ -106,7 +106,6 @@ static void hilscher_pci_remove(struct pci_dev *dev)
 	uio_unregister_device(info);
 	pci_release_regions(dev);
 	pci_disable_device(dev);
-	pci_set_drvdata(dev, NULL);
 	iounmap(info->mem[0].internal_addr);
 
 	kfree (info);
Signature · 1 line
1.7.10.4
author
#2 lore raw

PATCH 3/5 uio: uio_mf624: remove unnecessary pci_set_drvdata()

In reply to Jingoo Han

The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/uio/uio_mf624.c |    1 -
 1 file changed, 1 deletion(-)
drivers/uio/uio_mf624.c +0 -1
index a1768b2..832afa2 100644
@@ -220,7 +220,6 @@ static void mf624_pci_remove(struct pci_dev *dev)
 	uio_unregister_device(info);
 	pci_release_regions(dev);
 	pci_disable_device(dev);
-	pci_set_drvdata(dev, NULL);
 
 	iounmap(info->mem[0].internal_addr);
 	iounmap(info->mem[1].internal_addr);
Signature · 1 line
1.7.10.4
author
#3 lore raw

PATCH 4/5 uio: uio_netx: remove unnecessary pci_set_drvdata()

In reply to Jingoo Han

The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/uio/uio_netx.c |    1 -
 1 file changed, 1 deletion(-)
drivers/uio/uio_netx.c +0 -1
index 28a766b..4c345db 100644
@@ -127,7 +127,6 @@ static void netx_pci_remove(struct pci_dev *dev)
 	uio_unregister_device(info);
 	pci_release_regions(dev);
 	pci_disable_device(dev);
-	pci_set_drvdata(dev, NULL);
 	iounmap(info->mem[0].internal_addr);
 
 	kfree(info);
Signature · 1 line
1.7.10.4
author
#4 lore raw

PATCH 5/5 uio: uio_sercos3: remove unnecessary pci_set_drvdata()

In reply to Jingoo Han

The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/uio/uio_sercos3.c |    1 -
 1 file changed, 1 deletion(-)
drivers/uio/uio_sercos3.c +0 -1
index 5419832..9cfdfca 100644
@@ -188,7 +188,6 @@ static void sercos3_pci_remove(struct pci_dev *dev)
 	uio_unregister_device(info);
 	pci_release_regions(dev);
 	pci_disable_device(dev);
-	pci_set_drvdata(dev, NULL);
 	for (i = 0; i < 5; i++) {
 		if (info->mem[i].internal_addr)
 			iounmap(info->mem[i].internal_addr);
Signature · 1 line
1.7.10.4