Skip to contentSkip to conversation

iw_cxgb4: Wake up waiters after flushing the qp

PATCH In review Steve Wise 1 participant 4 messages Oct 20, 2014 – Dec 1, 2014 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore

Steve Wise

author
#0 lore raw

PATCH 1/1 iw_cxgb4: Wake up waiters after flushing the qp

When transitioning into ERROR state, the QP was getting flushed after waking up any waiters. This can cause applications to miss flushed work requests which can stall an NFS mount.

---

 drivers/infiniband/hw/cxgb4/qp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/infiniband/hw/cxgb4/qp.c +1 -1
index 41cd688..fad4851 100644
@@ -1538,9 +1538,9 @@ err:
 	set_state(qhp, C4IW_QP_STATE_ERROR);
 	free = 1;
 	abort = 1;
-	wake_up(&qhp->wait);
 	BUG_ON(!ep);
 	flush_qp(qhp);
+	wake_up(&qhp->wait);
 out:
 	mutex_unlock(&qhp->mutex);
 

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 20141020153755.31500.44966.stgit-T4OLL4TyM9aNDNWfRnPdfg@public.gmane.org

author
#2 lore raw

Hey Roland,

Hope you can get this bug fix into 3.18. Plus these others that have been submitted a while ago. Here is the entire list:

https://patchwork.kernel.org/patch/5106541/
https://patchwork.kernel.org/patch/5249511/
https://patchwork.kernel.org/patch/5249501/
https://patchwork.kernel.org/patch/5089511/
https://patchwork.kernel.org/patch/5089501/

Thanks,

Steve.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 546F597B.4020404-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org

author
#4 lore raw

I've pushed these to:

git://git.openfabrics.org/~swise/linux.git for_roland

Steve

Hariprasad Shenai (2):
iw_cxgb4: Fixes locking issue in process_mpa_request
iw_cxgb4: limit MRs to < 8GB for T4/T5 devices

Pramod Kumar (2):
cxgb4/rdma:Increase epd buff size for debug interface cxgb4/rdma: configure 0B MRs to match HW implementation

Steve Wise (1):
iw_cxgb4: Wake up waiters after flushing the qp

Quoted 19 lines

-----Original Message-----
From: Steve Wise [mailto:[email protected]]
Sent: Friday, November 21, 2014 9:26 AM
To: [email protected]
Cc: [email protected]
Subject: Re: [PATCH] iw_cxgb4: Wake up waiters after flushing the qp

Hey Roland,

Hope you can get this bug fix into 3.18. Plus these others that have been submitted a while ago. Here is the entire list:

https://patchwork.kernel.org/patch/5106541/
https://patchwork.kernel.org/patch/5249511/
https://patchwork.kernel.org/patch/5249501/
https://patchwork.kernel.org/patch/5089511/
https://patchwork.kernel.org/patch/5089501/

Quoted 3 lines

Thanks,

Steve.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#5 lore raw
In reply to Steve Wise

Hey Roland, please reply and let me know if you will push these to 3.18 (would have to happen now) or if they are destined for 3.19.

Thanks,

Steve.

Quoted 17 lines

-----Original Message-----
From: Steve Wise [mailto:[email protected]]
Sent: Friday, November 21, 2014 9:42 AM
To: '[email protected]'
Cc: '[email protected]'
Subject: RE: [PATCH] iw_cxgb4: Wake up waiters after flushing the qp

I've pushed these to:

git://git.openfabrics.org/~swise/linux.git for_roland

Steve

Hariprasad Shenai (2):
iw_cxgb4: Fixes locking issue in process_mpa_request
iw_cxgb4: limit MRs to < 8GB for T4/T5 devices

Quoted 30 lines

Pramod Kumar (2):
cxgb4/rdma:Increase epd buff size for debug interface cxgb4/rdma: configure 0B MRs to match HW implementation

Steve Wise (1):
iw_cxgb4: Wake up waiters after flushing the qp

Quoted 22 lines

-----Original Message-----
From: Steve Wise [mailto:[email protected]]
Sent: Friday, November 21, 2014 9:26 AM
To: [email protected]
Cc: [email protected]
Subject: Re: [PATCH] iw_cxgb4: Wake up waiters after flushing the qp

Hey Roland,

Hope you can get this bug fix into 3.18. Plus these others that have been submitted a while ago. Here is the entire list:

https://patchwork.kernel.org/patch/5106541/
https://patchwork.kernel.org/patch/5249511/
https://patchwork.kernel.org/patch/5249501/
https://patchwork.kernel.org/patch/5089511/
https://patchwork.kernel.org/patch/5089501/

Thanks,

Steve.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html