rtc: rtc-pcf2123: replace strict_strtoul() with kstrtoul()

PATCH Superseded Jingoo Han 2 participants 3 messages Jun 4, 2013 – Jun 7, 2013 Real time clock (RTC)

Share & tools

Jingoo Han

author

2013-06-04 04:12 UTC #0 lore raw

PATCH v3 1/1 rtc: rtc-pcf2123: replace strict_strtoul() with kstrtoul()

The usage of strict_strtoul() is not preferred, because strict_strtoul() is obsolete. Thus, kstrtoul() should be used.

Signed-off-by Jingoo Han <[email protected]>

Reviewed-by Andy Shevchenko <[email protected]>

---
Changes since v1:
- Splitted to two sequential checks.
- Added Andy Shevchenko's Reviewed-by.

Changes since v1:
- Used return code from kstrtoul().

 drivers/rtc/rtc-pcf2123.c |   15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

drivers/rtc/rtc-pcf2123.c +10 -5

index b2a78a0..1725b50 100644
@@ -94,8 +94,9 @@ static ssize_t pcf2123_show(struct device *dev, struct device_attribute *attr,
 
 	r = container_of(attr, struct pcf2123_sysfs_reg, attr);
 
-	if (strict_strtoul(r->name, 16, &reg))
-		return -EINVAL;
+	ret = kstrtoul(r->name, 16, &reg);
+	if (ret)
+		return ret;
 
 	txbuf[0] = PCF2123_READ | reg;
 	ret = spi_write_then_read(spi, txbuf, 1, rxbuf, 1);

@@ -117,9 +118,13 @@ static ssize_t pcf2123_store(struct device *dev, struct device_attribute *attr,
 
 	r = container_of(attr, struct pcf2123_sysfs_reg, attr);
 
-	if (strict_strtoul(r->name, 16, &reg)
-		|| strict_strtoul(buffer, 10, &val))
-		return -EINVAL;
+	ret = kstrtoul(r->name, 16, &reg);
+	if (ret)
+		return ret;
+
+	ret = kstrtoul(buffer, 10, &val);
+	if (ret)
+		return ret;
 
 	txbuf[0] = PCF2123_WRITE | reg;
 	txbuf[1] = val;

Signature · 1 line

1.7.10.4

'Greg Kroah-Hartman'

2013-06-06 19:52 UTC #1 lore raw

Quoted 11 lines · Jingoo Han

The usage of strict_strtoul() is not preferred, because strict_strtoul() is obsolete. Thus, kstrtoul() should be used.
Signed-off-by Jingoo Han <[email protected]>
Reviewed-by Andy Shevchenko <[email protected]>
---
Changes since v1:
- Splitted to two sequential checks.
- Added Andy Shevchenko's Reviewed-by.

Quoted 5 lines

Changes since v1:
- Used return code from kstrtoul().
 drivers/rtc/rtc-pcf2123.c |   15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

I'm not the drivers/rtc/ maintainer, why send this to me?

greg k-h

Jingoo Han

author

2013-06-07 00:57 UTC #2 lore raw

Quoted 12 lines · Greg Kroah-Hartman

Quoted 11 lines · Jingoo Han
The usage of strict_strtoul() is not preferred, because strict_strtoul() is obsolete. Thus, kstrtoul() should be used.
Signed-off-by Jingoo Han <[email protected]>
Reviewed-by Andy Shevchenko <[email protected]>
---
Changes since v1:
- Splitted to two sequential checks.
- Added Andy Shevchenko's Reviewed-by.

Quoted 7 lines

Quoted 5 lines
Changes since v1:
- Used return code from kstrtoul().
 drivers/rtc/rtc-pcf2123.c |   15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)
I'm not the drivers/rtc/ maintainer, why send this to me?

Hi Greg,

Sorry. It's my mistake.
I will re-send it to the maintainer of rtc.
Thank you.

Best regards,
Jingoo Han

Quoted 2 lines

greg k-h