AVCTP and AVRCP packet decoder file structure in btmon
Hi,
I'm working on AVRCP packet decoder for Bluetooth monitor module. There's a separate file avctp.c/h for AVCTP packet decoder.
The file avctp.c is not a big file as such. So, I'm thinking whether or not I should
include AVRCP decoder in this file itself.
Shall I create a separate file for AVRCP decoding?
If both AVCTP & AVRCP go in the same file then what should be the appropriate name of the file or shall I create a separate file for AVRCP as well.
Please advise me. Thanks!
Regards,
Vikram
Luiz Augusto von Dentz
maintainerHi Vikrampal,
We can start by reusing avctp.c to place AV/C and AVRCP decoders, later on we can review if it is the case of splitting. Also please note that android/Android.mk needs updating if we change anything on the build of btmon.
Quoted 20 lines · Vikrampal
Hi,
I'm working on AVRCP packet decoder for Bluetooth monitor module. There's a separate file avctp.c/h for AVCTP packet decoder.
The file
avctp.cis not a big file as such. So, I'm thinking whether or not I should
include AVRCP decoder in this file itself.Shall I create a separate file for AVRCP decoding?
If both AVCTP & AVRCP go in the same file then what should be the appropriate name of the file or shall I create a separate file for AVRCP as well.
Please advise me. Thanks!
Regards,
Vikram
Signature · 1 line
Luiz Augusto von Dentz
Sure Luiz!
However, I've one more small doubt. If I'm submitting a series of patches Such as 1/4, 2/4, 3/4, 4/4... I guess in such scenarios no need to ensure that the patches separately compiles. What we need to ensure is that all the patches together gets compiled properly. Am I mistaken?
Quoted 32 lines
-----Original Message-----
From: Luiz Augusto von Dentz [mailto:[email protected]]
Sent: Monday, August 04, 2014 4:15 PM
To: Vikrampal
Cc: [email protected]; Dmitry Kasatkin
Subject: Re: AVCTP and AVRCP packet decoder file structure in btmonHi Vikrampal,
We can start by reusing
avctp.cto place AV/C and AVRCP decoders, later on we can review if it is the case of splitting. Also please note thatandroid/Android.mkneeds updating if we change anything on the build of btmon.Quoted 16 lines · Vikrampal
Hi,
I'm working on AVRCP packet decoder for Bluetooth monitor module. There's a separate file avctp.c/h for AVCTP packet decoder.
The file
avctp.cis not a big file as such. So, I'm thinking whether or not I should include AVRCP decoder in this file itself.Shall I create a separate file for AVRCP decoding?
If both AVCTP & AVRCP go in the same file then what should be the appropriate name of the file or shall I create a separate file for AVRCP as well.
Please advise me. Thanks!
Quoted 8 lines
Quoted 3 lines
Regards,
Vikram--
Luiz Augusto von Dentz
Regards,
Vikram
Luiz Augusto von Dentz
maintainerHi Vikrampal,
I do like to test patches individually so please make sure they compile and in general we don't allow commits that do not compile because they can break bisect.
Quoted 51 lines · Vikrampal
Sure Luiz!
However, I've one more small doubt. If I'm submitting a series of patches Such as 1/4, 2/4, 3/4, 4/4... I guess in such scenarios no need to ensure that the patches separately compiles. What we need to ensure is that all the patches together gets compiled properly. Am I mistaken?
Quoted 32 lines
-----Original Message-----
From: Luiz Augusto von Dentz [mailto:[email protected]]
Sent: Monday, August 04, 2014 4:15 PM
To: Vikrampal
Cc: [email protected]; Dmitry Kasatkin
Subject: Re: AVCTP and AVRCP packet decoder file structure in btmonHi Vikrampal,
We can start by reusing
avctp.cto place AV/C and AVRCP decoders, later on we can review if it is the case of splitting. Also please note thatandroid/Android.mkneeds updating if we change anything on the build of btmon.Quoted 16 lines · Vikrampal
Hi,
I'm working on AVRCP packet decoder for Bluetooth monitor module. There's a separate file avctp.c/h for AVCTP packet decoder.
The file
avctp.cis not a big file as such. So, I'm thinking whether or not I should include AVRCP decoder in this file itself.Shall I create a separate file for AVRCP decoding?
If both AVCTP & AVRCP go in the same file then what should be the appropriate name of the file or shall I create a separate file for AVRCP as well.
Please advise me. Thanks!
Quoted 8 lines
Quoted 3 lines
Regards,
Vikram--
Luiz Augusto von DentzRegards,
Vikram
Signature · 1 line
Luiz Augusto von Dentz
Hi Luiz,
If I submit interdependent patches in one go then I guess the patches are taken in order i.e. 1/4, 2/4, 3/4, 4/4.
That means we can take just 2/4 out and expect it to compile since it depends on 1/4.
Am I correct?
Quoted 65 lines
-----Original Message-----
From: Luiz Augusto von Dentz [mailto:[email protected]]
Sent: Tuesday, August 05, 2014 1:32 PM
To: Vikrampal
Cc: [email protected]; Dmitry Kasatkin
Subject: Re: AVCTP and AVRCP packet decoder file structure in btmonHi Vikrampal,
I do like to test patches individually so please make sure they compile and in general we don't allow commits that do not compile because they can break bisect.
Quoted 6 lines · Vikrampal
Sure Luiz!
However, I've one more small doubt. If I'm submitting a series of patches Such as 1/4, 2/4, 3/4, 4/4... I guess in such scenarios no need to ensure that the patches separately compiles. What we need to ensure is that all the patches together gets compiled properly. Am I
mistaken?
Quoted 8 lines
Quoted 8 lines
-----Original Message-----
From: Luiz Augusto von Dentz [mailto:[email protected]]
Sent: Monday, August 04, 2014 4:15 PM
To: Vikrampal
Cc: [email protected]; Dmitry Kasatkin
Subject: Re: AVCTP and AVRCP packet decoder file structure in btmonQuoted 8 lines
Quoted 8 lines
Hi Vikrampal,
We can start by reusing
avctp.cto place AV/C and AVRCP decoders, later on we can review if it is the case of splitting. Also please note thatandroid/Android.mkneeds updating if we change anything on the build of btmon.On Mon, Aug 4, 2014 at 11:48 AM, Vikrampal
Quoted 26 lines
Quoted 25 lines
Quoted 10 lines · wrote:
Hi,
I'm working on AVRCP packet decoder for Bluetooth monitor module. There's a separate file avctp.c/h for AVCTP packet decoder.
The file
avctp.cis not a big file as such. So, I'm thinking whether or not I should include AVRCP decoder in this file itself.Shall I create a separate file for AVRCP decoding?
Quoted 9 lines
If both AVCTP & AVRCP go in the same file then what should be the appropriate name of the file or shall I create a separate file for AVRCP as well.
Please advise me. Thanks!
Regards,
Vikram--
Luiz Augusto von Dentz
Quoted 8 lines
Quoted 3 lines
Regards,
Vikram--
Luiz Augusto von Dentz
Regards,
Vikram
Quoted 9 lines
-----Original Message-----
From: Vikrampal [mailto:[email protected]]
Sent: Tuesday, August 05, 2014 2:43 PM
To: 'Luiz Augusto von Dentz'
Cc: '[email protected]'; 'Dmitry Kasatkin'
Subject: RE: AVCTP and AVRCP packet decoder file structure in btmon
Quoted 6 lines
Hi Luiz,
If I submit interdependent patches in one go then I guess the patches are taken in order i.e. 1/4, 2/4, 3/4, 4/4.
That means we can take just 2/4 out and expect it to compile since it depends
* That means we can NOT take just 2/4 out and expect it to compile since it depends
Quoted 80 lines
on 1/4.
Am I correct?
Quoted 65 lines
-----Original Message-----
From: Luiz Augusto von Dentz [mailto:[email protected]]
Sent: Tuesday, August 05, 2014 1:32 PM
To: Vikrampal
Cc: [email protected]; Dmitry Kasatkin
Subject: Re: AVCTP and AVRCP packet decoder file structure in btmonHi Vikrampal,
I do like to test patches individually so please make sure they compile and in general we don't allow commits that do not compile because they can break bisect.
Quoted 6 lines · Vikrampal
Sure Luiz!
However, I've one more small doubt. If I'm submitting a series of patches Such as 1/4, 2/4, 3/4, 4/4... I guess in such scenarios no need to ensure that the patches separately compiles. What we need to ensure is that all the patches together gets compiled properly. Am I
mistaken?
Quoted 8 lines
Quoted 8 lines
-----Original Message-----
From: Luiz Augusto von Dentz [mailto:[email protected]]
Sent: Monday, August 04, 2014 4:15 PM
To: Vikrampal
Cc: [email protected]; Dmitry Kasatkin
Subject: Re: AVCTP and AVRCP packet decoder file structure in btmonQuoted 8 lines
Quoted 8 lines
Hi Vikrampal,
We can start by reusing
avctp.cto place AV/C and AVRCP decoders, later on we can review if it is the case of splitting. Also please note thatandroid/Android.mkneeds updating if we change anything on the build of btmon.On Mon, Aug 4, 2014 at 11:48 AM, Vikrampal
Quoted 26 lines
Quoted 25 lines
Quoted 10 lines · wrote:
Hi,
I'm working on AVRCP packet decoder for Bluetooth monitor module. There's a separate file avctp.c/h for AVCTP packet decoder.
The file
avctp.cis not a big file as such. So, I'm thinking whether or not I should include AVRCP decoder in this file itself.Shall I create a separate file for AVRCP decoding?
Quoted 9 lines
If both AVCTP & AVRCP go in the same file then what should be the appropriate name of the file or shall I create a separate file for AVRCP as well.
Please advise me. Thanks!
Regards,
Vikram--
Luiz Augusto von DentzQuoted 8 lines
Quoted 3 lines
Regards,
Vikram--
Luiz Augusto von DentzRegards,
Vikram
Quoted 7 lines · On Tue, 05 Aug 2014 12:24:44 +0530 Vikrampal <[email protected]> wrote:
Sure Luiz!
However, I've one more small doubt. If I'm submitting a series of patches Such as 1/4, 2/4, 3/4, 4/4... I guess in such scenarios no need to ensure that the patches separately compiles. What we need to ensure is that all the patches together gets compiled properly. Am I mistaken?
Make sure that sub-sequences of a series produce sensible code.
The code should $VALIDATE with 1/4 applied.
The code should $VALIDATE with 1/4 and 2/4 applied. The code should $VALIDATE with 1/4, 2/4 and 3/4 applied. The code should $VALIDATE with 1/4, 2/4, 3/4 and 4/4 applied.
The definition of VALIDATE can vary project by project or feature by feature; the minimum requirement should be that compilation always succeeds.
You can use something like:
git rebase -i --exec "make" some_parent_branch
to test that compilation passes after each commit.
Ciao,
Antonio
Signature · 6 lines
Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing?
Thanks Antonio for useful advice!
Quoted 20 lines
-----Original Message-----
From: Antonio Ospite [mailto:[email protected]]
Sent: Tuesday, August 05, 2014 5:22 PM
To: Vikrampal
Cc: 'Luiz Augusto von Dentz'; [email protected]; 'Dmitry Kasatkin'
Subject: Re: AVCTP and AVRCP packet decoder file structure in btmonQuoted 6 lines · On Tue, 05 Aug 2014 12:24:44 +0530 Vikrampal <[email protected]> wrote:
Sure Luiz!
However, I've one more small doubt. If I'm submitting a series of patches Such as 1/4, 2/4, 3/4, 4/4... I guess in such scenarios no need to ensure that the patches separately compiles. What we need to ensure is that all the patches together gets compiled properly. Am I
mistaken?
Quoted 1 line
Quoted 8 lines
Make sure that sub-sequences of a series produce sensible code.
The code should $VALIDATE with 1/4 applied.
The code should $VALIDATE with 1/4 and 2/4 applied. The code should $VALIDATE with 1/4, 2/4 and 3/4 applied. The code should $VALIDATE with 1/4, 2/4, 3/4 and 4/4 applied.The definition of VALIDATE can vary project by project or feature by
feature;
Quoted 11 lines
the minimum requirement should be that compilation always succeeds.
You can use something like:
git rebase -i --exec "make" some_parent_branchto test that compilation passes after each commit.
Ciao,
Antonio
Quoted 7 lines
--
Antonio Ospite
http://ao2.itA: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
Regards,
Vikram