f2fs: fix error path in init_inode_metadata
Subsystems (2)
PATCH 1/1 f2fs: fix error path in init_inode_metadata
If we fail in this path:
->init_inode_metadata
->make_empty_dir
->get_new_data_page
->grab_cache_page return -ENOMEMWe will bug on in error path of init_inode_metadata when call remove_inode_page because i_block = 2 (one inode block will be released later & one dentry block).
We should release the dentry block in init_inode_metadata to avoid this BUG_ON, and avoid leak of dentry block resource, because we never have second chance to release that block in ->evict_inode as in upper error path we make this inode 'bad'.
Signed-off-by Chao Yu <[email protected]>
--- fs/f2fs/dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/f2fs/dir.c +1 -1
@@ -384,11 +384,11 @@ static struct page *init_inode_metadata(struct inode *inode, put_error:f2fs_put_page (page,1 ); +error:/* once the failed inode becomes a bad inode, i_mode is S_IFREG */ truncate_inode_pages (&inode->i_data,0 );truncate_blocks (inode,0 );remove_dirty_dir_inode (inode); -error:remove_inode_page (inode);return ERR_PTR (err); }
Signature · 10 lines
1.7.9.5 ------------------------------------------------------------------------------ Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita BPM Community Edition Quickly connect people, data, and systems into organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft