PG_reserved bug
Hi,
I've found a bug in the 2.4.20 kernel (might have appeared before), that if the PG_reserved flag is set on a page, its reference count will be incremented but won't be decremented. This is due to the wrong order of lazy if tests in __free_pages().
I have two questions:
1. How do I report it? I found no maintainer for MM in MAINTAINERS
2. I'm writing a module that gets pages (via __get_free_pages) and holds them throughout its lifetime. Where must I check if this page can be taken from under me, without using the reserved bit? In other words, if I want to make sure the behavior is the same with or without the reserved bit, what must I maintain?
Thanks,
Amir.
Quoted 4 lines · Amir Hermelin
Hi,
I've found a bug in the 2.4.20 kernel (might have appeared before), that if thePG_reservedflag is set on a page, its reference count will be incremented but won't be decremented. This is due to the wrong order of
Quoted 8 lines
lazy if tests in
__free_pages().
I have two questions:
1. How do I report it? I found no maintainer for MM inMAINTAINERS
2. I'm writing a module that gets pages (via__get_free_pages) and holds them throughout its lifetime. Where must I check if this page can be taken from under me, without using the reserved bit? In other words, if I want to make sure the behavior is the same with or without the reserved bit, what must I maintain?
Reserved pages are excepted from normal reference counting rules. The allocators of reserved pages are expected to clear reference counts themselves before returning them to the system (if they ever do).
-- wli
Ok, fair enough. According to what you say, this behavior won't change in 2.6. So, I'm still left with my second question: since I do access the pages from several places in my module, and I want to use the refcount field of the struct page (and not have to wrap the pages in another structure) so I know when my page is no longer referenced, how can I make sure it's 'safe' to not use the reserved bit?
Amir.
-----Original Message-----
From: William Lee Irwin III [mailto:[email protected]]
Sent: Wednesday, November 26, 2003 12:18 PM
To: Amir Hermelin
Cc: [email protected]
Subject: Re: PG_reserved bug
Quoted 8 lines · Amir Hermelin
Hi,
I've found a bug in the 2.4.20 kernel (might have appeared before), that if thePG_reservedflag is set on a page, its reference count will be incremented but won't be decremented. This is due to the wrong order of lazy if tests in__free_pages(). I have two questions:
1. How do I report it? I found no maintainer for MM inMAINTAINERS
2. I'm writing a module that gets pages (via__get_free_pages) and holds them throughout its lifetime. Where must I check if this page can be
taken
Quoted 1 line
from under me, without using the reserved bit? In other words, if I want
to
Quoted 2 lines
make sure the behavior is the same with or without the reserved bit, what must I maintain?
Reserved pages are excepted from normal reference counting rules. The allocators of reserved pages are expected to clear reference counts themselves before returning them to the system (if they ever do).
-- wli
Quoted 6 lines · Amir Hermelin
Ok, fair enough. According to what you say, this behavior won't change in 2.6. So, I'm still left with my second question: since I do access the pages from several places in my module, and I want to use the refcount field of the struct page (and not have to wrap the pages in another structure) so I know when my page is no longer referenced, how can I make sure it's 'safe' to not use the reserved bit?
It looks like you'll have to wrap the pages in another structure. The refcounts for reserved pages are effectively meaningless.
-- wli
Can't I just not use the reserved bit (therefore effectively use the refcount), and keep the minimal count at 1 or 2? Will that have the same effect as setting the reserved bit?
Amir.
-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of William Lee Irwin III
Sent: Wednesday, November 26, 2003 2:50 PM
To: Amir Hermelin
Cc: [email protected]
Subject: Re: PG_reserved bug
Quoted 6 lines · Amir Hermelin
Ok, fair enough. According to what you say, this behavior won't change in 2.6. So, I'm still left with my second question: since I do access the pages from several places in my module, and I want to use the refcount field of the struct page (and not have to wrap the pages in another structure) so I know when my page is no longer referenced, how can I make sure it's 'safe' to not use the reserved bit?
It looks like you'll have to wrap the pages in another structure. The refcounts for reserved pages are effectively meaningless.
-- wli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Quoted 3 lines · Amir Hermelin
Can't I just not use the reserved bit (therefore effectively use the refcount), and keep the minimal count at 1 or 2? Will that have the same effect as setting the reserved bit?
You can do that, yes. There are certain disadvantages to doing so, e.g. poor interactions with higher-order allocations.
-- wli