Skip to contentSkip to conversation

FB: added a structure for CPU interface to linux/fb.h

PATCH New Inki Dae 2 participants 3 messages Nov 23, 2010 – Nov 24, 2010 Framebuffer layer

lore
Share & tools
lore

Inki Dae

author
#0 lore raw

PATCH 1/4 FB: added a structure for CPU interface to linux/fb.h

RGB or CPU interfaces could be used as display mode but framebuffer framework doesn't consider CPU interface so I added this structure because fb_cpumode structure could be used commonly.

---
 include/linux/fb.h |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)
include/linux/fb.h +12 -0
index 7fca3dc..9b9842c 100644
@@ -1147,6 +1147,18 @@ struct fb_videomode {
 	u32 flag;
 };
 
+struct fb_cpumode {
+	const char *name;	/* optional */
+	u32 refresh;		/* optional */
+	u32 xres;
+	u32 yres;
+	u32 pixclock;
+	u32 cs_setup;
+	u32 wr_setup;
+	u32 wr_act;
+	u32 wr_hold;
+};
+
 extern const char *fb_mode_option;
 extern const struct fb_videomode vesa_modes[];
 
Signature · 1 line
1.5.4.3
#1 lore raw

PATCH 1/4 FB: added a structure for CPU interface to linux/fb.h

Hello.

Quoted 15 lines · Inki Dae

RGB or CPU interfaces could be used as display mode but framebuffer framework doesn't consider CPU interface so I added this structure because fb_cpumode structure could be used commonly.

---
 include/linux/fb.h |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)
include/linux/fb.h +0 -0
index 7fca3dc..9b9842c 100644

include/linux/fb.h struct fb_videomode { · line 1154

Quoted 8 lines
include/linux/fb.h +5 -0
@@ -1147,6 +1147,18 @@ struct fb_videomode {
 	u32 flag;
 };
 
+struct fb_cpumode {
+	const char *name;	/* optional */
+	u32 refresh;		/* optional */
+	u32 xres;
+	u32 yres;

I think that those two fields should happily fit into 'u16' type.

include/linux/fb.h struct fb_videomode { · line 1159

Quoted 5 lines
include/linux/fb.h +5 -0
+	u32 pixclock;
+	u32 cs_setup;
+	u32 wr_setup;
+	u32 wr_act;
+	u32 wr_hold;

Suspecting the same about the above 4 fields...

WBR, Sergei

author
#2 lore raw

PATCH 1/4 FB: added a structure for CPU interface to linux/fb.h

Hello.

Below is my comments
Thank you.

Quoted 32 lines

-----Original Message-----
From: Sergei Shtylyov [mailto:sshtylyov at mvista.com]
Sent: Wednesday, November 24, 2010 1:02 AM
To: Inki Dae
Cc: linux-fbdev at vger.kernel.org; linux-arm-kernel at lists.infradead.org; kyungmin.park at samsung.com; kgene.kim at samsung.com; akpm at linux- foundation.org; lethal at linux-sh.org
Subject: Re: [PATCH 1/4] FB: added a structure for CPU interface to linux/fb.h

Hello.

Quoted 18 lines · Inki Dae

RGB or CPU interfaces could be used as display mode but framebuffer framework doesn't consider CPU interface so I added this structure because fb_cpumode structure could be used commonly.

---
 include/linux/fb.h |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)
include/linux/fb.h +0 -0
index 7fca3dc..9b9842c 100644
@@ -1147,6 +1147,18 @@ struct fb_videomode {
 	u32 flag;
 };
 
Quoted 8 lines

include/linux/fb.h struct fb_videomode { · line 1154

Quoted 5 lines
include/linux/fb.h +5 -0
+struct fb_cpumode {
+	const char *name;	/* optional */
+	u32 refresh;		/* optional */
+	u32 xres;
+	u32 yres;

I think that those two fields should happily fit into 'u16' type.

I agree to your opinion, but I just followed existing struct fb_videomode. Do you or everybody have any idea for whether changing typef('u32' -> 'u16') or not?
if it is more better to modify type then I will correct it.

Quoted 8 lines

include/linux/fb.h struct fb_videomode { · line 1159

Quoted 5 lines
include/linux/fb.h +5 -0
+	u32 pixclock;
+	u32 cs_setup;
+	u32 wr_setup;
+	u32 wr_act;
+	u32 wr_hold;

Suspecting the same about the above 4 fields...

Same.

Quoted 1 line

WBR, Sergei