phy: Add driver for Exynos DP PHY
Subsystems (5)
PATCH 1/3 phy: Add driver for Exynos DP PHY
Add a PHY provider driver for the Samsung Exynos SoC DP PHY.
Signed-off-by Jingoo Han <[email protected]>
--- .../phy/samsung,exynos5250-dp-video-phy.txt | 7 ++ drivers/phy/Kconfig | 8 ++ drivers/phy/Makefile | 3 +- drivers/phy/phy-exynos-dp-video.c | 130 ++++++++++++++++++++ 4 files changed, 147 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/phy/samsung,exynos5250-dp-video-phy.txt create mode 100644 drivers/phy/phy-exynos-dp-video.c
(quoted diff) +0 -0
b/Documentation/devicetree/bindings/phy/samsung,exynos5250-dp-video-phy.txt new file mode 100644
index 0000000..8b6fa79
Documentation/devicetree/bindings/phy/samsung,exynos5250-dp-video-phy.txt new file +7 -0
@@ -0,0 +1,7 @@ +Samsung EXYNOS SoC series DP PHY +------------------------------------------------- + +Required properties: +- compatible : should be "samsung,exynos5250-dp-video-phy"; +- reg : offset and length of the DP PHY register set; +- #phy-cells : from the generic phy bindings, must be 1;
drivers/phy/Kconfig +8 -0
@@ -11,3 +11,11 @@ menuconfig GENERIC_PHY devices present in the kernel. This layer will have the generic API by which phy drivers can create PHY using the phy framework and phy users can obtain reference to the PHY. + +if GENERIC_PHY + +config PHY_EXYNOS_DP_VIDEO + tristate "EXYNOS SoC series DP PHY driver" + help + Support for DP PHY found on Samsung EXYNOS SoCs. +endif
drivers/phy/Makefile +2 -1
@@ -2,4 +2,5 @@ # Makefile for the phy drivers. # -obj-$(CONFIG_GENERIC_PHY) += phy-core.o +obj-$(CONFIG_GENERIC_PHY) += phy-core.o +obj-$(CONFIG_PHY_EXYNOS_DP_VIDEO) += phy-exynos-dp-video.o
drivers/phy/phy-exynos-dp-video.c new file +130 -0
130 lines not on this page · raw message
Signature · 1 line
1.7.10.4
PATCH 1/3 phy: Add driver for Exynos DP PHY
Hi,
Quoted 61 lines · Jingoo Han
Add a PHY provider driver for the Samsung Exynos SoC DP PHY.
Signed-off-by Jingoo Han <[email protected]>--- .../phy/samsung,exynos5250-dp-video-phy.txt | 7 ++ drivers/phy/Kconfig | 8 ++ drivers/phy/Makefile | 3 +- drivers/phy/phy-exynos-dp-video.c | 130 ++++++++++++++++++++ 4 files changed, 147 insertions(+), 1 deletion(-)create mode 100644
Documentation/devicetree/bindings/phy/samsung,exynos5250-dp-video-phy.txtcreate mode 100644drivers/phy/phy-exynos-dp-video.cDocumentation/devicetree/bindings/phy/samsung,exynos5250-dp-video-phy.txt new file +7
-0@@ -0,0 +1,7 @@ +Samsung EXYNOS SoC series DP PHY +------------------------------------------------- + +Required properties: +- compatible : should be "samsung,exynos5250-dp-video-phy"; +- reg : offset and length of the DP PHY register set; +- #phy-cells : from the generic phy bindings, must be 1;drivers/phy/Kconfig +8
-0@@ -11,3 +11,11 @@ menuconfig GENERIC_PHY devices present in the kernel. This layer will have the generic API by which phy drivers can create PHY using the phy framework and phy users can obtain reference to the PHY. + +if GENERIC_PHY + +config PHY_EXYNOS_DP_VIDEO + tristate "EXYNOS SoC series DP PHY driver" + help + Support for DP PHY found on Samsung EXYNOS SoCs. +endifdrivers/phy/Makefile +2
-1@@ -2,4 +2,5 @@ # Makefile for the phy drivers. # -obj-$(CONFIG_GENERIC_PHY) += phy-core.o +obj-$(CONFIG_GENERIC_PHY) += phy-core.o +obj-$(CONFIG_PHY_EXYNOS_DP_VIDEO) += phy-exynos-dp-video.odrivers/phy/phy-exynos-dp-video.c new file +2
-0@@ -0,0 +1,130 @@ +/* +* Samsung EXYNOS SoC series DP PHY driver
drivers/phy/phy-exynos-dp-video.c line 12
Quoted 10 lines
drivers/phy/phy-exynos-dp-video.c new file +10
-0+* +* Copyright (C) 2013 Samsung Electronics Co., Ltd. +* Author: Jingoo Han <[email protected]> +* +* This program is free software; you can redistribute it and/or modify +* it under the terms of the GNU General Public License version 2 as +* published by the Free Software Foundation. +*/ + +#include <linux/delay.h>
this header file is not needed here.
Quoted 47 lines
drivers/phy/phy-exynos-dp-video.c new file +47
-0+#include <linux/io.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/of_address.h> +#include <linux/phy/phy.h> +#include <linux/platform_device.h> +#include <linux/spinlock.h> + +/* DPTX_PHY_CONTROL register */ +#define EXYNOS_DPTX_PHY_ENABLE (1 << 0) + +struct exynos_dp_video_phy { +spinlock_t slock; +struct phy *phys; +void __iomem *regs; +}; + +static int __set_phy_state (struct exynos_dp_video_phy *state,unsigned int on) +{ +void __iomem *addr; +unsigned long flags; +u32 reg; + + addr = state->regs; + +spin_lock_irqsave (&state->slock, flags); + reg =readl (addr); +if (on) + reg |=EXYNOS_DPTX_PHY_ENABLE ; +else + reg &= ~EXYNOS_DPTX_PHY_ENABLE ; +writel (reg, addr); +spin_unlock_irqrestore (&state->slock, flags); +return 0 ; +} + +static int exynos_dp_video_phy_power_on (struct phy *phy) +{ +struct exynos_dp_video_phy *state =phy_get_drvdata (phy); + +return __set_phy_state (state,1 ); +} + +static int exynos_dp_video_phy_power_off (struct phy *phy) +{ +struct exynos_dp_video_phy *state =phy_get_drvdata (phy);
drivers/phy/phy-exynos-dp-video.c line 69
Quoted 10 lines
drivers/phy/phy-exynos-dp-video.c new file +10
-0+ +return __set_phy_state (state,0 ); +} + +static struct phy *exynos_dp_video_phy_xlate (struct device *dev, +struct of_phandle_args *args) +{ +struct exynos_dp_video_phy *state =dev_get_drvdata (dev); + +return state->phys;
you can instead use of_phy_simple_xlate for such simple cases.
Quoted 37 lines
drivers/phy/phy-exynos-dp-video.c new file +37
-0+} + +static struct phy_ops exynos_dp_video_phy_ops = { + .power_on = exynos_dp_video_phy_power_on, + .power_off = exynos_dp_video_phy_power_off, + .owner =THIS_MODULE , +}; + +static int exynos_dp_video_phy_probe (struct platform_device *pdev) +{ +struct exynos_dp_video_phy *state; +struct device *dev = &pdev->dev; +struct resource *res; +struct phy_provider *phy_provider; + + state =devm_kzalloc (dev,sizeof (*state),GFP_KERNEL ); +if (!state) +return -ENOMEM ; + + res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); + + state->regs =devm_ioremap_resource (dev, res); +if (IS_ERR (state->regs)) +return PTR_ERR (state->regs); + +dev_set_drvdata (dev, state); + + phy_provider =devm_of_phy_provider_register (dev, + exynos_dp_video_phy_xlate); +if (IS_ERR (phy_provider)) +return PTR_ERR (phy_provider); + + state->phys =devm_phy_create (dev,0 , &exynos_dp_video_phy_ops,"dp" ); +if (IS_ERR (state->phys)) { +dev_err (dev,"failed to create DP PHY\n" ); +return PTR_ERR (state->phys); + }
drivers/phy/phy-exynos-dp-video.c line 116
Quoted 10 lines
drivers/phy/phy-exynos-dp-video.c new file +10
-0+phy_set_drvdata (state->phys, state); + +return 0 ; +} + +static const struct of_device_id exynos_dp_video_phy_of_match[] = { + { .compatible ="samsung,exynos5250-dp-video-phy" }, + { }, +}; +MODULE_DEVICE_TABLE (of, exynos_dp_video_phy_of_match);
This above should come inside #ifdef CONFIG_OF.
drivers/phy/phy-exynos-dp-video.c line 119
Quoted 3 lines
drivers/phy/phy-exynos-dp-video.c new file +3
-0+ +static struct platform_driver exynos_dp_video_phy_driver = { + .probe = exynos_dp_video_phy_probe,
missing .remove?
drivers/phy/phy-exynos-dp-video.c line 130
Quoted 11 lines
drivers/phy/phy-exynos-dp-video.c new file +11
-0+ .driver = { + .of_match_table = exynos_dp_video_phy_of_match, + .name = "exynos-dp-video-phy", + .owner = THIS_MODULE, + } +}; +module_platform_driver (exynos_dp_video_phy_driver); + +MODULE_DESCRIPTION ("Samsung EXYNOS SoC DP PHY driver" ); +MODULE_AUTHOR ("Jingoo Han <[email protected]>" ); +MODULE_LICENSE ("GPL v2" );
Thanks
Kishon
PATCH 1/3 phy: Add driver for Exynos DP PHY
Quoted 69 lines · Kishon Vijay Abraham I
Hi,
Quoted 65 lines · Jingoo Han
Add a PHY provider driver for the Samsung Exynos SoC DP PHY.
Signed-off-by Jingoo Han <[email protected]>--- .../phy/samsung,exynos5250-dp-video-phy.txt | 7 ++ drivers/phy/Kconfig | 8 ++ drivers/phy/Makefile | 3 +- drivers/phy/phy-exynos-dp-video.c | 130 ++++++++++++++++++++ 4 files changed, 147 insertions(+), 1 deletion(-)create mode 100644
Documentation/devicetree/bindings/phy/samsung,exynos5250-dp-video-phy.txtcreate mode 100644drivers/phy/phy-exynos-dp-video.cDocumentation/devicetree/bindings/phy/samsung,exynos5250-dp-video-phy.txt new file +7
-0@@ -0,0 +1,7 @@ +Samsung EXYNOS SoC series DP PHY +------------------------------------------------- + +Required properties: +- compatible : should be "samsung,exynos5250-dp-video-phy"; +- reg : offset and length of the DP PHY register set; +- #phy-cells : from the generic phy bindings, must be 1;drivers/phy/Kconfig +8
-0@@ -11,3 +11,11 @@ menuconfig GENERIC_PHY devices present in the kernel. This layer will have the generic API by which phy drivers can create PHY using the phy framework and phy users can obtain reference to the PHY. + +if GENERIC_PHY + +config PHY_EXYNOS_DP_VIDEO + tristate "EXYNOS SoC series DP PHY driver" + help + Support for DP PHY found on Samsung EXYNOS SoCs. +endifdrivers/phy/Makefile +2
-1@@ -2,4 +2,5 @@ # Makefile for the phy drivers. # -obj-$(CONFIG_GENERIC_PHY) += phy-core.o +obj-$(CONFIG_GENERIC_PHY) += phy-core.o +obj-$(CONFIG_PHY_EXYNOS_DP_VIDEO) += phy-exynos-dp-video.odrivers/phy/phy-exynos-dp-video.c new file +6
-0@@ -0,0 +1,130 @@ +/* +* Samsung EXYNOS SoC series DP PHY driver +* +* Copyright (C) 2013 Samsung Electronics Co., Ltd. +* Author: Jingoo Han <[email protected]> +*
Quoted 8 lines
drivers/phy/phy-exynos-dp-video.c line 12
Quoted 6 lines
drivers/phy/phy-exynos-dp-video.c new file +6
-0+* This program is free software; you can redistribute it and/or modify +* it under the terms of the GNU General Public License version 2 as +* published by the Free Software Foundation. +*/ + +#include <linux/delay.h> this header file is not needed here.
OK, I will remove it.
Quoted 52 lines
Quoted 52 lines
drivers/phy/phy-exynos-dp-video.c new file +51
-0+#include <linux/io.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/of_address.h> +#include <linux/phy/phy.h> +#include <linux/platform_device.h> +#include <linux/spinlock.h> + +/* DPTX_PHY_CONTROL register */ +#define EXYNOS_DPTX_PHY_ENABLE (1 << 0) + +struct exynos_dp_video_phy { +spinlock_t slock; +struct phy *phys; +void __iomem *regs; +}; + +static int __set_phy_state (struct exynos_dp_video_phy *state,unsigned int on) +{ +void __iomem *addr; +unsigned long flags; +u32 reg; + + addr = state->regs; + +spin_lock_irqsave (&state->slock, flags); + reg =readl (addr); +if (on) + reg |=EXYNOS_DPTX_PHY_ENABLE ; +else + reg &= ~EXYNOS_DPTX_PHY_ENABLE ; +writel (reg, addr); +spin_unlock_irqrestore (&state->slock, flags); +return 0 ; +} + +static int exynos_dp_video_phy_power_on (struct phy *phy) +{ +struct exynos_dp_video_phy *state =phy_get_drvdata (phy); + +return __set_phy_state (state,1 ); +} + +static int exynos_dp_video_phy_power_off (struct phy *phy) +{ +struct exynos_dp_video_phy *state =phy_get_drvdata (phy); + +return __set_phy_state (state,0 ); +} +
Quoted 8 lines
drivers/phy/phy-exynos-dp-video.c line 69
Quoted 6 lines
drivers/phy/phy-exynos-dp-video.c new file +6
-0+static struct phy *exynos_dp_video_phy_xlate (struct device *dev, +struct of_phandle_args *args) +{ +struct exynos_dp_video_phy *state =dev_get_drvdata (dev); + +return state->phys;you can instead use
of_phy_simple_xlatefor such simple cases.
OK, I will use of_phy_simple_xlate().
Quoted 41 lines
Quoted 41 lines
drivers/phy/phy-exynos-dp-video.c new file +41
-0+} + +static struct phy_ops exynos_dp_video_phy_ops = { + .power_on = exynos_dp_video_phy_power_on, + .power_off = exynos_dp_video_phy_power_off, + .owner =THIS_MODULE , +}; + +static int exynos_dp_video_phy_probe (struct platform_device *pdev) +{ +struct exynos_dp_video_phy *state; +struct device *dev = &pdev->dev; +struct resource *res; +struct phy_provider *phy_provider; + + state =devm_kzalloc (dev,sizeof (*state),GFP_KERNEL ); +if (!state) +return -ENOMEM ; + + res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); + + state->regs =devm_ioremap_resource (dev, res); +if (IS_ERR (state->regs)) +return PTR_ERR (state->regs); + +dev_set_drvdata (dev, state); + + phy_provider =devm_of_phy_provider_register (dev, + exynos_dp_video_phy_xlate); +if (IS_ERR (phy_provider)) +return PTR_ERR (phy_provider); + + state->phys =devm_phy_create (dev,0 , &exynos_dp_video_phy_ops,"dp" ); +if (IS_ERR (state->phys)) { +dev_err (dev,"failed to create DP PHY\n" ); +return PTR_ERR (state->phys); + } +phy_set_drvdata (state->phys, state); + +return 0 ; +}
Quoted 8 lines
drivers/phy/phy-exynos-dp-video.c line 116
Quoted 6 lines
drivers/phy/phy-exynos-dp-video.c new file +6
-0+ +static const struct of_device_id exynos_dp_video_phy_of_match[] = { + { .compatible ="samsung,exynos5250-dp-video-phy" }, + { }, +}; +MODULE_DEVICE_TABLE (of, exynos_dp_video_phy_of_match);This above should come inside #ifdef
CONFIG_OF.
OK, I will add '#ifdef CONFIG_OF'.
Quoted 5 lines
drivers/phy/phy-exynos-dp-video.c line 119
Quoted 3 lines
drivers/phy/phy-exynos-dp-video.c new file +3
-0+ +static struct platform_driver exynos_dp_video_phy_driver = { + .probe = exynos_dp_video_phy_probe,missing .remove?
No, it is intentional.
In the exynos_dp_video_phy_probe(), only devm_*() are called as below.
devm_kzalloc(),
devm_ioremap_resource(),
devm_of_phy_provider_register(),
devm_phy_create(),
Also, dev_set_drvdata(dev, NULL), phy_set_drvdata(state->phys, NULL) are not necessary in remove(), because driver core clears automatically after device_release.
Thus, there is no functions in the remove().
Thank you for your comment. :)
It is very helpful.
Best regards,
Jingoo Han
Quoted 14 lines
drivers/phy/phy-exynos-dp-video.c line 130
Quoted 11 lines
drivers/phy/phy-exynos-dp-video.c new file +11
-0+ .driver = { + .of_match_table = exynos_dp_video_phy_of_match, + .name = "exynos-dp-video-phy", + .owner = THIS_MODULE, + } +}; +module_platform_driver (exynos_dp_video_phy_driver); + +MODULE_DESCRIPTION ("Samsung EXYNOS SoC DP PHY driver" ); +MODULE_AUTHOR ("Jingoo Han <[email protected]>" ); +MODULE_LICENSE ("GPL v2" );Thanks
Kishon
PATCH 1/3 phy: Add driver for Exynos DP PHY
Hi,
Quoted 210 lines · Jingoo Han
Quoted 69 lines · Kishon Vijay Abraham I
Hi,
Quoted 65 lines · Jingoo Han
Add a PHY provider driver for the Samsung Exynos SoC DP PHY.
Signed-off-by Jingoo Han <[email protected]>--- .../phy/samsung,exynos5250-dp-video-phy.txt | 7 ++ drivers/phy/Kconfig | 8 ++ drivers/phy/Makefile | 3 +- drivers/phy/phy-exynos-dp-video.c | 130 ++++++++++++++++++++ 4 files changed, 147 insertions(+), 1 deletion(-)create mode 100644
Documentation/devicetree/bindings/phy/samsung,exynos5250-dp-video-phy.txtcreate mode 100644drivers/phy/phy-exynos-dp-video.cDocumentation/devicetree/bindings/phy/samsung,exynos5250-dp-video-phy.txt new file +7
-0@@ -0,0 +1,7 @@ +Samsung EXYNOS SoC series DP PHY +------------------------------------------------- + +Required properties: +- compatible : should be "samsung,exynos5250-dp-video-phy"; +- reg : offset and length of the DP PHY register set; +- #phy-cells : from the generic phy bindings, must be 1;drivers/phy/Kconfig +8
-0@@ -11,3 +11,11 @@ menuconfig GENERIC_PHY devices present in the kernel. This layer will have the generic API by which phy drivers can create PHY using the phy framework and phy users can obtain reference to the PHY. + +if GENERIC_PHY + +config PHY_EXYNOS_DP_VIDEO + tristate "EXYNOS SoC series DP PHY driver" + help + Support for DP PHY found on Samsung EXYNOS SoCs. +endifdrivers/phy/Makefile +2
-1@@ -2,4 +2,5 @@ # Makefile for the phy drivers. # -obj-$(CONFIG_GENERIC_PHY) += phy-core.o +obj-$(CONFIG_GENERIC_PHY) += phy-core.o +obj-$(CONFIG_PHY_EXYNOS_DP_VIDEO) += phy-exynos-dp-video.odrivers/phy/phy-exynos-dp-video.c new file +6
-0@@ -0,0 +1,130 @@ +/* +* Samsung EXYNOS SoC series DP PHY driver +* +* Copyright (C) 2013 Samsung Electronics Co., Ltd. +* Author: Jingoo Han <[email protected]> +* Quoted 8 lines
drivers/phy/phy-exynos-dp-video.c line 12
Quoted 6 lines
drivers/phy/phy-exynos-dp-video.c new file +6
-0+* This program is free software; you can redistribute it and/or modify +* it under the terms of the GNU General Public License version 2 as +* published by the Free Software Foundation. +*/ + +#include <linux/delay.h> this header file is not needed here.
OK, I will remove it.
Quoted 52 lines
Quoted 52 lines
drivers/phy/phy-exynos-dp-video.c new file +51
-0+#include <linux/io.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/of_address.h> +#include <linux/phy/phy.h> +#include <linux/platform_device.h> +#include <linux/spinlock.h> + +/* DPTX_PHY_CONTROL register */ +#define EXYNOS_DPTX_PHY_ENABLE (1 << 0) + +struct exynos_dp_video_phy { +spinlock_t slock; +struct phy *phys; +void __iomem *regs; +}; + +static int __set_phy_state (struct exynos_dp_video_phy *state,unsigned int on) +{ +void __iomem *addr; +unsigned long flags; +u32 reg; + + addr = state->regs; + +spin_lock_irqsave (&state->slock, flags); + reg =readl (addr); +if (on) + reg |=EXYNOS_DPTX_PHY_ENABLE ; +else + reg &= ~EXYNOS_DPTX_PHY_ENABLE ; +writel (reg, addr); +spin_unlock_irqrestore (&state->slock, flags); +return 0 ; +} + +static int exynos_dp_video_phy_power_on (struct phy *phy) +{ +struct exynos_dp_video_phy *state =phy_get_drvdata (phy); + +return __set_phy_state (state,1 ); +} + +static int exynos_dp_video_phy_power_off (struct phy *phy) +{ +struct exynos_dp_video_phy *state =phy_get_drvdata (phy); + +return __set_phy_state (state,0 ); +} +Quoted 8 lines
drivers/phy/phy-exynos-dp-video.c line 69
Quoted 6 lines
drivers/phy/phy-exynos-dp-video.c new file +6
-0+static struct phy *exynos_dp_video_phy_xlate (struct device *dev, +struct of_phandle_args *args) +{ +struct exynos_dp_video_phy *state =dev_get_drvdata (dev); + +return state->phys;you can instead use
of_phy_simple_xlatefor such simple cases.OK, I will use
of_phy_simple_xlate().Quoted 41 lines
Quoted 41 lines
drivers/phy/phy-exynos-dp-video.c new file +41
-0+} + +static struct phy_ops exynos_dp_video_phy_ops = { + .power_on = exynos_dp_video_phy_power_on, + .power_off = exynos_dp_video_phy_power_off, + .owner =THIS_MODULE , +}; + +static int exynos_dp_video_phy_probe (struct platform_device *pdev) +{ +struct exynos_dp_video_phy *state; +struct device *dev = &pdev->dev; +struct resource *res; +struct phy_provider *phy_provider; + + state =devm_kzalloc (dev,sizeof (*state),GFP_KERNEL ); +if (!state) +return -ENOMEM ; + + res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); + + state->regs =devm_ioremap_resource (dev, res); +if (IS_ERR (state->regs)) +return PTR_ERR (state->regs); + +dev_set_drvdata (dev, state); + + phy_provider =devm_of_phy_provider_register (dev, + exynos_dp_video_phy_xlate); +if (IS_ERR (phy_provider)) +return PTR_ERR (phy_provider); + + state->phys =devm_phy_create (dev,0 , &exynos_dp_video_phy_ops,"dp" ); +if (IS_ERR (state->phys)) { +dev_err (dev,"failed to create DP PHY\n" ); +return PTR_ERR (state->phys); + } +phy_set_drvdata (state->phys, state); + +return 0 ; +}Quoted 8 lines
drivers/phy/phy-exynos-dp-video.c line 116
Quoted 6 lines
drivers/phy/phy-exynos-dp-video.c new file +6
-0+ +static const struct of_device_id exynos_dp_video_phy_of_match[] = { + { .compatible ="samsung,exynos5250-dp-video-phy" }, + { }, +}; +MODULE_DEVICE_TABLE (of, exynos_dp_video_phy_of_match);This above should come inside #ifdef
CONFIG_OF.OK, I will add '#ifdef
CONFIG_OF'.Quoted 5 lines
drivers/phy/phy-exynos-dp-video.c line 119
Quoted 3 lines
drivers/phy/phy-exynos-dp-video.c new file +3
-0+ +static struct platform_driver exynos_dp_video_phy_driver = { + .probe = exynos_dp_video_phy_probe,missing .remove?
No, it is intentional.
In the
exynos_dp_video_phy_probe(), only devm_*() are called as below.
devm_kzalloc(),
devm_ioremap_resource(),devm_of_phy_provider_register(),
devm_phy_create(),
Quoted 5 lines
Also,
dev_set_drvdata(dev, NULL),phy_set_drvdata(state->phys, NULL)are not necessary inremove(), because driver core clears automatically afterdevice_release.Thus, there is no functions in the
remove().
Looks correct. Alright then.
Thanks
Kishon
PATCH 1/3 phy: Add driver for Exynos DP PHY
In reply to Jingoo HanHi,
Documentation/devicetree/bindings/phy/samsung,exynos5250-dp-video-phy.txt
Quoted 18 lines · Jingoo Han
Add a PHY provider driver for the Samsung Exynos SoC DP PHY.
Signed-off-by Jingoo Han <[email protected]>--- .../phy/samsung,exynos5250-dp-video-phy.txt | 7 ++ drivers/phy/Kconfig | 8 ++ drivers/phy/Makefile | 3 +- drivers/phy/phy-exynos-dp-video.c | 130 ++++++++++++++++++++ 4 files changed, 147 insertions(+), 1 deletion(-)create mode 100644
Documentation/devicetree/bindings/phy/samsung,exynos5250-dp-video-phy.txtcreate mode 100644drivers/phy/phy-exynos-dp-video.cDocumentation/devicetree/bindings/phy/samsung,exynos5250-dp-video-phy.txt new file +0
-0
How about creating a single Documentation file for all samsung video phys? Sylwester?
Thanks
Kishon
PATCH 1/3 phy: Add driver for Exynos DP PHY
Hi,
Quoted 9 lines · Kishon Vijay Abraham I
Documentation/devicetree/bindings/phy/samsung,exynos5250-dp-video-phy.txt
Quoted 6 lines
Documentation/devicetree/bindings/phy/samsung,exynos5250-dp-video-phy.txt new file +0
-0How about creating a single Documentation file for all samsung video phys? Sylwester?
Yes, makes sense. There are quite a few various PHYs on the Exynos SoC. Let me resend my series with the binding description file name changed to samsung-phy.txt. I need to add couple fixes to that series anyway.
Regards,
Sylwester